)]}'
{"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"705527938a40ba328008de040af2a8db6fbc2b77","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    if extra_specs.cpu_limits.has_limits():"},{"line_number":232,"context_line":"        config_spec.cpuAllocation \u003d _get_allocation_info("},{"line_number":233,"context_line":"            client_factory, extra_specs.cpu_limits,"},{"line_number":234,"context_line":"            \u0027ns0:ResourceAllocationInfo\u0027)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    vif_spec_list \u003d []"},{"line_number":237,"context_line":"    for vif_info in vif_infos:"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a50d1a3_d1287999","line":234,"updated":"2015-07-29 11:25:55.000000000","message":"Feels like a slightly dodgy cut an paste between here an 302, but I will not block on that.","commit_id":"1bc2227076be187e8955e5f5c9ed535fe1e92f61"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2623cec20dcff4bc1c999168436ad5bf06691c3a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def _get_extra_specs(self, flavor):"},{"line_number":273,"context_line":"        extra_specs \u003d vm_util.ExtraSpecs()"},{"line_number":274,"context_line":"        for resource in [\u0027cpu\u0027]:"},{"line_number":275,"context_line":"            for (key, type) in ((\u0027limit\u0027, int),"},{"line_number":276,"context_line":"                                (\u0027reservation\u0027, int),"},{"line_number":277,"context_line":"                                (\u0027shares_level\u0027, str),"},{"line_number":278,"context_line":"                                (\u0027shares_share\u0027, int)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_79b41d81","line":275,"updated":"2015-05-19 22:35:47.000000000","message":"Well thinking again this \"limit\" argument seems not useful can we hide this to the user?","commit_id":"e859856f631e4505b8522fc522208d32b03000ed"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d9fdcc80ddac62e673e04aa44562a2948ef99e91","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def _get_extra_specs(self, flavor):"},{"line_number":273,"context_line":"        extra_specs \u003d vm_util.ExtraSpecs()"},{"line_number":274,"context_line":"        for resource in [\u0027cpu\u0027]:"},{"line_number":275,"context_line":"            for (key, type) in ((\u0027limit\u0027, int),"},{"line_number":276,"context_line":"                                (\u0027reservation\u0027, int),"},{"line_number":277,"context_line":"                                (\u0027shares_level\u0027, str),"},{"line_number":278,"context_line":"                                (\u0027shares_share\u0027, int)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c106731c","line":275,"in_reply_to":"7a016987_79b41d81","updated":"2015-05-20 00:52:05.000000000","message":"I am not sure what you mean here. An admin creates a flavor to enable instance to have limited resources for CPU. More specifically for limits cpu, reserved cpu and shares. Please see http://pubs.vmware.com/vsphere-55/index.jsp#com.vmware.wssdk.apiref.doc/vim.ResourceAllocationInfo.html for more explanations.\nThis patch enables us to extend this to the other topics mentioned in the commit message","commit_id":"e859856f631e4505b8522fc522208d32b03000ed"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ac7edc4383a71a48054b33efe1e93650d2e243","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def _get_extra_specs(self, flavor):"},{"line_number":273,"context_line":"        extra_specs \u003d vm_util.ExtraSpecs()"},{"line_number":274,"context_line":"        for resource in [\u0027cpu\u0027]:"},{"line_number":275,"context_line":"            for (key, type) in ((\u0027limit\u0027, int),"},{"line_number":276,"context_line":"                                (\u0027reservation\u0027, int),"},{"line_number":277,"context_line":"                                (\u0027shares_level\u0027, str),"},{"line_number":278,"context_line":"                                (\u0027shares_share\u0027, int)):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_8f0bf929","line":275,"in_reply_to":"7a016987_c106731c","updated":"2015-05-20 15:05:26.000000000","message":"Yes understand the aim of the patch but even that I was expected at the end we can work on making the same interface for all drivers to handle resource quotas. As you can see on https://wiki.openstack.org/wiki/InstanceResourceQuota We do not expose the ability to change the time clock of a CPU, then it does not make a lot of sense to add a new limit for memory and disk (since flavor + allocation_ratio already do it). So that is why I believe we probably should to remove this attribute and do not expose it.\n\nPlease let me know what do you think?","commit_id":"e859856f631e4505b8522fc522208d32b03000ed"}]}