)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f686b087b440975ceb3df4652319fa765eca8f33","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Xenapi: Change generate-configdrive to use cdrom"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently within nova.virt.xenapi.vm_utils generate-configdrive generates a VBD for the configdrive as vbd_type \u0027Disk\u0027, however the data itself is created with an ISO9660(CDFS) filesystem.  This issue does not currently cause any impact within *nix operating systems as the disk recognition and mounting abilities are quite lenient, however this does cause issues within a Windows DomU."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When attached to a Windows DomU the disk is not recognized in any way within the OS layer, whether this be through powershell or the standard GUI methods (such as Disk Management).  Changing the VBD type of cdrom corrects this, lines cloud-drive up with its intended purpose, and is still compatible with cloud-init configurations on both *nix and Windows.  This issue was addressed for libvirt within commit 7f4b5771633f519a54aae985ae526418114b1a29 and as such I have made the code look as similar as possible to maintain continuity.  This includes the new method and tests to pull the Nova config drive type desired from nova.conf."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_66cc9e6a","line":9,"updated":"2015-05-03 08:40:15.000000000","message":"Can you please have the max line at 80 characters\n\nplease see - https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1476e4741b8fe01013b757310c2a329dc7b10893"},{"author":{"_account_id":16148,"name":"Brooks Kaminski","username":"bhkaminski","inactive":true},"change_message_id":"13f93fe310f640db6643ffa5ef6f82f6e067ddea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Xenapi: Change generate-configdrive to use cdrom"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently within nova.virt.xenapi.vm_utils generate-configdrive generates a VBD for the configdrive as vbd_type \u0027Disk\u0027, however the data itself is created with an ISO9660(CDFS) filesystem.  This issue does not currently cause any impact within *nix operating systems as the disk recognition and mounting abilities are quite lenient, however this does cause issues within a Windows DomU."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"When attached to a Windows DomU the disk is not recognized in any way within the OS layer, whether this be through powershell or the standard GUI methods (such as Disk Management).  Changing the VBD type of cdrom corrects this, lines cloud-drive up with its intended purpose, and is still compatible with cloud-init configurations on both *nix and Windows.  This issue was addressed for libvirt within commit 7f4b5771633f519a54aae985ae526418114b1a29 and as such I have made the code look as similar as possible to maintain continuity.  This includes the new method and tests to pull the Nova config drive type desired from nova.conf."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_9402406e","line":9,"in_reply_to":"3acd31a7_66cc9e6a","updated":"2015-05-03 16:00:23.000000000","message":"My apologies, taken care of.","commit_id":"1476e4741b8fe01013b757310c2a329dc7b10893"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f686b087b440975ceb3df4652319fa765eca8f33","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"                   \u0027user\u0027, size_gb * 1024, CONF.default_ephemeral_format)"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"def get_config_drive_type():"},{"line_number":1141,"context_line":"    \"\"\"Determine the config_drive disk type from nova.conf"},{"line_number":1142,"context_line":"    \"\"\""},{"line_number":1143,"context_line":"    if CONF.config_drive_format \u003d\u003d \u0027iso9660\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_46c76245","line":1140,"updated":"2015-05-03 08:40:15.000000000","message":"any reason why this is not an internal method \u003d\u003e _get_config_drive_type","commit_id":"1476e4741b8fe01013b757310c2a329dc7b10893"},{"author":{"_account_id":16148,"name":"Brooks Kaminski","username":"bhkaminski","inactive":true},"change_message_id":"13f93fe310f640db6643ffa5ef6f82f6e067ddea","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"                   \u0027user\u0027, size_gb * 1024, CONF.default_ephemeral_format)"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"def get_config_drive_type():"},{"line_number":1141,"context_line":"    \"\"\"Determine the config_drive disk type from nova.conf"},{"line_number":1142,"context_line":"    \"\"\""},{"line_number":1143,"context_line":"    if CONF.config_drive_format \u003d\u003d \u0027iso9660\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_74d32405","line":1140,"in_reply_to":"3acd31a7_46c76245","updated":"2015-05-03 16:00:23.000000000","message":"It actually didn\u0027t hit my mind for some reason that it would not be called on its own.  My bad!  Fixed :)","commit_id":"1476e4741b8fe01013b757310c2a329dc7b10893"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f686b087b440975ceb3df4652319fa765eca8f33","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"        create_vbd(session, vm_ref, vdi_ref, userdevice,"},{"line_number":1182,"context_line":"                   vbd_type\u003ddevice_type, read_only\u003dTrue, bootable\u003dFalse)"},{"line_number":1183,"context_line":"    except Exception:"},{"line_number":1184,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1185,"context_line":"            msg \u003d \"Error while generating config drive\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_06c16a2e","line":1182,"range":{"start_line":1182,"start_character":19,"end_line":1182,"end_character":40},"updated":"2015-05-03 08:40:15.000000000","message":"you could put vbd_type\u003ddevice_type as the last parameter (would make the review a little easier :)","commit_id":"1476e4741b8fe01013b757310c2a329dc7b10893"},{"author":{"_account_id":16148,"name":"Brooks Kaminski","username":"bhkaminski","inactive":true},"change_message_id":"13f93fe310f640db6643ffa5ef6f82f6e067ddea","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"        create_vbd(session, vm_ref, vdi_ref, userdevice,"},{"line_number":1182,"context_line":"                   vbd_type\u003ddevice_type, read_only\u003dTrue, bootable\u003dFalse)"},{"line_number":1183,"context_line":"    except Exception:"},{"line_number":1184,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1185,"context_line":"            msg \u003d \"Error while generating config drive\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_94eb60b0","line":1182,"in_reply_to":"3acd31a7_06c16a2e","updated":"2015-05-03 16:00:23.000000000","message":"Done","commit_id":"1476e4741b8fe01013b757310c2a329dc7b10893"}]}