)]}'
{"nova/network/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"29c7dbc8b3563d9a002f50b555219b16c3c24e8f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if not network_driver:"},{"line_number":39,"context_line":"        LOG.error(_(\"Network driver option required, but not specified\"))"},{"line_number":40,"context_line":"        sys.exit(1)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    LOG.info(_(\"Loading network driver \u0027%s\u0027\") % CONF.network_driver)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F2pw%3D","line":40,"updated":"2012-12-12 15:08:31.000000000","message":"Hrm, this causes an exit(1) in the middle of whatever does load_driver, i.e. nova-network, right? Wouldn\u0027t it be better to raise ImportError here or something? My mama always taught me not to call exit() from a library(-ish thing) :)","commit_id":"311dab9ae30da484d8586a74cc590e350b07538c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0ce7a7080e63872f1881da1f8e3bc0d88c112631","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if not network_driver:"},{"line_number":39,"context_line":"        LOG.error(_(\"Network driver option required, but not specified\"))"},{"line_number":40,"context_line":"        sys.exit(1)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    LOG.info(_(\"Loading network driver \u0027%s\u0027\") % CONF.network_driver)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F1U4%3D","line":40,"in_reply_to":"AAAAMX%2F%2F1pQ%3D","updated":"2012-12-13 14:31:13.000000000","message":"Sorry, I guess I didn\u0027t realize you were asking. So, I see that load_compute_driver does the same thing, as you indicate. I guess that justifies the repeat offense, but man, it sure seems smelly :(","commit_id":"311dab9ae30da484d8586a74cc590e350b07538c"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"f804cf31428488e81b95da8be865ea2c070c2609","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if not network_driver:"},{"line_number":39,"context_line":"        LOG.error(_(\"Network driver option required, but not specified\"))"},{"line_number":40,"context_line":"        sys.exit(1)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    LOG.info(_(\"Loading network driver \u0027%s\u0027\") % CONF.network_driver)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F1pQ%3D","line":40,"in_reply_to":"AAAAMX%2F%2F2oI%3D","updated":"2012-12-13 07:00:52.000000000","message":"Ok with copying the load_compute_driver() behaviour?","commit_id":"311dab9ae30da484d8586a74cc590e350b07538c"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"c0d1a68d059b394b746752e54679f489fea68827","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if not network_driver:"},{"line_number":39,"context_line":"        LOG.error(_(\"Network driver option required, but not specified\"))"},{"line_number":40,"context_line":"        sys.exit(1)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    LOG.info(_(\"Loading network driver \u0027%s\u0027\") % CONF.network_driver)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F2oI%3D","line":40,"in_reply_to":"AAAAMX%2F%2F2pw%3D","updated":"2012-12-12 15:20:23.000000000","message":"Yeah, fair. And it\u0027s new behaviour. Basically I was just copying load_compute_driver()","commit_id":"311dab9ae30da484d8586a74cc590e350b07538c"}]}