)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e922b61da4ddac70b3a1de17cd55103b0697af4","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Sadly, the test that covers this was pretty wrong on multiple fronts,"},{"line_number":12,"context_line":"which this patch fixes up."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id515137747a4b76e9b7057c95f80c8ae74017519"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_3b3b82d3","line":13,"updated":"2015-04-30 20:30:27.000000000","message":"jlk needs to report a bug for this for backports","commit_id":"f6f2b534e986503ee3a3ab8f9fd000e6ea81ae17"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1cbe5b2f508e50779ec74bbcd2b2f72e3de26f88","unresolved":false,"context_lines":[{"line_number":712,"context_line":"            if CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027:"},{"line_number":713,"context_line":"                self._teardown_container(instance)"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    def destroy(self, context, instance, network_info, block_device_info\u003dNone,"},{"line_number":716,"context_line":"                destroy_disks\u003dTrue, migrate_data\u003dNone):"},{"line_number":717,"context_line":"        self._destroy(instance)"},{"line_number":718,"context_line":"        self.cleanup(context, instance, network_info, block_device_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_caddf714","line":715,"range":{"start_line":715,"start_character":8,"end_line":715,"end_character":15},"updated":"2018-08-22 13:58:10.000000000","message":"Hmm, compute manager revert_resize does call this method, which calls cleanup which unplugs vifs on the dest host.","commit_id":"4814e9126ec19a1edfa9c696138c4b3fec71aa0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1cbe5b2f508e50779ec74bbcd2b2f72e3de26f88","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def cleanup(self, context, instance, network_info, block_device_info\u003dNone,"},{"line_number":753,"context_line":"                destroy_disks\u003dTrue, migrate_data\u003dNone, destroy_vifs\u003dTrue):"},{"line_number":754,"context_line":"        if destroy_vifs:"},{"line_number":755,"context_line":"            self._unplug_vifs(instance, network_info, True)"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        retry \u003d True"},{"line_number":758,"context_line":"        while retry:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8ae37fd8","line":755,"range":{"start_line":754,"start_character":8,"end_line":755,"end_character":59},"updated":"2018-08-22 13:58:10.000000000","message":"We\u0027d unplug here on the dest host.","commit_id":"4814e9126ec19a1edfa9c696138c4b3fec71aa0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"63df37ffcb5f0856ed81022d7c16d72b1e597685","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                          attempts\u003d5)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        if instance.host !\u003d CONF.host:"},{"line_number":975,"context_line":"            self._undefine_domain(instance)"},{"line_number":976,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":977,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":978,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_bbd31238","line":975,"updated":"2015-04-30 20:42:18.000000000","message":"OK, yeah we only unplug VIFs if the host has changed on resize and we confirmed the resize (which calls this method), we don\u0027t unplug on revert anywhere (or before revert/confirm happens).","commit_id":"4814e9126ec19a1edfa9c696138c4b3fec71aa0d"}]}