)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d268c18efe2c36dc388fe1b0d391bd8cf3f599f5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"non-admins, as the filter option is silently discarded. There is no"},{"line_number":11,"context_line":"reason to treat ip6 different from ip, though, so we just add this"},{"line_number":12,"context_line":"option to the allowed list."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: 1450859"},{"line_number":15,"context_line":"Change-Id: I26a0b576636bd7e6b4dd7d53ded05907397d2f26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_4c865114","line":13,"updated":"2015-05-04 15:16:57.000000000","message":"need to say DocImpact I think","commit_id":"8754ade9809b727b2a2ca6ae68ae5bbcfe099fe5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ab030c024b4ef35f44e2000b83428d8093d21d1f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Docs for python-novaclient already show \"--ip6\" as a non-admin command,"},{"line_number":15,"context_line":"still adding ApiImpact and DocImpact tags just in case."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"APIImpact: Filtering by ip6 will now be allow for non-admin"},{"line_number":18,"context_line":"DocImpact: Filtering by ip6 will now be allow for non-admin"},{"line_number":19,"context_line":"Closes-Bug: 1450859"},{"line_number":20,"context_line":"Change-Id: I26a0b576636bd7e6b4dd7d53ded05907397d2f26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_32515463","line":17,"updated":"2015-05-16 23:11:28.000000000","message":"here and below, s/allow/allowed/ if you respin this...","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"703c0845e360deed1f3260acb49b9d33493a0476","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Docs for python-novaclient already show \"--ip6\" as a non-admin command,"},{"line_number":15,"context_line":"still adding ApiImpact and DocImpact tags just in case."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"APIImpact: Filtering by ip6 will now be allow for non-admin"},{"line_number":18,"context_line":"DocImpact: Filtering by ip6 will now be allow for non-admin"},{"line_number":19,"context_line":"Closes-Bug: 1450859"},{"line_number":20,"context_line":"Change-Id: I26a0b576636bd7e6b4dd7d53ded05907397d2f26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_b1aac517","line":17,"in_reply_to":"7a016987_32515463","updated":"2015-05-28 15:22:29.000000000","message":"Done","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"518a0918c9d617b8c8f75ccd4841c7397216bb6e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact: Filtering by ip6 will now be allowed for non-admin"},{"line_number":15,"context_line":"DocImpact: Filtering by ip6 will now be allowed for non-admin"},{"line_number":16,"context_line":"Closes-Bug: 1450859"},{"line_number":17,"context_line":"Change-Id: I26a0b576636bd7e6b4dd7d53ded05907397d2f26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3afb71cf_27b9742f","line":16,"updated":"2015-06-04 19:15:17.000000000","message":"Yeah please add the blueprint tag in here:\n\nImplements blueprint allow-ip6-search-for-non-admin\n\nThen it will link into the blueprint whiteboard in launchpad.","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"36fe89a0abe9a05fd1bba347b188db4bd397fdfe","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact: Filtering by ip6 will now be allowed for non-admin"},{"line_number":15,"context_line":"DocImpact: Filtering by ip6 will now be allowed for non-admin"},{"line_number":16,"context_line":"Closes-Bug: 1450859"},{"line_number":17,"context_line":"Change-Id: I26a0b576636bd7e6b4dd7d53ded05907397d2f26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3afb71cf_d23eb5b7","line":16,"in_reply_to":"3afb71cf_27b9742f","updated":"2015-06-05 17:19:45.000000000","message":"Done","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fd1cf48d4e006702c3068bdf6b34e066187cbdf7","unresolved":false,"context_lines":[{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"def remove_invalid_options(context, search_options, allowed_search_options):"},{"line_number":1148,"context_line":"    \"\"\"Remove search options that are not valid for non-admin API/context.\"\"\""},{"line_number":1149,"context_line":"    if context.is_admin:"},{"line_number":1150,"context_line":"        # Allow all options"},{"line_number":1151,"context_line":"        return"},{"line_number":1152,"context_line":"    # Otherwise, strip out all unknown options"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_e3228c53","line":1149,"range":{"start_line":1149,"start_character":15,"end_line":1149,"end_character":16},"updated":"2015-05-29 11:51:49.000000000","message":"So this is a but too really, given how we are revising how policy works, but lets ignore that for now.","commit_id":"af618cdfc8a1190520b3cf9ebfe890a37e34fc96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"518a0918c9d617b8c8f75ccd4841c7397216bb6e","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        opt_list \u003d (\u0027reservation_id\u0027, \u0027name\u0027, \u0027status\u0027, \u0027image\u0027, \u0027flavor\u0027,"},{"line_number":1145,"context_line":"                \u0027ip\u0027, \u0027changes-since\u0027, \u0027all_tenants\u0027)"},{"line_number":1146,"context_line":"        req_ver \u003d req.api_version_request"},{"line_number":1147,"context_line":"        if req_ver and req_ver \u003e api_version_request.APIVersionRequest(\"2.3\"):"},{"line_number":1148,"context_line":"            opt_list +\u003d (\u0027ip6\u0027,)"},{"line_number":1149,"context_line":"        return opt_list"},{"line_number":1150,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3afb71cf_07e43839","line":1147,"updated":"2015-06-04 19:15:17.000000000","message":"This isn\u0027t used here. this is the v2 API extension and microversions aren\u0027t used in the v2 API code path, only the compute/plugins/v3/ code path, so this module shouldn\u0027t be touched at all.","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"88417f887d72494633234620abdad44f13a44831","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        opt_list \u003d (\u0027reservation_id\u0027, \u0027name\u0027, \u0027status\u0027, \u0027image\u0027, \u0027flavor\u0027,"},{"line_number":1145,"context_line":"                \u0027ip\u0027, \u0027changes-since\u0027, \u0027all_tenants\u0027)"},{"line_number":1146,"context_line":"        req_ver \u003d req.api_version_request"},{"line_number":1147,"context_line":"        if req_ver and req_ver \u003e api_version_request.APIVersionRequest(\"2.3\"):"},{"line_number":1148,"context_line":"            opt_list +\u003d (\u0027ip6\u0027,)"},{"line_number":1149,"context_line":"        return opt_list"},{"line_number":1150,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3afb71cf_96c83f76","line":1147,"in_reply_to":"3afb71cf_07e43839","updated":"2015-06-05 12:04:19.000000000","message":"Right, Matt is spot-on about that. This needs to be in the v3/servers.py file...","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"36fe89a0abe9a05fd1bba347b188db4bd397fdfe","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        opt_list \u003d (\u0027reservation_id\u0027, \u0027name\u0027, \u0027status\u0027, \u0027image\u0027, \u0027flavor\u0027,"},{"line_number":1145,"context_line":"                \u0027ip\u0027, \u0027changes-since\u0027, \u0027all_tenants\u0027)"},{"line_number":1146,"context_line":"        req_ver \u003d req.api_version_request"},{"line_number":1147,"context_line":"        if req_ver and req_ver \u003e api_version_request.APIVersionRequest(\"2.3\"):"},{"line_number":1148,"context_line":"            opt_list +\u003d (\u0027ip6\u0027,)"},{"line_number":1149,"context_line":"        return opt_list"},{"line_number":1150,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3afb71cf_7274a19b","line":1147,"in_reply_to":"3afb71cf_96c83f76","updated":"2015-06-05 17:19:45.000000000","message":"Done","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"}],"nova/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"88417f887d72494633234620abdad44f13a44831","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Allow server search option ip6 for non-admin"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  Currently the command \"nova list --ip6 xxx\" will return all servers for"},{"line_number":55,"context_line":"  non-admins, as the filter option is silently discarded. There is no"},{"line_number":56,"context_line":"  reason to treat ip6 different from ip, though, so we just add this"},{"line_number":57,"context_line":"  option to the allowed list."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afb71cf_16820f01","line":54,"updated":"2015-06-05 12:04:19.000000000","message":"s/Currently the command/Before version 2.4, the command/","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"36fe89a0abe9a05fd1bba347b188db4bd397fdfe","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Allow server search option ip6 for non-admin"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  Currently the command \"nova list --ip6 xxx\" will return all servers for"},{"line_number":55,"context_line":"  non-admins, as the filter option is silently discarded. There is no"},{"line_number":56,"context_line":"  reason to treat ip6 different from ip, though, so we just add this"},{"line_number":57,"context_line":"  option to the allowed list."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afb71cf_925f1d0e","line":54,"in_reply_to":"3afb71cf_16820f01","updated":"2015-06-05 17:19:45.000000000","message":"Missed this one, noted for the next iteration.","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"81223a492af316e7b1c717bd5dfe9bd98a888b80","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  service. It exposes necessary properties absent in public nova APIs yet."},{"line_number":51,"context_line":"  Add info for Standalone EC2 API to cut access to Nova DB."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"2.4"},{"line_number":54,"context_line":"---"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  Show the \u0027reserved\u0027 status on a FixedIP object in the os-fixed-ips API"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3afb71cf_482ec6a5","line":53,"updated":"2015-06-11 12:51:45.000000000","message":"Don\u0027t change this, this will be fixed in https://review.openstack.org/#/c/190549/ and just cause a merge conflict.","commit_id":"180e4c17129ae635556bc420b06dfb14766f9ebe"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7848e725f281b7ecf3d0abff90cee98a849da761","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  service. It exposes necessary properties absent in public nova APIs yet."},{"line_number":51,"context_line":"  Add info for Standalone EC2 API to cut access to Nova DB."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"2.4"},{"line_number":54,"context_line":"---"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  Show the \u0027reserved\u0027 status on a FixedIP object in the os-fixed-ips API"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3afb71cf_59d7afbf","line":53,"in_reply_to":"3afb71cf_482ec6a5","updated":"2015-06-11 16:10:11.000000000","message":"Yes, you are right, I\u0027ll fix this once the spec is approved. But I\u0027m also assuming there will be a merge conflict anyway because the changes are too close, so probably I should just rebase on top of your thing, then.","commit_id":"180e4c17129ae635556bc420b06dfb14766f9ebe"}],"nova/tests/unit/api/openstack/compute/plugins/v3/test_servers.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d607838800eba9d033916830223d12b519c0fbd3","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"    def test_get_servers_allows_ip6(self):"},{"line_number":1220,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1221,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1222,"context_line":""},{"line_number":1223,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_d29680ef","line":1220,"updated":"2015-05-16 23:10:27.000000000","message":"if you respin please remove the extra space","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"703c0845e360deed1f3260acb49b9d33493a0476","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"    def test_get_servers_allows_ip6(self):"},{"line_number":1220,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1221,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1222,"context_line":""},{"line_number":1223,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_f1f95dc9","line":1220,"in_reply_to":"7a016987_9601ff08","updated":"2015-05-28 15:22:29.000000000","message":"Done","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce5566f2f86227e37bce7ceda22ceb55de7cfd60","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"    def test_get_servers_allows_ip6(self):"},{"line_number":1220,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1221,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1222,"context_line":""},{"line_number":1223,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_9601ff08","line":1220,"in_reply_to":"7a016987_d29680ef","updated":"2015-05-28 15:06:00.000000000","message":"As Jay pointed out, this is a redundant docstring so you could/should just remove it.","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b071fe9fe3f7312be63bc3cad9ae81ef7fb91bc0","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        self.stubs.Set(compute_api.API, \u0027get_all\u0027, fake_get_all)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/servers?ip6\u003dffff.*\u0027)"},{"line_number":1265,"context_line":"        req.headers \u003d {\u0027X-OpenStack-Nova-API-Version\u0027: \u00272.5\u0027}"},{"line_number":1266,"context_line":"        req.api_version_request \u003d api_version_request.APIVersionRequest(\u00272.5\u0027)"},{"line_number":1267,"context_line":"        servers \u003d self.controller.index(req)[\u0027servers\u0027]"},{"line_number":1268,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa32b979_927388b4","line":1265,"updated":"2015-06-19 22:05:46.000000000","message":"this is not needed? you call the index function directly","commit_id":"3dc22272d0975b5c58cee54e44cfbc162251c513"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76e1532ec9ab7ad33c5be78ae0426924f2f36a4c","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        self.stubs.Set(compute_api.API, \u0027get_all\u0027, fake_get_all)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/servers?ip6\u003dffff.*\u0027)"},{"line_number":1265,"context_line":"        req.headers \u003d {\u0027X-OpenStack-Nova-API-Version\u0027: \u00272.5\u0027}"},{"line_number":1266,"context_line":"        req.api_version_request \u003d api_version_request.APIVersionRequest(\u00272.5\u0027)"},{"line_number":1267,"context_line":"        servers \u003d self.controller.index(req)[\u0027servers\u0027]"},{"line_number":1268,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa32b979_c70937df","line":1265,"in_reply_to":"fa32b979_927388b4","updated":"2015-06-22 08:35:14.000000000","message":"Done","commit_id":"3dc22272d0975b5c58cee54e44cfbc162251c513"}],"nova/tests/unit/api/openstack/compute/test_servers.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ab030c024b4ef35f44e2000b83428d8093d21d1f","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        self.assertEqual(len(servers), 1)"},{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_32ff1436","line":1269,"updated":"2015-05-16 23:11:28.000000000","message":"There\u0027s two underscores in the above test method.... :)","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"703c0845e360deed1f3260acb49b9d33493a0476","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        self.assertEqual(len(servers), 1)"},{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_115bd9f7","line":1269,"in_reply_to":"7a016987_32ff1436","updated":"2015-05-28 15:22:29.000000000","message":"Done","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce5566f2f86227e37bce7ceda22ceb55de7cfd60","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        self.assertEqual(len(servers), 1)"},{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_110cf939","line":1269,"in_reply_to":"7a016987_32ff1436","updated":"2015-05-28 15:06:00.000000000","message":"Yeah please fix this.","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ab030c024b4ef35f44e2000b83428d8093d21d1f","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_f2f85c4b","line":1270,"updated":"2015-05-16 23:11:28.000000000","message":"You can actually remove the docstring, as it\u0027s redundant with the test method name.","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d607838800eba9d033916830223d12b519c0fbd3","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_b299c421","line":1270,"updated":"2015-05-16 23:10:27.000000000","message":"ditto","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce5566f2f86227e37bce7ceda22ceb55de7cfd60","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_b11d2568","line":1270,"in_reply_to":"7a016987_f2f85c4b","updated":"2015-05-28 15:06:00.000000000","message":"+1","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"703c0845e360deed1f3260acb49b9d33493a0476","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def test_get_servers__allows_ip6(self):"},{"line_number":1270,"context_line":"        \"\"\"Test getting servers by ip6. \"\"\""},{"line_number":1271,"context_line":"        server_uuid \u003d str(uuid.uuid4())"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        def fake_get_all(compute_self, context, search_opts\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_513a7199","line":1270,"in_reply_to":"7a016987_f2f85c4b","updated":"2015-05-28 15:22:29.000000000","message":"Done","commit_id":"dc2350f85d0dbc48086271be5ee5f43941501501"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"88417f887d72494633234620abdad44f13a44831","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        servers \u003d self.controller.index(req)[\u0027servers\u0027]"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        self.assertEqual(len(servers), 1)"},{"line_number":1321,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    def test_get_all_server_details(self):"},{"line_number":1324,"context_line":"        expected_flavor \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afb71cf_1699ef6e","line":1321,"updated":"2015-06-05 12:04:19.000000000","message":"Please move this test of the new microversion into the v3 test only...","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"36fe89a0abe9a05fd1bba347b188db4bd397fdfe","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        servers \u003d self.controller.index(req)[\u0027servers\u0027]"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        self.assertEqual(len(servers), 1)"},{"line_number":1321,"context_line":"        self.assertEqual(servers[0][\u0027id\u0027], server_uuid)"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    def test_get_all_server_details(self):"},{"line_number":1324,"context_line":"        expected_flavor \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afb71cf_12aa0dd5","line":1321,"in_reply_to":"3afb71cf_1699ef6e","updated":"2015-06-05 17:19:45.000000000","message":"Done","commit_id":"be21cb88bf0fb057ff44f1f024b18e3856c24c46"}]}