)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"cb20666e01bf461b87dedb5879344a76da0fc640","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":"        values \u003d {\u0027host\u0027: self.host, \u0027node\u0027: self.nodename,"},{"line_number":220,"context_line":"                  \u0027launched_on\u0027: self.host}"},{"line_number":221,"context_line":"        self.conductor_api.instance_update(context, instance_ref.uuid,"},{"line_number":222,"context_line":"                                           **values)"},{"line_number":223,"context_line":"        instance_ref.host \u003d self.host"},{"line_number":224,"context_line":"        instance_ref.launched_on \u003d self.host"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_2f1f9960","line":221,"updated":"2015-05-03 17:34:36.000000000","message":"How about we replace this conductor call with a instance_ref.save()?","commit_id":"3799fae27d8bb3406e46c029f092f71f4ce30ab1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"55732c5e4117fd0b5ea5037d3d0b1d8c57d4c461","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":"        values \u003d {\u0027host\u0027: self.host, \u0027node\u0027: self.nodename,"},{"line_number":220,"context_line":"                  \u0027launched_on\u0027: self.host}"},{"line_number":221,"context_line":"        self.conductor_api.instance_update(context, instance_ref.uuid,"},{"line_number":222,"context_line":"                                           **values)"},{"line_number":223,"context_line":"        instance_ref.host \u003d self.host"},{"line_number":224,"context_line":"        instance_ref.launched_on \u003d self.host"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_41717adf","line":221,"in_reply_to":"3acd31a7_2f1f9960","updated":"2015-05-04 15:05:14.000000000","message":"Yeah, definitely","commit_id":"3799fae27d8bb3406e46c029f092f71f4ce30ab1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"037b5aeca330987d6ce886a266cf1abc7ad57e61","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":"        values \u003d {\u0027host\u0027: self.host, \u0027node\u0027: self.nodename,"},{"line_number":220,"context_line":"                  \u0027launched_on\u0027: self.host}"},{"line_number":221,"context_line":"        self.conductor_api.instance_update(context, instance_ref.uuid,"},{"line_number":222,"context_line":"                                           **values)"},{"line_number":223,"context_line":"        instance_ref.host \u003d self.host"},{"line_number":224,"context_line":"        instance_ref.launched_on \u003d self.host"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_7a3e468d","line":221,"in_reply_to":"3acd31a7_2f1f9960","updated":"2015-05-05 06:34:31.000000000","message":"good catch!","commit_id":"3799fae27d8bb3406e46c029f092f71f4ce30ab1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"605ff780c5d094281bd32fe43edfacf8e53ba78c","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param context: security context"},{"line_number":101,"context_line":"        :param instance_ref: instance to reserve resources for."},{"line_number":102,"context_line":"                             nova.objects.instance.Instance object"},{"line_number":103,"context_line":"        :param limits: Dict of oversubscription limits for memory, disk,"},{"line_number":104,"context_line":"                       and CPUs."},{"line_number":105,"context_line":"        :returns: A Claim ticket representing the reserved resources.  It can"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_360da8e8","line":102,"updated":"2015-05-19 00:49:30.000000000","message":"minor nit, I just think you only need to add a :type: docstring for this","commit_id":"aa4842914d8b50e9771ab2117c79de0910310225"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"69a4b6a1e6bca86adc06089ceada86aa52232120","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param context: security context"},{"line_number":101,"context_line":"        :param instance_ref: instance to reserve resources for."},{"line_number":102,"context_line":"                             nova.objects.instance.Instance object"},{"line_number":103,"context_line":"        :param limits: Dict of oversubscription limits for memory, disk,"},{"line_number":104,"context_line":"                       and CPUs."},{"line_number":105,"context_line":"        :returns: A Claim ticket representing the reserved resources.  It can"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_59e4d7df","line":102,"in_reply_to":"7a016987_360da8e8","updated":"2015-05-19 02:30:52.000000000","message":"Done","commit_id":"aa4842914d8b50e9771ab2117c79de0910310225"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"445219866e90e65069ce0aac06a7cf34cdc5ef82","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":35,"context_line":"from nova.compute import vm_states"},{"line_number":36,"context_line":"from nova.conductor import api as conductor_api"},{"line_number":37,"context_line":"from nova.conductor import rpcapi as conductor_rpcapi"},{"line_number":38,"context_line":"from nova import context"},{"line_number":39,"context_line":"from nova import db"},{"line_number":40,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_32cef45a","side":"PARENT","line":37,"updated":"2015-05-16 22:32:01.000000000","message":"Nothing was changed about the conductor RPC API calls in this patch... so I\u0027m skeptical why any of these changes were made.","commit_id":"97296ec125794124620bb1f7a7c23eef9f64e442"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3c3f7d985da88126db642a3f87a5002c1b55cfd5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":35,"context_line":"from nova.compute import vm_states"},{"line_number":36,"context_line":"from nova.conductor import api as conductor_api"},{"line_number":37,"context_line":"from nova.conductor import rpcapi as conductor_rpcapi"},{"line_number":38,"context_line":"from nova import context"},{"line_number":39,"context_line":"from nova import db"},{"line_number":40,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_926ec8ff","side":"PARENT","line":37,"in_reply_to":"7a016987_32cef45a","updated":"2015-05-16 23:15:56.000000000","message":"Jay this is a bad on my behalf - in one of the previous patch sets I was requested to remove the conductor interface and use instance.save. It appears that a parallel patch for that has landed. I will fix.\nThis eternal rebasing is a real challenge","commit_id":"97296ec125794124620bb1f7a7c23eef9f64e442"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e99de01301e73bedf4e50b4ac5c879e7c5d0fe54","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        self.stubs.Set(db, \u0027instance_extra_get_by_instance_uuid\u0027,"},{"line_number":225,"context_line":"                       self._fake_instance_extra_get_by_instance_uuid)"},{"line_number":226,"context_line":"        self.stubs.Set(objects.Instance, \u0027save\u0027,"},{"line_number":227,"context_line":"                       lambda *args, **kwargs: None)"},{"line_number":228,"context_line":"        self.stubs.Set(self.conductor.db,"},{"line_number":229,"context_line":"                       \u0027flavor_get\u0027, self._fake_flavor_get)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_81eb10b0","line":227,"updated":"2015-05-17 17:23:36.000000000","message":"This line should have been in a different patch, right? I don\u0027t see this patch touching the Instance.save() or conductor.db.instance_update_and_get_original() code paths?","commit_id":"aa4842914d8b50e9771ab2117c79de0910310225"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"605ff780c5d094281bd32fe43edfacf8e53ba78c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        self.stubs.Set(db, \u0027instance_extra_get_by_instance_uuid\u0027,"},{"line_number":225,"context_line":"                       self._fake_instance_extra_get_by_instance_uuid)"},{"line_number":226,"context_line":"        self.stubs.Set(objects.Instance, \u0027save\u0027,"},{"line_number":227,"context_line":"                       lambda *args, **kwargs: None)"},{"line_number":228,"context_line":"        self.stubs.Set(self.conductor.db,"},{"line_number":229,"context_line":"                       \u0027flavor_get\u0027, self._fake_flavor_get)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_568f042a","line":227,"in_reply_to":"7a016987_81eb10b0","updated":"2015-05-19 00:49:30.000000000","message":"Agreed with Jay, that comes from https://review.openstack.org/#/c/182766/ which forgot to update that.\n\nCould you please provide a separate change ?","commit_id":"aa4842914d8b50e9771ab2117c79de0910310225"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"69a4b6a1e6bca86adc06089ceada86aa52232120","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        self.stubs.Set(db, \u0027instance_extra_get_by_instance_uuid\u0027,"},{"line_number":225,"context_line":"                       self._fake_instance_extra_get_by_instance_uuid)"},{"line_number":226,"context_line":"        self.stubs.Set(objects.Instance, \u0027save\u0027,"},{"line_number":227,"context_line":"                       lambda *args, **kwargs: None)"},{"line_number":228,"context_line":"        self.stubs.Set(self.conductor.db,"},{"line_number":229,"context_line":"                       \u0027flavor_get\u0027, self._fake_flavor_get)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_39e59bdb","line":227,"in_reply_to":"7a016987_81eb10b0","updated":"2015-05-19 02:30:52.000000000","message":"Yes, this was left over for the conductor part.","commit_id":"aa4842914d8b50e9771ab2117c79de0910310225"}],"nova/tests/unit/compute/test_tracker.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e99de01301e73bedf4e50b4ac5c879e7c5d0fe54","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                    self.rt.instance_claim,"},{"line_number":1108,"context_line":"                    self.ctx, self.instance, bad_limits)"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":"    @mock.patch(\u0027nova.objects.Instance.save\u0027)"},{"line_number":1111,"context_line":"    @mock.patch(\u0027nova.objects.InstancePCIRequests.get_by_instance_uuid\u0027)"},{"line_number":1112,"context_line":"    @mock.patch(\u0027nova.objects.MigrationList.get_in_progress_by_host_and_node\u0027)"},{"line_number":1113,"context_line":"    def test_claim_numa(self, migr_mock, pci_mock, mock_instance_save):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_61d37405","line":1110,"updated":"2015-05-17 17:23:36.000000000","message":"Same comment for these changes... I would have thought these would have been in a different patch?","commit_id":"aa4842914d8b50e9771ab2117c79de0910310225"}]}