)]}'
{"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b0efd4e542e23f419418e11c2196f3df32f75f63","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"        params \u003d {\"memory_mb\": 999999999999}"},{"line_number":1401,"context_line":"        filter_properties \u003d {\u0027limits\u0027: {\u0027memory_mb\u0027: None}}"},{"line_number":1402,"context_line":"        instance \u003d self._create_fake_instance_obj(params)"},{"line_number":1403,"context_line":"        LOG.error(\u0027spawn is %s\u0027 % utils.spawn_n)"},{"line_number":1404,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {},"},{"line_number":1405,"context_line":"                                            filter_properties,"},{"line_number":1406,"context_line":"                                            block_device_mapping\u003d[])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_419865c0","line":1403,"updated":"2015-05-08 07:55:10.000000000","message":"Probably shouldn\u0027t be here","commit_id":"94b7e0b7e5ce9bc64fee960d600764f42ace0f96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8f91040770372b4a5c4e0776e3ad5529ba4bccf5","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"        params \u003d {\"memory_mb\": 999999999999}"},{"line_number":1401,"context_line":"        filter_properties \u003d {\u0027limits\u0027: {\u0027memory_mb\u0027: None}}"},{"line_number":1402,"context_line":"        instance \u003d self._create_fake_instance_obj(params)"},{"line_number":1403,"context_line":"        LOG.error(\u0027spawn is %s\u0027 % utils.spawn_n)"},{"line_number":1404,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {},"},{"line_number":1405,"context_line":"                                            filter_properties,"},{"line_number":1406,"context_line":"                                            block_device_mapping\u003d[])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_603c72e2","line":1403,"in_reply_to":"1aca2d91_419865c0","updated":"2015-05-08 14:04:14.000000000","message":"Oops, left-over debugging. Good eye :)","commit_id":"94b7e0b7e5ce9bc64fee960d600764f42ace0f96"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b884e87f7b9e8734b00d3eee93fd391704b20fde","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        self.flags(reserved_host_disk_mb\u003d0, reserved_host_memory_mb\u003d0)"},{"line_number":1399,"context_line":"        self.rt.update_available_resource(self.context.elevated())"},{"line_number":1400,"context_line":"        params \u003d {\"memory_mb\": 999999999999}"},{"line_number":1401,"context_line":"        filter_properties \u003d {\u0027limits\u0027: {\u0027memory_mb\u0027: None}}"},{"line_number":1402,"context_line":"        instance \u003d self._create_fake_instance_obj(params)"},{"line_number":1403,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {},"},{"line_number":1404,"context_line":"                                            filter_properties,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_69a576b3","line":1401,"updated":"2015-05-08 16:55:28.000000000","message":"Just a point to note: the limits being passed in filter_properties isn\u0027t used by the test.  build_and_run_instance takes a limits param which defaults to None which is what\u0027s actually used.  So the test is fine, but this may end up being confusing.\n\nfilter_properties would have a limits property though, it\u0027s just used by the scheduler rather than the compute.","commit_id":"735ab103a5fbaafa4e7753ded6d3b9093222ed18"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f6bed91625bd1ed9c0b4916f98a7a3b2452bc4d9","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        self.flags(reserved_host_disk_mb\u003d0, reserved_host_memory_mb\u003d0)"},{"line_number":1399,"context_line":"        self.rt.update_available_resource(self.context.elevated())"},{"line_number":1400,"context_line":"        params \u003d {\"memory_mb\": 999999999999}"},{"line_number":1401,"context_line":"        filter_properties \u003d {\u0027limits\u0027: {\u0027memory_mb\u0027: None}}"},{"line_number":1402,"context_line":"        instance \u003d self._create_fake_instance_obj(params)"},{"line_number":1403,"context_line":"        self.compute.build_and_run_instance(self.context, instance, {}, {},"},{"line_number":1404,"context_line":"                                            filter_properties,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_09604200","line":1401,"in_reply_to":"1aca2d91_69a576b3","updated":"2015-05-08 17:01:44.000000000","message":"Okay, I\u0027ll nix it if I rebase, if that\u0027s cool.","commit_id":"735ab103a5fbaafa4e7753ded6d3b9093222ed18"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b884e87f7b9e8734b00d3eee93fd391704b20fde","unresolved":false,"context_lines":[{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        filter_properties \u003d {\u0027limits\u0027: {\u0027memory_mb\u0027: oversub_limit_mb}}"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"        self.compute.build_and_run_instance(self.context, instance,"},{"line_number":1508,"context_line":"                          {}, {}, filter_properties, block_device_mapping\u003d[])"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"    def test_create_instance_with_oversubscribed_cpu(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_69e1f6cf","line":1507,"updated":"2015-05-08 16:55:28.000000000","message":"This test seems not very useful.  A caller wouldn\u0027t get an exception raised, but should expect the instance to be rescheduled.  But that is tested better in test_compute_mgr.\n\nReally that\u0027s true of a lot of these tests.  But that can be tackled separate to this change.","commit_id":"735ab103a5fbaafa4e7753ded6d3b9093222ed18"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f6bed91625bd1ed9c0b4916f98a7a3b2452bc4d9","unresolved":false,"context_lines":[{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":"        filter_properties \u003d {\u0027limits\u0027: {\u0027memory_mb\u0027: oversub_limit_mb}}"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"        self.compute.build_and_run_instance(self.context, instance,"},{"line_number":1508,"context_line":"                          {}, {}, filter_properties, block_device_mapping\u003d[])"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"    def test_create_instance_with_oversubscribed_cpu(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_092722cb","line":1507,"in_reply_to":"1aca2d91_69e1f6cf","updated":"2015-05-08 17:01:44.000000000","message":"Well, it\u0027s testing that it hits the proper abort, which is all that it was testing before given that run_instance() was a cast. I was just trying to preserve the coverage by making spawn pass-through.\n\nIf we have things we know are covered better in _mgr, then I\u0027m definitely on board with cleaning this up later. They\u0027re testing too much for each case anyway.","commit_id":"735ab103a5fbaafa4e7753ded6d3b9093222ed18"}]}