)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"53af193317b5c776768b9401e5aa475a3942bb55","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"# TODO(danms): Remove me after Icehouse"},{"line_number":457,"context_line":"def aggregate_object_compat(function):"},{"line_number":458,"context_line":"    \"\"\"Wraps a method that expects a new-world aggregate.\"\"\""},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    @functools.wraps(function)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_a12be781","line":457,"updated":"2015-05-07 09:42:54.000000000","message":"This decorator is no longer used","commit_id":"d09016158d983fcbb13820e70dab61d0064a9365"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"01e0a0226d49c2f2fdb45ec9c1227e99609f035c","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"# TODO(danms): Remove me after Icehouse"},{"line_number":457,"context_line":"def aggregate_object_compat(function):"},{"line_number":458,"context_line":"    \"\"\"Wraps a method that expects a new-world aggregate.\"\"\""},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    @functools.wraps(function)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_82cb3253","line":457,"in_reply_to":"1aca2d91_a12be781","updated":"2015-05-07 19:32:27.000000000","message":"Ah, yeah. Also, LOL @ \"remove me after ICEHOUSE\"","commit_id":"d09016158d983fcbb13820e70dab61d0064a9365"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"53af193317b5c776768b9401e5aa475a3942bb55","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            openstack_driver.is_neutron_security_groups())"},{"line_number":686,"context_line":"        self.consoleauth_rpcapi \u003d consoleauth.rpcapi.ConsoleAuthAPI()"},{"line_number":687,"context_line":"        self.cells_rpcapi \u003d cells_rpcapi.CellsAPI()"},{"line_number":688,"context_line":"        self.scheduler_rpcapi \u003d scheduler_rpcapi.SchedulerAPI()"},{"line_number":689,"context_line":"        self.scheduler_client \u003d scheduler_client.SchedulerClient()"},{"line_number":690,"context_line":"        self._resource_tracker_dict \u003d {}"},{"line_number":691,"context_line":"        self.instance_events \u003d InstanceEvents()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_e131dfed","line":688,"updated":"2015-05-07 09:42:54.000000000","message":"No need to keep self.scheduler_rpcapi anymore","commit_id":"d09016158d983fcbb13820e70dab61d0064a9365"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ff1f359f431a2254bc6bb604e47e6e5b988d8b6b","unresolved":false,"context_lines":[{"line_number":2523,"context_line":"                     filter_properties, requested_networks,"},{"line_number":2524,"context_line":"                     injected_files, admin_password,"},{"line_number":2525,"context_line":"                     is_first_time, node, legacy_bdm_in_spec):"},{"line_number":2526,"context_line":"        # NOTE(alaski) This method should be deprecated when the scheduler and"},{"line_number":2527,"context_line":"        # compute rpc interfaces are bumped to 4.x, and slated for removal in"},{"line_number":2528,"context_line":"        # 5.x as it is no longer used."},{"line_number":2529,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_c41eb162","side":"PARENT","line":2526,"updated":"2015-05-08 17:10:00.000000000","message":"Heck yeah!  Love to see this being removed.\n\nAnd to explain the 4.x/5.x comment.  When written we were bumping all RPC versions each release.  What the comment should have said is remove it on the next version bump after the scheduler was bumped.  So I was expecting compute/scheduler to go to 4.x and then this would be removed in 5.x but it didn\u0027t work out that way.","commit_id":"5309120d7954da0b5ea67b0baf7c8d7ca24b8480"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"53af193317b5c776768b9401e5aa475a3942bb55","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":299,"context_line":"        \u0027icehouse\u0027: \u00273.23\u0027,"},{"line_number":300,"context_line":"        \u0027juno\u0027: \u00273.35\u0027,"},{"line_number":301,"context_line":"        \u0027kilo\u0027: \u00273.40\u0027,"},{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_462669cf","line":300,"updated":"2015-05-07 09:42:54.000000000","message":"I think this is what causes grenade to fail. Grenade tests kilo -\u003e master right? The only common version supported by both is 4.0, but here we cap at 3.40.\n\nSee http://logs.openstack.org/51/179951/6/check/check-grenade-dsvm-partial-ncpu/d995330/logs/new/screen-n-api.txt.gz?level\u003dTRACE","commit_id":"d09016158d983fcbb13820e70dab61d0064a9365"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"01e0a0226d49c2f2fdb45ec9c1227e99609f035c","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":299,"context_line":"        \u0027icehouse\u0027: \u00273.23\u0027,"},{"line_number":300,"context_line":"        \u0027juno\u0027: \u00273.35\u0027,"},{"line_number":301,"context_line":"        \u0027kilo\u0027: \u00273.40\u0027,"},{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_8c0fe42d","line":300,"in_reply_to":"1aca2d91_462669cf","updated":"2015-05-07 19:32:27.000000000","message":"Grenade is failing for other reasons, but yeah, this too. Good catch.\n\nIn the past we have done this differently, but I think we can simplify it a lot. I\u0027m pushing up a new set now, changing this to 4.0 for Kilo, which should be correct. Please review aggressively :)","commit_id":"d09016158d983fcbb13820e70dab61d0064a9365"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"97d5e08e8a636995704604e8bd18036c7019ac50","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        return cctxt.call(ctxt, \u0027get_diagnostics\u0027, instance\u003dinstance)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def get_instance_diagnostics(self, ctxt, instance):"},{"line_number":464,"context_line":"        # TODO(danms): This needs to be fixed for objects"},{"line_number":465,"context_line":"        instance_p \u003d jsonutils.to_primitive(instance)"},{"line_number":466,"context_line":"        kwargs \u003d {\u0027instance\u0027: instance_p}"},{"line_number":467,"context_line":"        version \u003d \u00274.0\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_57b078dd","line":464,"updated":"2015-05-12 17:27:32.000000000","message":"I hate these are needed, but loving that you added them.","commit_id":"91b35b22e753a4eb0c22c004bb12586970a95e11"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"9ae57b6e72b67115bcc77ae6667375b8f2054b59","unresolved":false,"context_lines":[{"line_number":10856,"context_line":"                method_args, self.expected_task_state, exc_info\u003dexc_info)"},{"line_number":10857,"context_line":""},{"line_number":10858,"context_line":""},{"line_number":10859,"context_line":"class InnerTestingException(Exception):"},{"line_number":10860,"context_line":"    pass"},{"line_number":10861,"context_line":""},{"line_number":10862,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1aca2d91_1ef648d7","side":"PARENT","line":10859,"updated":"2015-05-08 07:32:43.000000000","message":"This can be removed too","commit_id":"ee9b5c18dd16b028f8d0ed4cfb2e6f76b410c90d"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"9ae57b6e72b67115bcc77ae6667375b8f2054b59","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    return newdict"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class FakeSchedulerAPI(object):"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def run_instance(self, ctxt, request_spec, admin_password,"},{"line_number":146,"context_line":"            injected_files, requested_networks, is_first_time,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aca2d91_be007402","line":143,"updated":"2015-05-08 07:32:43.000000000","message":"This fake is no longer used. In fact, none of the methods below even exists in the scheduler anymore :)","commit_id":"37ede2c94fbf4369fdcd8e4008718bb0cab55d93"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"df887b8846a5b1a8df7ed7dfc97cb3025afac05c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.assertEqual(rpcapi.client.target.topic, CONF.compute_topic)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        orig_prepare \u003d rpcapi.client.prepare"},{"line_number":63,"context_line":"        # TODO(danms): Remove this special case when we drop 3.x"},{"line_number":64,"context_line":"        if CONF.upgrade_levels.compute \u003d\u003d \u00273.40\u0027:"},{"line_number":65,"context_line":"            base_version \u003d \u00273.0\u0027"},{"line_number":66,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9af37de9_a9b411d1","line":63,"updated":"2015-05-10 15:26:50.000000000","message":"Emm...this can be removed, but can be removed later.","commit_id":"41edd5938bc4d610744f123e10194a072f2dcb51"}]}