)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"be6c3faf9ebb61b194965ea81ca9bc8ec302cf8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use oslo-config-generator instead of generate_sample.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Oslo team is actively getting rid of the old style generator.py"},{"line_number":10,"context_line":"in openstack/common/config. So we should switch to the newer"},{"line_number":11,"context_line":"oslo-config-generator which is the way forward. For simplicity\u0027s"},{"line_number":12,"context_line":"sake, i used one single list_opts in opts.py. However we can"},{"line_number":13,"context_line":"split this up and add entrypoints in setup.cfg if we decide to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa32b979_328cc734","line":10,"updated":"2015-06-16 07:50:55.000000000","message":"What was wrong with the old one?\n\nI am still not a fan of the giant opts.py file.","commit_id":"c24cda59c33ae628a2cff5deac32ea974e54cd73"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"db6c0491c99205867a0bf30bf4bd25877ef58fad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use oslo-config-generator instead of generate_sample.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Oslo team is actively getting rid of the old style generator.py"},{"line_number":10,"context_line":"in openstack/common/config. So we should switch to the newer"},{"line_number":11,"context_line":"oslo-config-generator which is the way forward. For simplicity\u0027s"},{"line_number":12,"context_line":"sake, i used one single list_opts in opts.py. However we can"},{"line_number":13,"context_line":"split this up and add entrypoints in setup.cfg if we decide to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa32b979_d038e8a2","line":10,"in_reply_to":"fa32b979_328cc734","updated":"2015-06-16 12:12:13.000000000","message":"the old generator.py is gone from oslo-incubator. This *IS* the new way going forward.","commit_id":"c24cda59c33ae628a2cff5deac32ea974e54cd73"}],"etc/nova/nova-config-generator.conf":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2a719d7cf4b8e523e89aa4df216d681b54bcfba5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/nova/nova.conf.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":"namespace \u003d nova"},{"line_number":5,"context_line":"namespace \u003d nova.openstack.common.eventlet_backdoor"},{"line_number":6,"context_line":"namespace \u003d nova.openstack.common.memorycache"},{"line_number":7,"context_line":"namespace \u003d nova.openstack.common.periodic_task"},{"line_number":8,"context_line":"namespace \u003d nova.openstack.common.policy"}],"source_content_type":"text/plain","patch_set":7,"id":"1aca2d91_d2678ae7","line":5,"updated":"2015-05-08 20:26:42.000000000","message":"If we have the nova namespace already, why is this needed?","commit_id":"da174d848256ec437b5194d46c23c9a6a70fe7f0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2d59e4175a675913c6226d4488f2ca3dd8abfc98","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/nova/nova.conf.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":"namespace \u003d nova"},{"line_number":5,"context_line":"namespace \u003d nova.openstack.common.eventlet_backdoor"},{"line_number":6,"context_line":"namespace \u003d nova.openstack.common.memorycache"},{"line_number":7,"context_line":"namespace \u003d nova.openstack.common.periodic_task"},{"line_number":8,"context_line":"namespace \u003d nova.openstack.common.policy"}],"source_content_type":"text/plain","patch_set":7,"id":"1aca2d91_dda2fb98","line":5,"in_reply_to":"1aca2d91_d2678ae7","updated":"2015-05-08 21:17:29.000000000","message":"\"namespace\" is the entrypoint name - http://docs.openstack.org/developer/oslo.config/generator.html#defining-option-discovery-entry-points","commit_id":"da174d848256ec437b5194d46c23c9a6a70fe7f0"}],"nova/opts.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d4afd2e5840eec9f46f260604c13241fe9554de1","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def list_opts():"},{"line_number":164,"context_line":"    return ["},{"line_number":165,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":166,"context_line":"         itertools.chain("},{"line_number":167,"context_line":"             [nova.api.metadata.vendordata_json.file_opt],"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_b977c5d3","line":164,"updated":"2015-05-06 12:23:50.000000000","message":"This feels extremely error prone, when you add new options. There were some bugs raised in other projects during RC where they were missing options in the config.\n\nIs there not a better way to automatically generate this list, ideally that we can import from oslo?\n\nMaybe we should bring back the test that checks the output of the default config? Even if its only to change a sha hash of the default config, so you know when its changed?","commit_id":"da174d848256ec437b5194d46c23c9a6a70fe7f0"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2a719d7cf4b8e523e89aa4df216d681b54bcfba5","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def list_opts():"},{"line_number":164,"context_line":"    return ["},{"line_number":165,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":166,"context_line":"         itertools.chain("},{"line_number":167,"context_line":"             [nova.api.metadata.vendordata_json.file_opt],"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_327a3e78","line":164,"in_reply_to":"1aca2d91_1f79f993","updated":"2015-05-08 20:26:42.000000000","message":"yeah this file seems really error prone.","commit_id":"da174d848256ec437b5194d46c23c9a6a70fe7f0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2d59e4175a675913c6226d4488f2ca3dd8abfc98","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def list_opts():"},{"line_number":164,"context_line":"    return ["},{"line_number":165,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":166,"context_line":"         itertools.chain("},{"line_number":167,"context_line":"             [nova.api.metadata.vendordata_json.file_opt],"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_ddd0bbf8","line":164,"in_reply_to":"1aca2d91_327a3e78","updated":"2015-05-08 21:17:29.000000000","message":"it just means that the nova code base needs more groups and not drop every option in DEFAULT :)","commit_id":"da174d848256ec437b5194d46c23c9a6a70fe7f0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"1dde7f77b1e8159b065bd8151dcc3ffc66cf8cdf","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def list_opts():"},{"line_number":164,"context_line":"    return ["},{"line_number":165,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":166,"context_line":"         itertools.chain("},{"line_number":167,"context_line":"             [nova.api.metadata.vendordata_json.file_opt],"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_1f79f993","line":164,"in_reply_to":"1aca2d91_b977c5d3","updated":"2015-05-06 12:46:25.000000000","message":"John,\nI think i have the full list now (all things from older generator is present with this change).\n\nThe oslo team went with \"move away from magic towards much more explicit control over the options the generator\" (see spec here https://github.com/openstack/oslo-specs/blob/master/specs/juno/oslo-config-generator.rst)\n\nwhich test? can you please point me to it? (\"test that checks the output of the default config\"). \n\nOne thing i really want to do as part of this review or a follow up is to split up list_opts here and spread them out closer to where they are defined. This also gives us ideas about new groups we could add as well (instead of dumping everything in the [DEFAULT])\n\nthanks,\ndims","commit_id":"da174d848256ec437b5194d46c23c9a6a70fe7f0"}]}