)]}'
{"nova/block_device.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"78831da77f2584326e7e37f4d69601a6a80326b0","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                bdm[\u0027boot_index\u0027] \u003d None"},{"line_number":365,"context_line":"        # NOTE: Xen does not understand vda, but xvda would be similair."},{"line_number":366,"context_line":"        if (driver.compute_driver_matches(\u0027libvirt.LibvirtDriver\u0027) and"},{"line_number":367,"context_line":"                CONF.libvirt and CONF.libvirt.virt_type \u003d\u003d \u0027xen\u0027):"},{"line_number":368,"context_line":"            for bdm in new_bdms:"},{"line_number":369,"context_line":"                if bdm[\u0027source_type\u0027] !\u003d \u0027volume\u0027:"},{"line_number":370,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_d85835fd","line":367,"updated":"2015-06-30 08:56:14.000000000","message":"It feels pretty wrong to be adding code which accesses libvirt internal config parameters to this common code. I wonder if Nikola has suggestions for a better way to achieve this.","commit_id":"35dc572641e81eb831369a8eaf81eb2ad1b3d67c"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d86abd2b4d1fa7e9ba6f2fdc8a49c7d4f1453add","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                bdm[\u0027boot_index\u0027] \u003d None"},{"line_number":365,"context_line":"        # NOTE: Xen does not understand vda, but xvda would be similair."},{"line_number":366,"context_line":"        if (driver.compute_driver_matches(\u0027libvirt.LibvirtDriver\u0027) and"},{"line_number":367,"context_line":"                CONF.libvirt and CONF.libvirt.virt_type \u003d\u003d \u0027xen\u0027):"},{"line_number":368,"context_line":"            for bdm in new_bdms:"},{"line_number":369,"context_line":"                if bdm[\u0027source_type\u0027] !\u003d \u0027volume\u0027:"},{"line_number":370,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_db0caf96","line":367,"in_reply_to":"ba3cc151_d85835fd","updated":"2015-06-30 09:28:07.000000000","message":"the drivers have exposed default_root_device_name since havana - and libvirt actually customizes it - so fixing that to consider the virt_type (I\u0027m actually surprised it does not already - would be where this kind of thing goes.\n\nthis is just not knowledge we want to have on API nodes.","commit_id":"35dc572641e81eb831369a8eaf81eb2ad1b3d67c"}]}