)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d0ebefe16b7e212906450ba639479a8d5276914c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: add in net_io resource limitations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor extra specs for quotas has been extended to support"},{"line_number":10,"context_line":" quota:net_io_limit - The bandwidth limit for the virtual network adapter."},{"line_number":11,"context_line":"                      The utilization of the virtual network adapter will not"},{"line_number":12,"context_line":"                      exceed this limit, even if there are available resources."},{"line_number":13,"context_line":"                      Units in Mbits/sec."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3a50d1a3_08ac739d","line":10,"updated":"2015-07-29 12:42:34.000000000","message":"Hmm, I am seeing vif_* in the spec:\nhttp://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/vmware-limits.html\n\nI guess that changed?","commit_id":"77129a36ed96a955dcf101e1b2104ae7b55ac832"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6b7b8480300d6f4c2a9254d66cefa9b40bdb8cce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: add in net_io resource limitations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor extra specs for quotas has been extended to support"},{"line_number":10,"context_line":" quota:net_io_limit - The bandwidth limit for the virtual network adapter."},{"line_number":11,"context_line":"                      The utilization of the virtual network adapter will not"},{"line_number":12,"context_line":"                      exceed this limit, even if there are available resources."},{"line_number":13,"context_line":"                      Units in Mbits/sec."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3a50d1a3_77cb7972","line":10,"in_reply_to":"3a50d1a3_08ac739d","updated":"2015-07-29 20:22:38.000000000","message":"John, I asked Gary to change it from vif_ to net_io_ in order to be consistent with the previous patch in this series that adds disk_io_ settables.\n\nI wasn\u0027t involved in the original spec review.\n\nBest,\n\n-jay","commit_id":"77129a36ed96a955dcf101e1b2104ae7b55ac832"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9d02ca0c433cbf928ef6c7aa20d67530d7c61050","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: add in net_io resource limitations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor extra specs for quotas has been extended to support"},{"line_number":10,"context_line":" quota:net_io_limit - The bandwidth limit for the virtual network adapter."},{"line_number":11,"context_line":"                      The utilization of the virtual network adapter will not"},{"line_number":12,"context_line":"                      exceed this limit, even if there are available resources."},{"line_number":13,"context_line":"                      Units in Mbits/sec."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3a50d1a3_f4b2d505","line":10,"in_reply_to":"3a50d1a3_77cb7972","updated":"2015-07-31 10:24:31.000000000","message":"Ah, sorry, so I missed that.\n\nI thought we had vif_io already in libvirt, so we asked in the spec to keep this consistent.\n\nSuch as:\n\u0027quota:vif_inbound_peak\u0027\n\u0027quota:vif_outbound_peak\u0027","commit_id":"77129a36ed96a955dcf101e1b2104ae7b55ac832"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3984e130955c3d5f466fdacc0b101e8b55a9c09f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"This enables the VMware driver to enable VNIC allocations"},{"line_number":32,"context_line":"for the running instance."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"NOTE: this is only supported from vCenter 6.0 onwards."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Co-Authored-By: Radoslav Gerganov \u003crgerganov@vmware.com\u003e"},{"line_number":37,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"9a8ffd7b_6806c787","line":34,"updated":"2015-11-26 10:34:52.000000000","message":"Nit: at somepoint in this chain we will need to document this in reno.","commit_id":"717308c0a35a87a6e357ab31b13ecd04291c5b6e"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4b21ace8d263a184042841bdef4ba1a3147fe3b6","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            hasattr(net_device, \u0027resourceAllocation\u0027)):"},{"line_number":438,"context_line":"        net_device.resourceAllocation \u003d _get_allocation_info("},{"line_number":439,"context_line":"            client_factory, vif_limits,"},{"line_number":440,"context_line":"            \u0027ns0:VirtualEthernetCardResourceAllocation\u0027)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    network_spec.device \u003d net_device"},{"line_number":443,"context_line":"    return network_spec"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a50d1a3_2fde586d","line":440,"updated":"2015-08-03 13:20:37.000000000","message":"Hmm, I am not sure I like the silent skip here, this should probably fail the build, I think.\n\nMy reasoning, it feels bad if you want a vnic limit, but you accidentally hit a host that doesn\u0027t support that limit, and the admin has no way of noticing that, without reading that comment, etc.","commit_id":"25971e6d2b82e611fa5227b51dcc366443bf2fb1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"953322c9dd0bc4998400e426cead80ecbd6a3946","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            hasattr(net_device, \u0027resourceAllocation\u0027)):"},{"line_number":438,"context_line":"        net_device.resourceAllocation \u003d _get_allocation_info("},{"line_number":439,"context_line":"            client_factory, vif_limits,"},{"line_number":440,"context_line":"            \u0027ns0:VirtualEthernetCardResourceAllocation\u0027)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    network_spec.device \u003d net_device"},{"line_number":443,"context_line":"    return network_spec"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a50d1a3_5044a045","line":440,"in_reply_to":"3a50d1a3_2a55e64e","updated":"2015-08-03 13:41:03.000000000","message":"An admin will only configure a VNIC limit is they have VC 6.0 or above. Earlier versions do not support this. At the moment the driver works only with one VC version. I will add in an exception.\nAs far as I understand I have yet to see anyone use a openstack installation with more than one VC. This will certainly not work for datastores and networking.","commit_id":"25971e6d2b82e611fa5227b51dcc366443bf2fb1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a42b8559d878763ddd1ed944fb7376ad5bb00e4d","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            hasattr(net_device, \u0027resourceAllocation\u0027)):"},{"line_number":438,"context_line":"        net_device.resourceAllocation \u003d _get_allocation_info("},{"line_number":439,"context_line":"            client_factory, vif_limits,"},{"line_number":440,"context_line":"            \u0027ns0:VirtualEthernetCardResourceAllocation\u0027)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    network_spec.device \u003d net_device"},{"line_number":443,"context_line":"    return network_spec"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a50d1a3_2a55e64e","line":440,"in_reply_to":"3a50d1a3_2fde586d","updated":"2015-08-03 13:28:39.000000000","message":"Yes if we explicitly request for a limit that cannot be satisfy by this host we should to make the process fails and let scheduler does a retry.","commit_id":"25971e6d2b82e611fa5227b51dcc366443bf2fb1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"165649704152b857eac9802a5ef76dbf1b14d29c","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            hasattr(net_device, \u0027resourceAllocation\u0027)):"},{"line_number":438,"context_line":"        net_device.resourceAllocation \u003d _get_allocation_info("},{"line_number":439,"context_line":"            client_factory, vif_limits,"},{"line_number":440,"context_line":"            \u0027ns0:VirtualEthernetCardResourceAllocation\u0027)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    network_spec.device \u003d net_device"},{"line_number":443,"context_line":"    return network_spec"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a4dcd0f_41d8f61d","line":440,"in_reply_to":"3a50d1a3_5044a045","updated":"2015-08-03 14:13:12.000000000","message":"Yeah, its more about being defensive, I don\u0027t want to block on this really, I just think it would make it easier to not make config mistakes if we raise an exception here.","commit_id":"25971e6d2b82e611fa5227b51dcc366443bf2fb1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7ed964d53104c7abddceaa8c4af19ea7c1a2758a","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                \u0027ns0:VirtualEthernetCardResourceAllocation\u0027)"},{"line_number":441,"context_line":"        else:"},{"line_number":442,"context_line":"            msg \u003d _(\u0027Limits only supported from vCenter 6.0 and above\u0027)"},{"line_number":443,"context_line":"            raise exception.Invalid(msg)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    network_spec.device \u003d net_device"},{"line_number":446,"context_line":"    return network_spec"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a4dcd0f_41ef96b0","line":443,"updated":"2015-08-03 14:13:33.000000000","message":"cool thanks.","commit_id":"fe08d68fe858b0b3805c5696324c3453e7a8b73f"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"5ac95041b93535e6121894459601eb2e5ecca4eb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.disk_io_limits \u003d disk_io_limits"},{"line_number":118,"context_line":"        if vif_limits is None:"},{"line_number":119,"context_line":"            vif_limits \u003d Limits()"},{"line_number":120,"context_line":"        self.vif_limits \u003d vif_limits"},{"line_number":121,"context_line":"        self.hw_version \u003d hw_version"},{"line_number":122,"context_line":"        self.storage_policy \u003d storage_policy"},{"line_number":123,"context_line":"        self.cores_per_socket \u003d cores_per_socket"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a1a9d01_272234ba","line":120,"updated":"2015-09-28 17:08:56.000000000","message":"nit: self.vif_limits \u003d vif_limits or Limits()\nline 118-119 can be removed with this.","commit_id":"ac69ae20d7120a6be701639fc73a95f1bbdb9d12"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"00d2d71c0912e3651552ecb27fb667570f00e168","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.disk_io_limits \u003d disk_io_limits"},{"line_number":118,"context_line":"        if vif_limits is None:"},{"line_number":119,"context_line":"            vif_limits \u003d Limits()"},{"line_number":120,"context_line":"        self.vif_limits \u003d vif_limits"},{"line_number":121,"context_line":"        self.hw_version \u003d hw_version"},{"line_number":122,"context_line":"        self.storage_policy \u003d storage_policy"},{"line_number":123,"context_line":"        self.cores_per_socket \u003d cores_per_socket"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_c05fde73","line":120,"updated":"2015-12-01 08:53:03.000000000","message":"nit: self.vif_limits \u003d vif_limits or Limits()","commit_id":"717308c0a35a87a6e357ab31b13ecd04291c5b6e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aac8fe3480934be72af69660655ee07f4f510863","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.disk_io_limits \u003d disk_io_limits"},{"line_number":118,"context_line":"        if vif_limits is None:"},{"line_number":119,"context_line":"            vif_limits \u003d Limits()"},{"line_number":120,"context_line":"        self.vif_limits \u003d vif_limits"},{"line_number":121,"context_line":"        self.hw_version \u003d hw_version"},{"line_number":122,"context_line":"        self.storage_policy \u003d storage_policy"},{"line_number":123,"context_line":"        self.cores_per_socket \u003d cores_per_socket"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_c8db38ec","line":120,"in_reply_to":"9a8ffd7b_c05fde73","updated":"2015-12-02 10:56:31.000000000","message":"I have addressed that in patch https://review.openstack.org/252327","commit_id":"717308c0a35a87a6e357ab31b13ecd04291c5b6e"}]}