)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c155f241af03dd7f858151cb34615640f41d572e","unresolved":false,"context_lines":[{"line_number":4894,"context_line":"                    context, volume_id, rd_req, rd_bytes, wr_req, wr_bytes,"},{"line_number":4895,"context_line":"                    instance, update_totals\u003dTrue)"},{"line_number":4896,"context_line":"                self.notifier.info(context, \u0027volume.usage\u0027,"},{"line_number":4897,"context_line":"                                   compute_utils.usage_volume_info(vol_usage))"},{"line_number":4898,"context_line":""},{"line_number":4899,"context_line":"        self._detach_volume(context, instance, bdm)"},{"line_number":4900,"context_line":"        connector \u003d self.driver.get_volume_connector(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_2426e968","line":4897,"updated":"2015-05-06 14:07:42.000000000","message":"In the instance object, we send the notifications there automatically  on save so that we don\u0027t miss them. Can/should we do the same here?","commit_id":"0515bde9be81c13472475553b3c5ff79fa7a81ff"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"5cc613db1731679d377358ac9c682233764daa53","unresolved":false,"context_lines":[{"line_number":4894,"context_line":"                    context, volume_id, rd_req, rd_bytes, wr_req, wr_bytes,"},{"line_number":4895,"context_line":"                    instance, update_totals\u003dTrue)"},{"line_number":4896,"context_line":"                self.notifier.info(context, \u0027volume.usage\u0027,"},{"line_number":4897,"context_line":"                                   compute_utils.usage_volume_info(vol_usage))"},{"line_number":4898,"context_line":""},{"line_number":4899,"context_line":"        self._detach_volume(context, instance, bdm)"},{"line_number":4900,"context_line":"        connector \u003d self.driver.get_volume_connector(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_313c92c7","line":4897,"in_reply_to":"1aca2d91_2426e968","updated":"2015-05-08 11:02:49.000000000","message":"Then we need to create the notifier in the object or pass it in somehow. I thought about it but decided against.\n\nInstance notifications are different in that they prior to objects already had special methods in notifications.py that does that and a whole lot more.","commit_id":"0515bde9be81c13472475553b3c5ff79fa7a81ff"}],"nova/conductor/manager.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"950b158a4c67b4da8bbce88f827c2f7bb87906de","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        # We have just updated the database, so send the notification now"},{"line_number":269,"context_line":"        vol_usage \u003d objects.VolumeUsage._from_db_object("},{"line_number":270,"context_line":"            None, objects.VolumeUsage(), vol_usage)"},{"line_number":271,"context_line":"        self.notifier.info(context, \u0027volume.usage\u0027,"},{"line_number":272,"context_line":"                           compute_utils.usage_volume_info(vol_usage))"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_875fb440","line":270,"updated":"2015-05-13 16:10:44.000000000","message":"will this function be only used by previous version \ncompute node? do we need to mention it here, some comments, maybe?\n\nand we have context here, maybe we can set it thought not a big deal?","commit_id":"0ff191135dc8ab5be67d4fd999235c108ff36231"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"10cfa5288917946a25af0840b12e818c7adfb110","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        # We have just updated the database, so send the notification now"},{"line_number":269,"context_line":"        vol_usage \u003d objects.VolumeUsage._from_db_object("},{"line_number":270,"context_line":"            None, objects.VolumeUsage(), vol_usage)"},{"line_number":271,"context_line":"        self.notifier.info(context, \u0027volume.usage\u0027,"},{"line_number":272,"context_line":"                           compute_utils.usage_volume_info(vol_usage))"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_d9f34409","line":270,"in_reply_to":"9a0c5dc1_875fb440","updated":"2015-05-13 20:01:09.000000000","message":"Yes, only old computes. The next change in the series, deprecates this entire method and puts a note on top saying it will be dropped on the next rpc version bump.\n\nNo need for context really, we will only read its values, not change them.","commit_id":"0ff191135dc8ab5be67d4fd999235c108ff36231"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c436daa90316bc74a87a7aef6fab4f195000e9e8","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    # and can be removed in v3.0 of the RPC API."},{"line_number":260,"context_line":"    def vol_usage_update(self, context, vol_id, rd_req, rd_bytes, wr_req,"},{"line_number":261,"context_line":"                         wr_bytes, instance, last_refreshed, update_totals):"},{"line_number":262,"context_line":"        vol_usage \u003d self.db.vol_usage_update(context, vol_id,"},{"line_number":263,"context_line":"                                             rd_req, rd_bytes,"},{"line_number":264,"context_line":"                                             wr_req, wr_bytes,"},{"line_number":265,"context_line":"                                             instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_0fcb8b54","line":262,"updated":"2015-08-25 08:59:50.000000000","message":"its tempting to say convert this call to objects, but thats not really what we normally do, so this makes sense.","commit_id":"b1a3183a6966c3d861503b663f61275dc87d58c3"}]}