)]}'
{"nova/version.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"031ed3aedbd2a93768cc2de8e968938558f8e75f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"NOVA_VENDOR \u003d \"OpenStack\""},{"line_number":18,"context_line":"NOVA_PRODUCT \u003d \"OpenStack Nova\""},{"line_number":19,"context_line":"NOVA_PACKAGE \u003d None  # OS distro package version suffix"},{"line_number":20,"context_line":"NOVA_VERSION \u003d [\u00272013\u0027, \u00271\u0027, None]"},{"line_number":21,"context_line":"YEAR, COUNT, REVISION \u003d NOVA_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F9sM%3D","line":18,"updated":"2012-12-18 18:32:02.000000000","message":"why have the default PRODUCT also have the VENDOR string in there?","commit_id":"1cb078742de60107c2e4b434cb65fd2028750975"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0744df1f180191799d5f739fb813ed3c2d93d59f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"NOVA_VENDOR \u003d \"OpenStack\""},{"line_number":18,"context_line":"NOVA_PRODUCT \u003d \"OpenStack Nova\""},{"line_number":19,"context_line":"NOVA_PACKAGE \u003d None  # OS distro package version suffix"},{"line_number":20,"context_line":"NOVA_VERSION \u003d [\u00272013\u0027, \u00271\u0027, None]"},{"line_number":21,"context_line":"YEAR, COUNT, REVISION \u003d NOVA_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F8tU%3D","line":18,"in_reply_to":"AAAAM3%2F%2F8uI%3D","updated":"2012-12-19 12:23:04.000000000","message":"Yep, adding Foundation is a nice idea - makes it clearer what the distinction is","commit_id":"1cb078742de60107c2e4b434cb65fd2028750975"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9a461b066f4fff99203d545fff3497bb5f4f2c20","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"NOVA_VENDOR \u003d \"OpenStack\""},{"line_number":18,"context_line":"NOVA_PRODUCT \u003d \"OpenStack Nova\""},{"line_number":19,"context_line":"NOVA_PACKAGE \u003d None  # OS distro package version suffix"},{"line_number":20,"context_line":"NOVA_VERSION \u003d [\u00272013\u0027, \u00271\u0027, None]"},{"line_number":21,"context_line":"YEAR, COUNT, REVISION \u003d NOVA_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F8uI%3D","line":18,"in_reply_to":"AAAAM3%2F%2F9qg%3D","updated":"2012-12-19 12:11:13.000000000","message":"Maybe make NOVA_VENDOR \u003d \"OpenStack Foundation\" \n\nMy concern is once this goes in, if the defaults has one of those strings as a substring of the other, then people will follow suit when they change it in their products, assuming it had to be that way.\n\nIt\u0027s all pretty minor, but I\u0027d like you thoughts on that before I start +2ing things :)","commit_id":"1cb078742de60107c2e4b434cb65fd2028750975"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cb7435771749b731e1d025070a3c11806205a859","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"NOVA_VENDOR \u003d \"OpenStack\""},{"line_number":18,"context_line":"NOVA_PRODUCT \u003d \"OpenStack Nova\""},{"line_number":19,"context_line":"NOVA_PACKAGE \u003d None  # OS distro package version suffix"},{"line_number":20,"context_line":"NOVA_VERSION \u003d [\u00272013\u0027, \u00271\u0027, None]"},{"line_number":21,"context_line":"YEAR, COUNT, REVISION \u003d NOVA_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F9qg%3D","line":18,"in_reply_to":"AAAAM3%2F%2F9sM%3D","updated":"2012-12-18 18:42:45.000000000","message":"I think it makes sense, as in one case its referring to OpenStack the organization which publishes the releases, while the second case refers to OpenStack the project brand with which Nova is associated. You might change one, but not the other. For example, Fedora might replace the VENDOR string with \u0027Fedora\u0027 but still leave the PRODUCT as \"OpenStack Nova\".","commit_id":"1cb078742de60107c2e4b434cb65fd2028750975"}]}