)]}'
{"nova/servicegroup/drivers/db.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"abd9c58a1c51f24766be92dcf28705068cf7c5a7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"},{"line_number":99,"context_line":"                             \u0027 for reporting service status.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_88ec6790","line":99,"updated":"2015-05-08 00:11:48.000000000","message":"nit, looks like double \u0027blank space between \u0027nova-conductor\u0027 and \u0027for\u0027 at here.","commit_id":"f61351598dcdff1871a38d2fdc9c51e91a5f075a"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"e8947dd8b816f8e959a5f1b30aa78297065fe8ab","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_9316d853","line":95,"updated":"2015-05-08 01:10:30.000000000","message":"hi sean, can you check this case?\nhttps://bugs.launchpad.net/nova/+bug/1401469\n\nif you only catch messaging.MessagingTimeout, but the service is actually delete from conductor db, so the report_state will raise service is not found error, and that error can not be handle, and service.model_disconnected will always be False, then this service will still always think it is alive...\n\nthis could be wrong.","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"074e17cac9343c4be81ea2151f65cb1a33fd686c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_a54bbc86","line":95,"in_reply_to":"1aca2d91_4513c80d","updated":"2015-05-08 13:37:19.000000000","message":"the case is when service is deleted by admin manually but service is in \u0027UP\u0027 state. I proposed a spec to disable delete in \u0027up\u0027 state service on https://review.openstack.org/#/c/163274/","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d941f4246fa0dc5da94a840a889f95abf5ad5c5b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_4513c80d","line":95,"in_reply_to":"1aca2d91_9316d853","updated":"2015-05-08 13:21:29.000000000","message":"So, this seems that we shouldn\u0027t hit that in a normal case. Because this is the service checking in, and if the service is still up and checking in but it\u0027s records were deleted, that seems pretty fatal, no?","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43e40aa9296ab89f17a4c37f3596104b10b286fc","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_c65ebe11","line":95,"in_reply_to":"1aca2d91_a54bbc86","updated":"2015-05-08 14:28:58.000000000","message":"@Eli, after your propose https://review.openstack.org/#/c/163274/, then this problem isn\u0027t existed any more, right? So https://bugs.launchpad.net/nova/+bug/1401469 should be fixed  by your spec, so that isn\u0027t a expected error, we shouldn\u0027t catch it at here.","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7ecce7be8e8ce1636b04d45f547186ad51a89777","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_94d7994a","line":95,"in_reply_to":"1aca2d91_c65ebe11","updated":"2015-08-19 17:28:43.000000000","message":"Agreed, that\u0027s not the right place for catching such problem and honestly I give anytime a huge +1 for anyone just replacing any silly Exception catchall by a decent one.","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0883327cfef434389138272cd0535fd534f973f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_b49dfd67","line":95,"in_reply_to":"fa1b9901_14206947","updated":"2015-08-19 17:35:20.000000000","message":"From the kilo side in a partial n-cpu grenade run on this change, this shows it\u0027s hitting MessagingTimeout so maybe my fear isn\u0027t grounded:\n\nhttp://logs.openstack.org/56/180956/3/check/gate-grenade-dsvm-partial-ncpu/6ad2360/logs/old/screen-n-cpu.txt.gz?level\u003dTRACE","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1907c10e7d65997d71fd6ce84eed18afc2531dd4","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # because we are communicating over conductor, a failure to"},{"line_number":94,"context_line":"        # connect is going to be a messaging failure, not a db error."},{"line_number":95,"context_line":"        except messaging.MessagingTimeout:"},{"line_number":96,"context_line":"            if not getattr(service, \u0027model_disconnected\u0027, False):"},{"line_number":97,"context_line":"                service.model_disconnected \u003d True"},{"line_number":98,"context_line":"                LOG.warn(_LW(\u0027Lost connection to nova-conductor \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_14206947","line":95,"in_reply_to":"fa1b9901_94d7994a","updated":"2015-08-19 17:31:48.000000000","message":"The one nit worth picking here might be to handle the more generic MessagingException base class rather than just the timeout:\n\nhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/exceptions.py#n22","commit_id":"3bc171202163a3810fdc9bdb3bad600487625443"}]}