)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"eec9fbe4b1d6731ce242b914040318e1a3cf2993","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        return bool(value)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"class FlexibleBoolean(Boolean):"},{"line_number":310,"context_line":"    @staticmethod"},{"line_number":311,"context_line":"    def coerce(obj, attr, value):"},{"line_number":312,"context_line":"        return strutils.bool_from_string(value)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_03dd3e14","line":309,"updated":"2015-05-10 12:51:40.000000000","message":"Looks like just \u0027class FlexibleBoolean(FieldType)\u0027 is ok, but it\u0027s fine...nothing biggy","commit_id":"d3d8e22c365d6927db7b033c80515db188975830"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"de3bd6b2d6472e758dc6ad552b7f2d2e9bff671d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        return bool(value)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"class FlexibleBoolean(Boolean):"},{"line_number":310,"context_line":"    @staticmethod"},{"line_number":311,"context_line":"    def coerce(obj, attr, value):"},{"line_number":312,"context_line":"        return strutils.bool_from_string(value)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_af93d8f9","line":309,"in_reply_to":"9af37de9_03dd3e14","updated":"2015-05-12 19:29:46.000000000","message":"It makes sense to inherit from Boolean for isinstance() tests, I think.","commit_id":"d3d8e22c365d6927db7b033c80515db188975830"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba73f0d3351d22682bc588aaf419ed4b3354b997","unresolved":false,"context_lines":[{"line_number":648,"context_line":"    AUTO_TYPE \u003d Float()"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"# This is a strict interpretation of boolean"},{"line_number":652,"context_line":"# values using Python\u0027s semantics for truth/falsehood"},{"line_number":653,"context_line":"class BooleanField(AutoTypedField):"},{"line_number":654,"context_line":"    AUTO_TYPE \u003d Boolean()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_bb1502e6","line":651,"updated":"2015-05-09 07:47:03.000000000","message":"Instead of a comment we can use doc string here.","commit_id":"d3d8e22c365d6927db7b033c80515db188975830"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"25cb49fbc829e72ac123dba78c2207380df07e31","unresolved":false,"context_lines":[{"line_number":648,"context_line":"    AUTO_TYPE \u003d Float()"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"# This is a strict interpretation of boolean"},{"line_number":652,"context_line":"# values using Python\u0027s semantics for truth/falsehood"},{"line_number":653,"context_line":"class BooleanField(AutoTypedField):"},{"line_number":654,"context_line":"    AUTO_TYPE \u003d Boolean()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_4f6fed92","line":651,"in_reply_to":"1aca2d91_bb1502e6","updated":"2015-05-09 18:37:19.000000000","message":"Meh :)\n\nNone of the other field definitions here have those docstrings. This isn\u0027t library stuff, and we\u0027re not (likely) going to bring the flexible boolean variant into the library. Other clarifications, other than abstract method docs, aren\u0027t docstring\u0027d here. I think what he has is plenty consistent.","commit_id":"d3d8e22c365d6927db7b033c80515db188975830"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1719d87007fea86924036cd6f6d92361b312789f","unresolved":false,"context_lines":[{"line_number":648,"context_line":"    AUTO_TYPE \u003d Float()"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"# This is a strict interpretation of boolean"},{"line_number":652,"context_line":"# values using Python\u0027s semantics for truth/falsehood"},{"line_number":653,"context_line":"class BooleanField(AutoTypedField):"},{"line_number":654,"context_line":"    AUTO_TYPE \u003d Boolean()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_bd9d625b","line":651,"in_reply_to":"9af37de9_4f6fed92","updated":"2015-05-11 07:27:02.000000000","message":"Oops OK I said nothing :)","commit_id":"d3d8e22c365d6927db7b033c80515db188975830"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba73f0d3351d22682bc588aaf419ed4b3354b997","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    AUTO_TYPE \u003d Boolean()"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"# This is a flexible interpretation of boolean"},{"line_number":658,"context_line":"# values using common user friendly semantics for"},{"line_number":659,"context_line":"# truth/falsehood. ie strings like \u0027yes\u0027, \u0027no\u0027,"},{"line_number":660,"context_line":"# \u0027on\u0027, \u0027off\u0027, \u0027t\u0027, \u0027f\u0027 get mapped to values you"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_9bd5a61d","line":657,"updated":"2015-05-09 07:47:03.000000000","message":"Same here too","commit_id":"d3d8e22c365d6927db7b033c80515db188975830"}]}