)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cad5d40686e0b0760a129bc3849f75502c9f1cc2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in order to access security_group_default_rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is related to bp nova-api-policy-final-part"},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I221d1056b0101fc5c909222d9cac6739fd106e3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_3e6bc086","line":14,"updated":"2015-06-11 13:17:23.000000000","message":"v2.1 already released, so better to add UpgradeImpact flag","commit_id":"557c68237cba7e0f30b39a8801a9d3af7af8108c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3f72aa296ecbdfc0ee134382bf57d3c7ccd179fa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in order to access security_group_default_rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is related to bp nova-api-policy-final-part"},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I221d1056b0101fc5c909222d9cac6739fd106e3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_3ef059c9","line":14,"in_reply_to":"3afb71cf_3e6bc086","updated":"2015-06-11 15:40:22.000000000","message":"ok","commit_id":"557c68237cba7e0f30b39a8801a9d3af7af8108c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"55fb6eb4d6119ae39667ab4b8005d3284479b339","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-31 12:01:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove policy check security_group_default_rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add check in security_group_default_rules,"},{"line_number":10,"context_line":"user need to be authorized to security_groups"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_703d00dc","line":7,"updated":"2015-06-18 02:27:12.000000000","message":"How about\n\n Remove redundant policy check from security_group_default_rule\n\n?","commit_id":"16c711ae2faaa8a094a9a46f3c9cbda3fd48c851"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6b19b71977c37de6b1aa4b524daece350a040bc1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-31 12:01:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove policy check security_group_default_rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add check in security_group_default_rules,"},{"line_number":10,"context_line":"user need to be authorized to security_groups"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_0e531a6c","line":7,"in_reply_to":"fa32b979_703d00dc","updated":"2015-06-18 14:43:34.000000000","message":"ok, right, thanks","commit_id":"16c711ae2faaa8a094a9a46f3c9cbda3fd48c851"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"55fb6eb4d6119ae39667ab4b8005d3284479b339","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove policy check security_group_default_rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add check in security_group_default_rules,"},{"line_number":10,"context_line":"user need to be authorized to security_groups"},{"line_number":11,"context_line":"in order to access security_group_default_rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is related to bp nova-api-policy-final-part"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_305d3847","line":10,"updated":"2015-06-18 02:27:12.000000000","message":"I was confused see both code and this explanation.\n\nMaybe here should be\n\n user is not necessary to be authorized to security_groups","commit_id":"16c711ae2faaa8a094a9a46f3c9cbda3fd48c851"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6b19b71977c37de6b1aa4b524daece350a040bc1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove policy check security_group_default_rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add check in security_group_default_rules,"},{"line_number":10,"context_line":"user need to be authorized to security_groups"},{"line_number":11,"context_line":"in order to access security_group_default_rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is related to bp nova-api-policy-final-part"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_4e5cc27c","line":10,"in_reply_to":"fa32b979_305d3847","updated":"2015-06-18 14:43:34.000000000","message":"Done","commit_id":"16c711ae2faaa8a094a9a46f3c9cbda3fd48c851"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"55fb6eb4d6119ae39667ab4b8005d3284479b339","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add check in security_group_default_rules,"},{"line_number":10,"context_line":"user need to be authorized to security_groups"},{"line_number":11,"context_line":"in order to access security_group_default_rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is related to bp nova-api-policy-final-part"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_b03708fe","line":11,"updated":"2015-06-18 02:27:12.000000000","message":"and\n\n Then this patch removes the security_groups policy check from security_group_default_rules.","commit_id":"16c711ae2faaa8a094a9a46f3c9cbda3fd48c851"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6b19b71977c37de6b1aa4b524daece350a040bc1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We add check in security_group_default_rules,"},{"line_number":10,"context_line":"user need to be authorized to security_groups"},{"line_number":11,"context_line":"in order to access security_group_default_rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is related to bp nova-api-policy-final-part"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_2e593e8e","line":11,"in_reply_to":"fa32b979_b03708fe","updated":"2015-06-18 14:43:34.000000000","message":"Done","commit_id":"16c711ae2faaa8a094a9a46f3c9cbda3fd48c851"}],"nova/tests/unit/api/openstack/compute/contrib/test_security_group_default_rules.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5fba8d98fb84661916aa50cd18aa410397460ccb","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _common_policy_check(self, func, *arg, **kwarg):"},{"line_number":382,"context_line":"        rule_name \u003d \"os_compute_api:os-security-groups\""},{"line_number":383,"context_line":"        rule \u003d {rule_name: \"project:non_fake\"}"},{"line_number":384,"context_line":"        self.policy.set_rules(rule)"},{"line_number":385,"context_line":"        exc \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_89ceed81","side":"PARENT","line":382,"updated":"2015-05-10 15:10:33.000000000","message":"we should keep those test, and test the rule \u0027os_compute_api:os-security-group-default-rules\u0027","commit_id":"5cdcf7dede16817d443d5bd649f49518c702330c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e86ea8a5106180a8a448cb57dac9f738a3459171","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _common_policy_check(self, func, *arg, **kwarg):"},{"line_number":382,"context_line":"        rule_name \u003d \"os_compute_api:os-security-groups\""},{"line_number":383,"context_line":"        rule \u003d {rule_name: \"project:non_fake\"}"},{"line_number":384,"context_line":"        self.policy.set_rules(rule)"},{"line_number":385,"context_line":"        exc \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_f77cea73","side":"PARENT","line":382,"in_reply_to":"9af37de9_89ceed81","updated":"2015-05-15 13:23:28.000000000","message":"ok,thanks","commit_id":"5cdcf7dede16817d443d5bd649f49518c702330c"}]}