)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"35a07c74f51dda5e731072371f7c116f09192b74","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     javeme \u003cjavaloveme@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-09 23:15:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vm_state and power_state are inconsistent after creating a VM which is not power-on."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vm_state and power_state are inconsistent after creating a VM which is not power-on, until periodic task _sync_power_states()."},{"line_number":10,"context_line":"It\u0027s need to set the vm_state to the state decided by the power_state(such as STOPPED) instead of ACTIVE, after it is created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aca2d91_f58ee677","line":7,"updated":"2015-05-09 15:22:53.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"fca405f9636100befe99134dad2a33a74dab5d69"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"7ea08ea26367cc5427d7e35491457e23113ce167","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     javeme \u003cjavaloveme@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-09 23:15:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vm_state and power_state are inconsistent after creating a VM which is not power-on."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vm_state and power_state are inconsistent after creating a VM which is not power-on, until periodic task _sync_power_states()."},{"line_number":10,"context_line":"It\u0027s need to set the vm_state to the state decided by the power_state(such as STOPPED) instead of ACTIVE, after it is created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9af37de9_92f73af5","line":7,"in_reply_to":"1aca2d91_f58ee677","updated":"2015-05-09 21:01:07.000000000","message":"ok","commit_id":"fca405f9636100befe99134dad2a33a74dab5d69"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ecc26cc96bf4748fe8d897cd38316fd753aad088","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     javeme \u003cjavaloveme@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-10 04:46:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"To make vm_state consistent with power_state."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm_state and the power_state are inconsistent after creating"},{"line_number":10,"context_line":"a VM which is not power-on, until the periodic task running:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_ac689abb","line":7,"updated":"2015-05-11 03:32:12.000000000","message":"Make vm_state...","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c984db8d87685d9d7013a4955e357d7b7d256def","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     javeme \u003cjavaloveme@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-10 04:46:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"To make vm_state consistent with power_state."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm_state and the power_state are inconsistent after creating"},{"line_number":10,"context_line":"a VM which is not power-on, until the periodic task running:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_2a5a4084","line":7,"in_reply_to":"9af37de9_ac689abb","updated":"2015-05-11 15:05:50.000000000","message":"ok","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ecc26cc96bf4748fe8d897cd38316fd753aad088","unresolved":false,"context_lines":[{"line_number":7,"context_line":"To make vm_state consistent with power_state."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm_state and the power_state are inconsistent after creating"},{"line_number":10,"context_line":"a VM which is not power-on, until the periodic task running:"},{"line_number":11,"context_line":"method _sync_power_states()."},{"line_number":12,"context_line":"It\u0027s need to set the vm_state to a state decided by the power_state"},{"line_number":13,"context_line":"(such as: maybe STOPPED) instead of ACTIVE after it is created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_4c5fee0e","line":10,"updated":"2015-05-11 03:32:12.000000000","message":"not powered on.\n\nNot sure I understand the rest of the sentence.","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c984db8d87685d9d7013a4955e357d7b7d256def","unresolved":false,"context_lines":[{"line_number":7,"context_line":"To make vm_state consistent with power_state."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The vm_state and the power_state are inconsistent after creating"},{"line_number":10,"context_line":"a VM which is not power-on, until the periodic task running:"},{"line_number":11,"context_line":"method _sync_power_states()."},{"line_number":12,"context_line":"It\u0027s need to set the vm_state to a state decided by the power_state"},{"line_number":13,"context_line":"(such as: maybe STOPPED) instead of ACTIVE after it is created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_aa775001","line":10,"in_reply_to":"9af37de9_4c5fee0e","updated":"2015-05-11 15:05:50.000000000","message":"yes, you say what I mean.","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ecc26cc96bf4748fe8d897cd38316fd753aad088","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The vm_state and the power_state are inconsistent after creating"},{"line_number":10,"context_line":"a VM which is not power-on, until the periodic task running:"},{"line_number":11,"context_line":"method _sync_power_states()."},{"line_number":12,"context_line":"It\u0027s need to set the vm_state to a state decided by the power_state"},{"line_number":13,"context_line":"(such as: maybe STOPPED) instead of ACTIVE after it is created."},{"line_number":14,"context_line":"Closes-Bug: #1445881"},{"line_number":15,"context_line":"Change-Id: Ibf2c10e0b5c7820cd611fcfdc53fefa22c94b477"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_4cb6ce3e","line":12,"updated":"2015-05-11 03:32:12.000000000","message":"s/need/needed","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c984db8d87685d9d7013a4955e357d7b7d256def","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The vm_state and the power_state are inconsistent after creating"},{"line_number":10,"context_line":"a VM which is not power-on, until the periodic task running:"},{"line_number":11,"context_line":"method _sync_power_states()."},{"line_number":12,"context_line":"It\u0027s need to set the vm_state to a state decided by the power_state"},{"line_number":13,"context_line":"(such as: maybe STOPPED) instead of ACTIVE after it is created."},{"line_number":14,"context_line":"Closes-Bug: #1445881"},{"line_number":15,"context_line":"Change-Id: Ibf2c10e0b5c7820cd611fcfdc53fefa22c94b477"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_6a7968fc","line":12,"in_reply_to":"9af37de9_4cb6ce3e","updated":"2015-05-11 15:05:50.000000000","message":"ok, thank you for your patience.","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"}],"nova/compute/manager.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"46e34d1204e6c4bc841262e0996aea95f271f802","unresolved":false,"context_lines":[{"line_number":2005,"context_line":""},{"line_number":2006,"context_line":"        if power_stat \u003d\u003d power_state.RUNNING:"},{"line_number":2007,"context_line":"            vm_state \u003d vm_states.ACTIVE"},{"line_number":2008,"context_line":"        elif power_stat \u003d\u003d power_state.SHUTDOWN:"},{"line_number":2009,"context_line":"            vm_state \u003d vm_states.STOPPED"},{"line_number":2010,"context_line":"        elif power_stat \u003d\u003d power_state.PAUSED:"},{"line_number":2011,"context_line":"            vm_state \u003d vm_states.PAUSED"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_e378fa91","line":2008,"updated":"2015-05-10 12:03:17.000000000","message":"a power_state to vm_state mapping better, not hard code with if statement.","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c984db8d87685d9d7013a4955e357d7b7d256def","unresolved":false,"context_lines":[{"line_number":2005,"context_line":""},{"line_number":2006,"context_line":"        if power_stat \u003d\u003d power_state.RUNNING:"},{"line_number":2007,"context_line":"            vm_state \u003d vm_states.ACTIVE"},{"line_number":2008,"context_line":"        elif power_stat \u003d\u003d power_state.SHUTDOWN:"},{"line_number":2009,"context_line":"            vm_state \u003d vm_states.STOPPED"},{"line_number":2010,"context_line":"        elif power_stat \u003d\u003d power_state.PAUSED:"},{"line_number":2011,"context_line":"            vm_state \u003d vm_states.PAUSED"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_34685ff5","line":2008,"in_reply_to":"9af37de9_e378fa91","updated":"2015-05-11 15:05:50.000000000","message":"That\u0027s more concise and extensible, right?","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"5ee8b3e950162effcb6216c1066ffb0095468087","unresolved":false,"context_lines":[{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"    @staticmethod"},{"line_number":2003,"context_line":"    def _get_vm_state_by_power_state(power_stat):"},{"line_number":2004,"context_line":"        default_vm_state \u003d vm_states.ACTIVE"},{"line_number":2005,"context_line":"        power_state_vm_state_map \u003d {"},{"line_number":2006,"context_line":"            power_state.RUNNING: vm_states.ACTIVE,"},{"line_number":2007,"context_line":"            power_state.SHUTDOWN: vm_states.STOPPED,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_1b816c8f","line":2004,"updated":"2015-05-21 22:19:15.000000000","message":"is this the right default state?  it seems risky to say it is active if we don\u0027t know what the state is.  Im not sure - should we have an unknown state?","commit_id":"ec071656a52096a7e0c7db46e1be20d07bf1487f"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"71c043cfd31677b5052ddf29cf43c605f5666202","unresolved":false,"context_lines":[{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"    @staticmethod"},{"line_number":2003,"context_line":"    def _get_vm_state_by_power_state(power_stat):"},{"line_number":2004,"context_line":"        default_vm_state \u003d vm_states.ACTIVE"},{"line_number":2005,"context_line":"        power_state_vm_state_map \u003d {"},{"line_number":2006,"context_line":"            power_state.RUNNING: vm_states.ACTIVE,"},{"line_number":2007,"context_line":"            power_state.SHUTDOWN: vm_states.STOPPED,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_f858b232","line":2004,"in_reply_to":"7a016987_1b816c8f","updated":"2015-05-23 14:41:34.000000000","message":"You\u0027re right, it seems to be imperfect. but it\u0027s hard to decide which state to set as the default value.\n\nBefore this patch, we set vm_state \u003d vm_states.ACTIVE directly, therefore, I still set it as the default value.\n\n\"should we have an unknown state?\"\n-- I think it will not be allowed to add an unknown state. \n\nDo you have any good idea? thanks very much.","commit_id":"ec071656a52096a7e0c7db46e1be20d07bf1487f"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ecc26cc96bf4748fe8d897cd38316fd753aad088","unresolved":false,"context_lines":[{"line_number":4739,"context_line":"        for power_stat in power_state_vm_state_map.iterkeys():"},{"line_number":4740,"context_line":"            vm_state \u003d self.compute._get_vm_state_by_power_state(power_stat)"},{"line_number":4741,"context_line":"            expected_vm_state \u003d power_state_vm_state_map[power_stat]"},{"line_number":4742,"context_line":"            self.assertEqual(vm_state, expected_vm_state)"},{"line_number":4743,"context_line":""},{"line_number":4744,"context_line":"    def test_rebuild_instance_notification(self):"},{"line_number":4745,"context_line":"        # Ensure notifications on instance migrate/resize."}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_cc807e49","line":4742,"updated":"2015-05-11 03:32:12.000000000","message":"Always order assertEqual(expected, actual)","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c984db8d87685d9d7013a4955e357d7b7d256def","unresolved":false,"context_lines":[{"line_number":4739,"context_line":"        for power_stat in power_state_vm_state_map.iterkeys():"},{"line_number":4740,"context_line":"            vm_state \u003d self.compute._get_vm_state_by_power_state(power_stat)"},{"line_number":4741,"context_line":"            expected_vm_state \u003d power_state_vm_state_map[power_stat]"},{"line_number":4742,"context_line":"            self.assertEqual(vm_state, expected_vm_state)"},{"line_number":4743,"context_line":""},{"line_number":4744,"context_line":"    def test_rebuild_instance_notification(self):"},{"line_number":4745,"context_line":"        # Ensure notifications on instance migrate/resize."}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_ea7c3822","line":4742,"in_reply_to":"9af37de9_cc807e49","updated":"2015-05-11 15:05:50.000000000","message":"ok","commit_id":"8f7e49e8181e624c50e14456c23abca5ad6fc301"}]}