)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"61fe3a6685e72de805e9784a7d0ea81030fe95fb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"When the new config option (console_one_time_token) is enabled all consoleauth"},{"line_number":17,"context_line":"tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_tokeen_ttl to"},{"line_number":20,"context_line":"minimise the possibilty that a toekn will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_c63eb28a","line":19,"range":{"start_line":19,"start_character":54,"end_line":19,"end_character":72},"updated":"2015-07-01 23:01:11.000000000","message":"typo","commit_id":"216db8a7a815bd0913c47f1fc80315200233a36d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"198e2bc837fcd78b484fe0685df0944618a98d06","unresolved":false,"context_lines":[{"line_number":16,"context_line":"When the new config option (console_one_time_token) is enabled all consoleauth"},{"line_number":17,"context_line":"tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_tokeen_ttl to"},{"line_number":20,"context_line":"minimise the possibilty that a toekn will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_de0bcf28","line":19,"range":{"start_line":19,"start_character":54,"end_line":19,"end_character":72},"in_reply_to":"ba3cc151_c63eb28a","updated":"2015-07-02 06:33:02.000000000","message":"Done","commit_id":"216db8a7a815bd0913c47f1fc80315200233a36d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"61fe3a6685e72de805e9784a7d0ea81030fe95fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_tokeen_ttl to"},{"line_number":20,"context_line":"minimise the possibilty that a toekn will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_864d0a40","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":36},"updated":"2015-07-01 23:01:11.000000000","message":"typo","commit_id":"216db8a7a815bd0913c47f1fc80315200233a36d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1fd833b932b2d005ca452c4529e1a5320693c475","unresolved":false,"context_lines":[{"line_number":17,"context_line":"tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_tokeen_ttl to"},{"line_number":20,"context_line":"minimise the possibilty that a toekn will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a7774cd3","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":36},"in_reply_to":"ba3cc151_3f3eeab8","updated":"2015-07-07 00:13:17.000000000","message":"And apparently the highlighting only works if using Gerrit\u0027s \"New Screen\".  So not everyone will see it (I\u0027m use Old Screen).","commit_id":"216db8a7a815bd0913c47f1fc80315200233a36d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e5d44c118f45a96957bc4865adba3b265916ecd4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_tokeen_ttl to"},{"line_number":20,"context_line":"minimise the possibilty that a toekn will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_3f3eeab8","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":36},"in_reply_to":"ba3cc151_7e040317","updated":"2015-07-06 19:54:50.000000000","message":"I learned about it recently. You just select the text you want to highlight with the mouse before clicking the line to add a comment. You\u0027ll be able to see the highlight in yellow after you click \"Save.\"","commit_id":"216db8a7a815bd0913c47f1fc80315200233a36d"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"198e2bc837fcd78b484fe0685df0944618a98d06","unresolved":false,"context_lines":[{"line_number":17,"context_line":"tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_tokeen_ttl to"},{"line_number":20,"context_line":"minimise the possibilty that a toekn will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_7e040317","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":36},"in_reply_to":"ba3cc151_864d0a40","updated":"2015-07-02 06:33:02.000000000","message":"Done\n\nAlso how\u0027d you do that highlight thing?","commit_id":"216db8a7a815bd0913c47f1fc80315200233a36d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e858d7c7cec024289e99d30796bbe1131517154f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"consoleauth tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_token_ttl to"},{"line_number":20,"context_line":"minimise the possibility that a token will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a4dcd0f_7f759961","line":20,"updated":"2015-08-07 13:18:32.000000000","message":"This won\u0027t work with VMs using SPICE consoles as they require opening of multiple TCP connections for a console.","commit_id":"9f8c537b5c075f6a9a5af68163b04176331d9917"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"498f5d72fb1ee75bd69367f44e3f3bf2c9b2c75e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"consoleauth tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_token_ttl to"},{"line_number":20,"context_line":"minimise the possibility that a token will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a4dcd0f_f7be72d3","line":20,"in_reply_to":"1a4dcd0f_1ce4680b","updated":"2015-08-10 08:59:44.000000000","message":"Well if we\u0027re going to fix the bug we need a solution that works for both. I don\u0027t think it is helpful to fix it in VNC and ignore it in SPICE. If you find a solution that works for SPICE, it\u0027ll also work for VNC, but not vica-verca.","commit_id":"9f8c537b5c075f6a9a5af68163b04176331d9917"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aaceeca27e66f691bc4c41a3edc7a6491ba6cd0e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"consoleauth tokens are single use."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This config option should be used in conjunction with console_token_ttl to"},{"line_number":20,"context_line":"minimise the possibility that a token will be mis used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Closes-Bug: 1447679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a4dcd0f_1ce4680b","line":20,"in_reply_to":"1a4dcd0f_7f759961","updated":"2015-08-10 05:30:48.000000000","message":"Okay.  I can ignore console_one_time if the console in question is spice and we\u0027d be no worse off in that scenario than we are today.\n\nI\u0027ll do some testing with spice enabled.","commit_id":"9f8c537b5c075f6a9a5af68163b04176331d9917"}],"nova/consoleauth/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49a25e6ab09a8b95c21c45cad1d87040ef38af3f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            token \u003d jsonutils.loads(token_str)"},{"line_number":132,"context_line":"            if self._validate_token(context, token):"},{"line_number":133,"context_line":"                if CONF.console_one_time_token:"},{"line_number":134,"context_line":"                    LOG.info(_LI(\"one_time_token is set deleting %(token)s\"),"},{"line_number":135,"context_line":"                             {\u0027token\u0027: token[\u0027token\u0027]})"},{"line_number":136,"context_line":"                    self.mc.delete(token[\u0027token\u0027])"},{"line_number":137,"context_line":"                return token"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_114f68be","line":134,"range":{"start_line":134,"start_character":34,"end_line":134,"end_character":48},"updated":"2015-06-30 00:33:10.000000000","message":"This doesn\u0027t match the config option name console_one_time_token. It would also be nice to have a comma after the word \"set\"","commit_id":"24475538bd4090f0a9298b96b7e4c177a216df35"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4bf30ce801f6c2b621f758a96ccd1dd81ae292d8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            token \u003d jsonutils.loads(token_str)"},{"line_number":132,"context_line":"            if self._validate_token(context, token):"},{"line_number":133,"context_line":"                if CONF.console_one_time_token:"},{"line_number":134,"context_line":"                    LOG.info(_LI(\"one_time_token is set deleting %(token)s\"),"},{"line_number":135,"context_line":"                             {\u0027token\u0027: token[\u0027token\u0027]})"},{"line_number":136,"context_line":"                    self.mc.delete(token[\u0027token\u0027])"},{"line_number":137,"context_line":"                return token"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_35a4d1a4","line":134,"range":{"start_line":134,"start_character":34,"end_line":134,"end_character":48},"in_reply_to":"ba3cc151_114f68be","updated":"2015-06-30 05:40:22.000000000","message":"Done","commit_id":"24475538bd4090f0a9298b96b7e4c177a216df35"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ade9afe7acfc8765bc62f25df0f0c4492b716242","unresolved":false,"context_lines":[{"line_number":36,"context_line":"consoleauth_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027console_one_time_token\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Delete the token after validation\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":41,"context_line":"               default\u003d600,"},{"line_number":42,"context_line":"               help\u003d\u0027How many seconds before deleting tokens\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_7db87375","line":39,"updated":"2015-07-02 14:49:44.000000000","message":"What are the drawbacks of setting this True?  What if the token was always deleted after validation? Is a conf option necessary?","commit_id":"c22616753e616ec60303e9eac0494683e152c562"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a50c9cf1a795f8da070f5e809b7ccc17b8893cf2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"consoleauth_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027console_one_time_token\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Delete the token after validation\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":41,"context_line":"               default\u003d600,"},{"line_number":42,"context_line":"               help\u003d\u0027How many seconds before deleting tokens\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_cb43e4ad","line":39,"in_reply_to":"ba3cc151_55df7139","updated":"2015-07-02 23:17:55.000000000","message":"That helps, thanks!  Maybe for security purposes this option help should state it\u0027s recommend to set True, but default is False for backward compatibility.","commit_id":"c22616753e616ec60303e9eac0494683e152c562"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"9fc35703826729294085ee10362d70b85115e95e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"consoleauth_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027console_one_time_token\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Delete the token after validation\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":41,"context_line":"               default\u003d600,"},{"line_number":42,"context_line":"               help\u003d\u0027How many seconds before deleting tokens\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_55df7139","line":39,"in_reply_to":"ba3cc151_7db87375","updated":"2015-07-02 21:50:47.000000000","message":"I went back and forth on the config option.  In the end I decided that I didn\u0027t have  enough of an understanding of how the tokens are used to decide but the pathological case could be an environment that set the ttl to 1 year (or more) and then bookmark the URL.  So I thought that the config option would allow all use cases.  The default was selected to not change the default behaviour but it could be changed if the general consensus is that \u0027True\u0027 is better.\n\nDoes that answer your question?","commit_id":"c22616753e616ec60303e9eac0494683e152c562"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ae4a7ce75de9daccfe1a830440a01776bcda819a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"consoleauth_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027console_one_time_token\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Delete the token after validation\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":41,"context_line":"               default\u003d600,"},{"line_number":42,"context_line":"               help\u003d\u0027How many seconds before deleting tokens\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_cb00c404","line":39,"in_reply_to":"ba3cc151_cb43e4ad","updated":"2015-07-02 23:35:41.000000000","message":"Thanks Eric.  I\u0027ll expand the helptext.","commit_id":"c22616753e616ec60303e9eac0494683e152c562"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"498fb5fe30604ae9ac515254eb6de7d54fa8c429","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d(\u0027Delete the token after validation, so it can only be \u0027"},{"line_number":40,"context_line":"                      \u0027used a single time. We recommend you set this flag to \u0027"},{"line_number":41,"context_line":"                      \u0027True, but we default to False to be backward \u0027"},{"line_number":42,"context_line":"                      \u0027compatible.\u0027)),"},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":44,"context_line":"               default\u003d600,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_ff17f442","line":41,"updated":"2015-07-31 19:39:08.000000000","message":"I love this patch, except for this bit right here.  I think it would be better to find a way to deprecate False being the default.  Maybe we need to bring this up at the Nova meeting or on the ML but I would much prefer if we could say that this is the default for now and that after some deprecation period we will switch it to True.","commit_id":"9f8c537b5c075f6a9a5af68163b04176331d9917"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aaceeca27e66f691bc4c41a3edc7a6491ba6cd0e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d(\u0027Delete the token after validation, so it can only be \u0027"},{"line_number":40,"context_line":"                      \u0027used a single time. We recommend you set this flag to \u0027"},{"line_number":41,"context_line":"                      \u0027True, but we default to False to be backward \u0027"},{"line_number":42,"context_line":"                      \u0027compatible.\u0027)),"},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":44,"context_line":"               default\u003d600,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_dcba800a","line":41,"in_reply_to":"3a50d1a3_ff17f442","updated":"2015-08-10 05:30:48.000000000","message":"Okay I\u0027ll start a thread and see where things land.","commit_id":"9f8c537b5c075f6a9a5af68163b04176331d9917"}]}