)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"93a46dcd0aaae6060823a335961346fe22f67b10","unresolved":false,"context_lines":[{"line_number":4091,"context_line":"            instance_type \u003d instance.get_flavor(\u0027new\u0027)"},{"line_number":4092,"context_line":"            self._set_instance_info(instance, instance_type)"},{"line_number":4093,"context_line":"            for key in (\u0027root_gb\u0027, \u0027swap\u0027, \u0027ephemeral_gb\u0027):"},{"line_number":4094,"context_line":"                if old_instance_type[key] !\u003d instance_type[key]:"},{"line_number":4095,"context_line":"                    resize_instance \u003d True"},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        # NOTE(tr3buchet): setup networks on destination host"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_e48233c8","line":4094,"updated":"2015-05-12 09:36:46.000000000","message":"the line 4130 also depend on \u0027resize_instance\u0027 to rollback the flavor info. So the fix at here looks wrong.","commit_id":"7298e9373288595c4f9a1eebcfb0ca19e8f41ffa"},{"author":{"_account_id":12929,"name":"Deliang Fan","email":"vanderliang@gmail.com","username":"DeliangFan"},"change_message_id":"5718e407676c342654edc7434cd6ce8782c0df24","unresolved":false,"context_lines":[{"line_number":4091,"context_line":"            instance_type \u003d instance.get_flavor(\u0027new\u0027)"},{"line_number":4092,"context_line":"            self._set_instance_info(instance, instance_type)"},{"line_number":4093,"context_line":"            for key in (\u0027root_gb\u0027, \u0027swap\u0027, \u0027ephemeral_gb\u0027):"},{"line_number":4094,"context_line":"                if old_instance_type[key] !\u003d instance_type[key]:"},{"line_number":4095,"context_line":"                    resize_instance \u003d True"},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        # NOTE(tr3buchet): setup networks on destination host"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_ffcbda1c","line":4094,"in_reply_to":"9a0c5dc1_e48233c8","updated":"2015-05-12 09:58:29.000000000","message":"Thank you very much! But I would rather replace 4130 with old_instance_type_id !\u003d new_instance_type_id. Because it would be ugly to get the flavor information in libvirt/driver.py.","commit_id":"7298e9373288595c4f9a1eebcfb0ca19e8f41ffa"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1f9870273c5ab2635bae371b38e0afbc95b5898a","unresolved":false,"context_lines":[{"line_number":4092,"context_line":"            self._set_instance_info(instance, instance_type)"},{"line_number":4093,"context_line":"            for key in (\u0027root_gb\u0027, \u0027swap\u0027, \u0027ephemeral_gb\u0027):"},{"line_number":4094,"context_line":"                if old_instance_type[key] !\u003d instance_type[key]:"},{"line_number":4095,"context_line":"                    resize_instance \u003d True"},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        # NOTE(tr3buchet): setup networks on destination host"},{"line_number":4098,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_3a27ceb7","line":4095,"updated":"2015-06-15 23:10:26.000000000","message":"I think there should be a break statement here, to bypass extra looping once you already know you need to resize","commit_id":"9470b8eb19e44a9e62bdba45e0c32dae33c1ec9d"},{"author":{"_account_id":12929,"name":"Deliang Fan","email":"vanderliang@gmail.com","username":"DeliangFan"},"change_message_id":"454eaeb12baec54b1dd6e23ad58dbc585b38fc78","unresolved":false,"context_lines":[{"line_number":4092,"context_line":"            self._set_instance_info(instance, instance_type)"},{"line_number":4093,"context_line":"            for key in (\u0027root_gb\u0027, \u0027swap\u0027, \u0027ephemeral_gb\u0027):"},{"line_number":4094,"context_line":"                if old_instance_type[key] !\u003d instance_type[key]:"},{"line_number":4095,"context_line":"                    resize_instance \u003d True"},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        # NOTE(tr3buchet): setup networks on destination host"},{"line_number":4098,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_662ffbf6","line":4095,"in_reply_to":"fa32b979_3a27ceb7","updated":"2015-06-16 01:29:41.000000000","message":"OK, break statement has been added, thank you very much!","commit_id":"9470b8eb19e44a9e62bdba45e0c32dae33c1ec9d"}]}