)]}'
{"nova/tests/unit/virt/libvirt/test_volume.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"40fb09cf783b3050e23aceb377531423ba11b716","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        libvirt_driver \u003d volume.LibvirtISCSIVolumeDriver(self.fake_conn)"},{"line_number":789,"context_line":"        with mock.patch.object(libvirt_driver,"},{"line_number":790,"context_line":"                               \u0027_delete_device\u0027) as _delete_device:"},{"line_number":791,"context_line":"            with mock.patch.object(libvirt_driver, \u0027_get_iscsi_devices\u0027,"},{"line_number":792,"context_line":"                                   return_value\u003dentries):"},{"line_number":793,"context_line":"                libvirt_driver._delete_mpath(iscsi_properties, None, ips_iqns)"},{"line_number":794,"context_line":"                expected_deletes \u003d [mock.call(\u0027/dev/disk/by-path/ip-192.168.1.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a0c5dc1_cd7f0665","line":791,"updated":"2015-05-13 18:14:55.000000000","message":"This could be cleaner - instead of nesting the mock context managers, use contextlib.nested (deprecated), built in support for multiple managers (since 2.7), or multiple @mock.patch.object decorators (preferred in my opinion).","commit_id":"0dd2cd59e0b16958e6ac26631ef51e3d02d6690e"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7faf213e89ed4fdd69a108417a83d05fdd3491b","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        libvirt_driver \u003d volume.LibvirtISCSIVolumeDriver(self.fake_conn)"},{"line_number":789,"context_line":"        with mock.patch.object(libvirt_driver,"},{"line_number":790,"context_line":"                               \u0027_delete_device\u0027) as _delete_device:"},{"line_number":791,"context_line":"            with mock.patch.object(libvirt_driver, \u0027_get_iscsi_devices\u0027,"},{"line_number":792,"context_line":"                                   return_value\u003dentries):"},{"line_number":793,"context_line":"                libvirt_driver._delete_mpath(iscsi_properties, None, ips_iqns)"},{"line_number":794,"context_line":"                expected_deletes \u003d [mock.call(\u0027/dev/disk/by-path/ip-192.168.1.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_15ee9eec","line":791,"in_reply_to":"9a0c5dc1_cd7f0665","updated":"2015-05-14 02:44:41.000000000","message":"Hmm, thanks for this hint. I will use the decorators in the next patch.","commit_id":"0dd2cd59e0b16958e6ac26631ef51e3d02d6690e"}]}
