)]}'
{"nova/compute/cells_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ff1e7fb8f7105f6befe4f73358f343f864414f8","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            # NOTE(danms): If we try to delete an instance with no cell,"},{"line_number":223,"context_line":"            # there isn\u0027t anything to salvage, so we can hard-delete here."},{"line_number":224,"context_line":"            try:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"                super(ComputeCellsAPI, self)._local_delete(context, instance,"},{"line_number":227,"context_line":"                                                           bdms, method_name,"},{"line_number":228,"context_line":"                                                           self._do_delete)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_54888322","line":225,"updated":"2015-05-14 15:06:02.000000000","message":"Is it just me, or do you have an extra blank line here?","commit_id":"19948d0171de380cc288fce2945296025854da5d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e76e9e4a82766b4f7ba59e6693bc6fd61e14fb3d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            # NOTE(danms): If we try to delete an instance with no cell,"},{"line_number":223,"context_line":"            # there isn\u0027t anything to salvage, so we can hard-delete here."},{"line_number":224,"context_line":"            try:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"                super(ComputeCellsAPI, self)._local_delete(context, instance,"},{"line_number":227,"context_line":"                                                           bdms, method_name,"},{"line_number":228,"context_line":"                                                           self._do_delete)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_6f0048ab","line":225,"in_reply_to":"7a016987_54888322","updated":"2015-05-14 15:22:14.000000000","message":"Yes(extra blank line).","commit_id":"19948d0171de380cc288fce2945296025854da5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a2d0d8aad7113907601095aece04ea478a42e34","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                # try again because we may have a cell name now."},{"line_number":233,"context_line":"                instance.refresh()"},{"line_number":234,"context_line":"                if instance.cell_name:"},{"line_number":235,"context_line":"                    self._handle_cell_delete(context, instance, method_name)"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_b46a1719","line":235,"updated":"2015-05-14 15:07:16.000000000","message":"Do you need an else here to raise the objectactionerror if instance.cell_name is still None?","commit_id":"19948d0171de380cc288fce2945296025854da5d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"245c0d16d2588adcdf92d14f56f2979021664e61","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                # try again because we may have a cell name now."},{"line_number":233,"context_line":"                instance.refresh()"},{"line_number":234,"context_line":"                if instance.cell_name:"},{"line_number":235,"context_line":"                    self._handle_cell_delete(context, instance, method_name)"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_14268b68","line":235,"updated":"2015-05-14 15:08:16.000000000","message":"if you don\u0027t retry the delete should we re-raise the initial exception?","commit_id":"19948d0171de380cc288fce2945296025854da5d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e76e9e4a82766b4f7ba59e6693bc6fd61e14fb3d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                # try again because we may have a cell name now."},{"line_number":233,"context_line":"                instance.refresh()"},{"line_number":234,"context_line":"                if instance.cell_name:"},{"line_number":235,"context_line":"                    self._handle_cell_delete(context, instance, method_name)"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        method \u003d getattr(super(ComputeCellsAPI, self), method_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_cf205c4c","line":235,"in_reply_to":"7a016987_b46a1719","updated":"2015-05-14 15:22:14.000000000","message":"And yes.","commit_id":"19948d0171de380cc288fce2945296025854da5d"}],"nova/tests/unit/compute/test_compute_cells.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"28befe2615e0a247f3e510c710e878ee17093a65","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            inst \u003d self._create_fake_instance_obj()"},{"line_number":157,"context_line":"            inst.cell_name \u003d None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"            inst.destroy \u003d mock.MagicMock()"},{"line_number":160,"context_line":"            inst.destroy.side_effect \u003d exception.ObjectActionError(action\u003d\u0027\u0027,"},{"line_number":161,"context_line":"                    reason\u003d\u0027\u0027)"},{"line_number":162,"context_line":"            inst.refresh \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_6a3156ec","line":159,"updated":"2015-05-14 15:37:15.000000000","message":"This is less heinous because it\u0027s not global, but I don\u0027t like this method of not allowing mock to do the thing. Would prefer just doing what you do below to get all the mocks patched in.","commit_id":"d34e0ce254e25d864fec4b19e618660972da6846"}]}