)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ce8d198f43d5babe3a95bd898430aeb1cd7c481e","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"            except Exception, e:"},{"line_number":1374,"context_line":"                LOG.debug(_(\u0027Could not parse filesystem type: %s\u0027), e)"},{"line_number":1375,"context_line":"        if not fs_type:"},{"line_number":1376,"context_line":"            fs_type \u003d _(\u0027default\u0027)"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        ephemeral_gb \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":1379,"context_line":"        if ephemeral_gb and not self._volume_in_mapping("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F%2BTA%3D","line":1376,"updated":"2012-12-18 10:30:16.000000000","message":"This is all a bit wierd - what you are calling \u0027fs_type\u0027 here is not a filesystem type, it is an operating system type (eg, \u0027windows\u0027, \u0027linux\u0027, etc) - as evidenced by the fact that you\u0027re initializing it from instances[\"os_type\"]. Trying to look at the default mkfs command name \u0026 extract filesystem type is not right - you want a default OS type, which matches that \u0027disk.mkfs\u0027 is using as its default. Also translating the string \u0027default\u0027 is wrong - this value is used as a hash lookup key, so should not be translated\n\nSo IMHO this entire block of code can be simplified to:\n\n os_type \u003d instance[\u0027os_type\u0027]\n if os_type is None\n    os_type \u003d \"default\"","commit_id":"3c78204075f2e46e67b4ba62bc11a835d42a3eb3"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"89ed84ff877b057f085a30e24d9c3e54b7c01677","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"            except Exception, e:"},{"line_number":1374,"context_line":"                LOG.debug(_(\u0027Could not parse filesystem type: %s\u0027), e)"},{"line_number":1375,"context_line":"        if not fs_type:"},{"line_number":1376,"context_line":"            fs_type \u003d _(\u0027default\u0027)"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        ephemeral_gb \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":1379,"context_line":"        if ephemeral_gb and not self._volume_in_mapping("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F%2BSo%3D","line":1376,"in_reply_to":"AAAAM3%2F%2F%2BTA%3D","updated":"2012-12-18 10:35:04.000000000","message":"Re-reading the code, you\u0027re right. I fix that.","commit_id":"3c78204075f2e46e67b4ba62bc11a835d42a3eb3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ce8d198f43d5babe3a95bd898430aeb1cd7c481e","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"            swap_device \u003d self.default_third_device"},{"line_number":1382,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":1383,"context_line":"                                   fs_label\u003d\u0027ephemeral0\u0027,"},{"line_number":1384,"context_line":"                                   os_type\u003dinstance[\"os_type\"])"},{"line_number":1385,"context_line":"            fname \u003d \"ephemeral_%s_%s\" % (ephemeral_gb, fs_type)"},{"line_number":1386,"context_line":"            size \u003d ephemeral_gb * 1024 * 1024 * 1024"},{"line_number":1387,"context_line":"            image(\u0027disk.local\u0027).cache(fetch_func\u003dfn,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F%2BS8%3D","line":1384,"updated":"2012-12-18 10:30:16.000000000","message":"And update this line to use the \u0027os_type\u0027 var, instead of instance[\"os_type\"]","commit_id":"3c78204075f2e46e67b4ba62bc11a835d42a3eb3"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"89ed84ff877b057f085a30e24d9c3e54b7c01677","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"            swap_device \u003d self.default_third_device"},{"line_number":1382,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":1383,"context_line":"                                   fs_label\u003d\u0027ephemeral0\u0027,"},{"line_number":1384,"context_line":"                                   os_type\u003dinstance[\"os_type\"])"},{"line_number":1385,"context_line":"            fname \u003d \"ephemeral_%s_%s\" % (ephemeral_gb, fs_type)"},{"line_number":1386,"context_line":"            size \u003d ephemeral_gb * 1024 * 1024 * 1024"},{"line_number":1387,"context_line":"            image(\u0027disk.local\u0027).cache(fetch_func\u003dfn,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F%2BSk%3D","line":1384,"in_reply_to":"AAAAM3%2F%2F%2BS8%3D","updated":"2012-12-18 10:35:04.000000000","message":"I don\u0027t think this is right though -- virt.disk.api.mkfs expects a non-existent key in its dictionary in order to use the default command.","commit_id":"3c78204075f2e46e67b4ba62bc11a835d42a3eb3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"5631eeab1b1462ece0a4506979aaecbd14a4a29c","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"            swap_device \u003d self.default_third_device"},{"line_number":1382,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":1383,"context_line":"                                   fs_label\u003d\u0027ephemeral0\u0027,"},{"line_number":1384,"context_line":"                                   os_type\u003dinstance[\"os_type\"])"},{"line_number":1385,"context_line":"            fname \u003d \"ephemeral_%s_%s\" % (ephemeral_gb, fs_type)"},{"line_number":1386,"context_line":"            size \u003d ephemeral_gb * 1024 * 1024 * 1024"},{"line_number":1387,"context_line":"            image(\u0027disk.local\u0027).cache(fetch_func\u003dfn,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F%2BSc%3D","line":1384,"in_reply_to":"AAAAM3%2F%2F%2BSk%3D","updated":"2012-12-18 10:37:27.000000000","message":"IIUC, it actually treats \u0027default\u0027 and None as equivalent, but yes, you can leave this suggested change out.","commit_id":"3c78204075f2e46e67b4ba62bc11a835d42a3eb3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"04219f912c680857ffcb43010d838f7b95a8f728","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"        # Lookup the filesystem type if required"},{"line_number":1366,"context_line":"        os_type_with_default \u003d instance[\u0027os_type\u0027]"},{"line_number":1367,"context_line":"        if not os_type_with_default:"},{"line_number":1368,"context_line":"            os_type_with_default \u003d _(\u0027default\u0027)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        ephemeral_gb \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":1371,"context_line":"        if ephemeral_gb and not self._volume_in_mapping("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F%2BRw%3D","line":1368,"updated":"2012-12-18 10:59:46.000000000","message":"Do we really need to translate this ?","commit_id":"eb3bd946d09d3298801af97411059d2c1e7a0695"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f20bdc5cbbbef7f6f00d0dff94f4a202db590cbd","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"        # Lookup the filesystem type if required"},{"line_number":1366,"context_line":"        os_type_with_default \u003d instance[\u0027os_type\u0027]"},{"line_number":1367,"context_line":"        if not os_type_with_default:"},{"line_number":1368,"context_line":"            os_type_with_default \u003d _(\u0027default\u0027)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        ephemeral_gb \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":1371,"context_line":"        if ephemeral_gb and not self._volume_in_mapping("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F%2BQc%3D","line":1368,"updated":"2012-12-18 12:29:54.000000000","message":"agree with Daniel, that seems like a very odd thing to translate, as it\u0027s actually part of a filename.","commit_id":"eb3bd946d09d3298801af97411059d2c1e7a0695"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"05757d60e9160e9952ab631a10964f9f9dab8949","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"        # Lookup the filesystem type if required"},{"line_number":1366,"context_line":"        os_type_with_default \u003d instance[\u0027os_type\u0027]"},{"line_number":1367,"context_line":"        if not os_type_with_default:"},{"line_number":1368,"context_line":"            os_type_with_default \u003d _(\u0027default\u0027)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        ephemeral_gb \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":1371,"context_line":"        if ephemeral_gb and not self._volume_in_mapping("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F9Us%3D","line":1368,"in_reply_to":"AAAAM3%2F%2F%2BQc%3D","updated":"2012-12-18 22:30:13.000000000","message":"I wasn\u0027t sure at the time to be honest. I\u0027ll change it.","commit_id":"eb3bd946d09d3298801af97411059d2c1e7a0695"}]}