)]}'
{"nova/api/openstack/compute/contrib/server_external_events.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"21b474d7807bd3d47658acdd230491201a1f54d5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            status \u003d client_event.get(\u0027status\u0027)"},{"line_number":59,"context_line":"            if status not in external_event_obj.EVENT_STATUSES:"},{"line_number":60,"context_line":"                raise webob.exc.HTTPBadRequest("},{"line_number":61,"context_line":"                    _(\u0027Invalid event status `%s\\\u0027\u0027) % status)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            try:"},{"line_number":64,"context_line":"                event.instance_uuid \u003d client_event.pop(\u0027server_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_486fdf92","line":61,"updated":"2015-06-01 15:59:39.000000000","message":"seems we don\u0027t have this change on v3 API?","commit_id":"10b4c1362c17b8d72c7f99f77b9b80af2ac5b4de"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1e7e0512716ab2ef2a5ab90e723f3f1ddf9d96a6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            status \u003d client_event.get(\u0027status\u0027)"},{"line_number":59,"context_line":"            if status not in external_event_obj.EVENT_STATUSES:"},{"line_number":60,"context_line":"                raise webob.exc.HTTPBadRequest("},{"line_number":61,"context_line":"                    _(\u0027Invalid event status `%s\\\u0027\u0027) % status)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            try:"},{"line_number":64,"context_line":"                event.instance_uuid \u003d client_event.pop(\u0027server_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_081d67bd","line":61,"in_reply_to":"5afe65bd_486fdf92","updated":"2015-06-01 16:08:56.000000000","message":"We don\u0027t have the older code on v3 either. I think it\u0027s because we automatically get the 400 when we fail to set the invalid status on the object. See the v3 code -- it doesn\u0027t do the attribute assignments inside a try block like the v2 code does.","commit_id":"10b4c1362c17b8d72c7f99f77b9b80af2ac5b4de"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"28260d4ffb1f5a601793ca14dd68e03b11c59a13","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            status \u003d client_event.get(\u0027status\u0027)"},{"line_number":59,"context_line":"            if status not in external_event_obj.EVENT_STATUSES:"},{"line_number":60,"context_line":"                raise webob.exc.HTTPBadRequest("},{"line_number":61,"context_line":"                    _(\u0027Invalid event status `%s\\\u0027\u0027) % status)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            try:"},{"line_number":64,"context_line":"                event.instance_uuid \u003d client_event.pop(\u0027server_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_88eb97b0","line":61,"in_reply_to":"5afe65bd_486fdf92","updated":"2015-06-01 16:05:55.000000000","message":"forget it , schema handle this","commit_id":"10b4c1362c17b8d72c7f99f77b9b80af2ac5b4de"}]}
