)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b2eed1634d5afce13c5168b0ee3284be8ec027c6","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                   exception.MigrationPreCheckError,"},{"line_number":505,"context_line":"                                   exception.LiveMigrationWithOldNovaNotSafe,"},{"line_number":506,"context_line":"                                   exception.UnsupportedPolicyException)"},{"line_number":507,"context_line":"    def migrate_server(self, context, instance, scheduler_hint, live, flavor,"},{"line_number":508,"context_line":"                       block_migration, disk_over_commit, reservations\u003dNone,"},{"line_number":509,"context_line":"                       clean_shutdown\u003dTrue):"},{"line_number":510,"context_line":"        if instance and not isinstance(instance, nova_object.NovaObject):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_45beef65","line":507,"updated":"2015-05-21 10:14:32.000000000","message":"This will break older clients so will have to wait until the next major version bump. I suggest you instead add a comment explaining that the parameter is unused and should be removed at that time.","commit_id":"fdf858db39d301a4205e563946f0af5e72ae87fd"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f8e98d41c5f845d5811620ce827da13aa9c6d164","unresolved":false,"context_lines":[{"line_number":308,"context_line":"              \u0027disk_over_commit\u0027: disk_over_commit,"},{"line_number":309,"context_line":"              \u0027reservations\u0027: reservations,"},{"line_number":310,"context_line":"              \u0027clean_shutdown\u0027: clean_shutdown}"},{"line_number":311,"context_line":"        version \u003d \u00271.11\u0027"},{"line_number":312,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":313,"context_line":"            del kw[\u0027clean_shutdown\u0027]"},{"line_number":314,"context_line":"            version \u003d \u00271.10\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_277a05be","line":311,"updated":"2015-05-19 15:50:32.000000000","message":"should this be updated as well? you changed the param list","commit_id":"b7f8bbc70167b39d388e395166c15800cc867267"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b2eed1634d5afce13c5168b0ee3284be8ec027c6","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                  flavor, block_migration, disk_over_commit,"},{"line_number":304,"context_line":"                  reservations\u003dNone, clean_shutdown\u003dTrue):"},{"line_number":305,"context_line":"        kw \u003d {\u0027instance\u0027: instance, \u0027scheduler_hint\u0027: scheduler_hint,"},{"line_number":306,"context_line":"              \u0027live\u0027: live, \u0027rebuild\u0027: rebuild, \u0027flavor\u0027: flavor,"},{"line_number":307,"context_line":"              \u0027block_migration\u0027: block_migration,"},{"line_number":308,"context_line":"              \u0027disk_over_commit\u0027: disk_over_commit,"},{"line_number":309,"context_line":"              \u0027reservations\u0027: reservations,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_053917f2","side":"PARENT","line":306,"updated":"2015-05-21 10:14:32.000000000","message":"Must keep sending this parameter until we bump the rpc major version. Maybe just hardcode to False for now since that is what it used to be anyway.\n\nThis change doesn\u0027t need a new version since the signature doesn\u0027t change.","commit_id":"c13f693d496f4ea5dbc78244fefd9ec2d6ea8de5"}]}