)]}'
{"id":"openstack%2Fnova~18440","triplet_id":"openstack%2Fnova~master~I23a85c48474126743c5d02f642baf6047358aae8","project":"openstack/nova","branch":"master","topic":"bp/db-session-cleanup","hashtags":[],"change_id":"I23a85c48474126743c5d02f642baf6047358aae8","subject":"Using query.soft_delete() method insead of soft deleting by hand","status":"MERGED","created":"2012-12-19 22:51:26.000000000","updated":"2012-12-22 01:06:47.000000000","submitted":"2012-12-22 01:06:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6d3f3bbce2928fb68496eecb94d54a527141615d","_number":18440,"virtual_id_number":18440,"owner":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2012-12-21 22:49:24.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2012-12-22 01:06:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-12-21 22:27:46.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2012-12-22 00:43:48.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2012-12-22 00:43:48.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-19 23:17:08.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2012-12-21 19:51:02.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2012-12-21 22:27:46.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-12-21 22:49:24.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-12-22 00:43:48.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-12-22 01:06:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e734c355d05816aefd7a15c9c4ccc154184624d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-19 23:15:39.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18440/1/check/gate-nova-docs/10129 : SUCCESS\n- http://logs.openstack.org/18440/1/check/gate-nova-pep8/15439 : SUCCESS\n- http://logs.openstack.org/18440/1/check/gate-nova-python26/11577 : SUCCESS\n- http://logs.openstack.org/18440/1/check/gate-nova-python27/11649 : SUCCESS\n- http://logs.openstack.org/18440/1/check/gate-tempest-devstack-vm/23109 : SUCCESS\n- http://logs.openstack.org/18440/1/check/gate-nova-pylint/4676 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"855b21781eab4ee4e3b246e0cc9be0533b9bae91","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-20 01:27:51.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/56388\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/56386\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/56387\n","accounts_in_message":[],"_revision_number":1},{"id":"26c21c8d2b1ea852a663c22fda068686ffd0f5cf","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2012-12-21 13:30:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1bdbfe3a6b798c8d7e62d462892a98f0909d7e7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-21 13:57:17.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18440/2/check/gate-nova-docs/10289 : SUCCESS\n- http://logs.openstack.org/18440/2/check/gate-nova-pep8/15599 : SUCCESS\n- http://logs.openstack.org/18440/2/check/gate-nova-python26/11737 : SUCCESS\n- http://logs.openstack.org/18440/2/check/gate-nova-python27/11809 : SUCCESS\n- http://logs.openstack.org/18440/2/check/gate-tempest-devstack-vm/23362 : SUCCESS\n- http://logs.openstack.org/18440/2/check/gate-nova-pylint/4790 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"49ac2bacd89dbcc2cd1e069ef14b1178f96c63f9","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-21 14:19:13.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nSmokeStack Results (patch set 2):\n\tUnit Failed:Nova tests failed.  http://smokestack.openstack.org/?go\u003d/jobs/56858\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/56856\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/56857\n","accounts_in_message":[],"_revision_number":2},{"id":"afe81c9358c99b37d4ed19405e9fe596ab2659f4","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2012-12-21 18:09:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5c441f1dd8f5443929de90820a8f8b30a7aeeafd","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-21 18:31:58.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/56897\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/56895\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/56896\n","accounts_in_message":[],"_revision_number":3},{"id":"095770fade450c712148ca0f4f57a781089067f5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-21 18:34:47.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18440/3/check/gate-nova-docs/10301 : SUCCESS\n- http://logs.openstack.org/18440/3/check/gate-nova-pep8/15611 : SUCCESS\n- http://logs.openstack.org/18440/3/check/gate-nova-python26/11749 : SUCCESS\n- http://logs.openstack.org/18440/3/check/gate-nova-python27/11821 : SUCCESS\n- http://logs.openstack.org/18440/3/check/gate-tempest-devstack-vm/23390 : SUCCESS\n- http://logs.openstack.org/18440/3/check/gate-nova-pylint/4799 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"2a98fc34879c106cc430ebdc32dc3f1f8f2de197","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-12-21 19:47:49.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7188a897a76086932fe733e5a5036089abe1f624","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-12-21 19:51:02.000000000","message":"Patch Set 3:\n\nLGTM, pending fix to dependent patch.","accounts_in_message":[],"_revision_number":3},{"id":"9c2ab1e2b79d883f015bdb05eeb1c657c16bde2c","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2012-12-21 22:27:17.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ac7f47a8fcdd9fcfadd6c5ac3613b0998ebc7e1e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-12-21 22:27:46.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":4},{"id":"c58242c52c112b84f858f4fdd2210c6e7bf23f7b","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-21 22:49:24.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/56972\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/56970\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/56971\n","accounts_in_message":[],"_revision_number":4},{"id":"5c2a6dc8c7af94f7d62d51cd44bc12d46b50322e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-21 22:57:58.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18440/4/check/gate-nova-docs/10309 : SUCCESS\n- http://logs.openstack.org/18440/4/check/gate-nova-pep8/15619 : SUCCESS\n- http://logs.openstack.org/18440/4/check/gate-nova-python26/11757 : SUCCESS\n- http://logs.openstack.org/18440/4/check/gate-nova-python27/11829 : SUCCESS\n- http://logs.openstack.org/18440/4/check/gate-tempest-devstack-vm/23420 : SUCCESS\n- http://logs.openstack.org/18440/4/check/gate-nova-pylint/4806 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"0aa22ad3b7676359ec5dcf5410c7b311151e8aa0","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-12-22 00:43:48.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"74af80b1094b31d59e0412a69996ecfc8a4e488d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-22 00:43:50.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://zuul.openstack.org/","accounts_in_message":[],"_revision_number":4},{"id":"ec7b16edc2b356c98385534ea0962a15f2e8dde1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-22 01:06:45.000000000","message":"Patch Set 4: Verified\n\nBuild successful\n\n- http://logs.openstack.org/18440/4/gate/gate-nova-docs/10314 : SUCCESS\n- http://logs.openstack.org/18440/4/gate/gate-nova-pep8/15624 : SUCCESS\n- http://logs.openstack.org/18440/4/gate/gate-nova-python26/11762 : SUCCESS\n- http://logs.openstack.org/18440/4/gate/gate-nova-python27/11834 : SUCCESS\n- http://logs.openstack.org/18440/4/gate/gate-tempest-devstack-vm/23428 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"088ade78adba7c1713fccc2d2ee04a40ea81c848","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-22 01:06:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6d38a6145e4ded084d72714549d7f9b613c6936c","revisions":{"9593546a8f22d32a6b9e4c543f4e3c0ee55c464c":{"kind":"REWORK","_number":1,"created":"2012-12-19 22:51:26.000000000","uploader":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"ref":"refs/changes/40/18440/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/18440/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/18440/1"}}},"commit":{"parents":[{"commit":"96478441300a9c4795c9f6ae941b59946b2f32af","subject":"Add soft_delete() method in sqlalchemy.orm.query.Query class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/96478441300a9c4795c9f6ae941b59946b2f32af"}]}],"author":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-19 11:06:17.000000000","tz":240},"committer":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-19 22:46:46.000000000","tz":240},"subject":"Using query.soft_delete() method insead of soft deleting by hand","message":"Using query.soft_delete() method insead of soft deleting by hand\n\nChange all occurences of:\n\tquery.update({\n\t\tdeleted:True,\n\t\t\u0027deleted_at\u0027: timeutils.utcnow(),\n                \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})\nto:\n\tquery.soft_delete()\n\nMake instance_type_access_remove() with 2 db requests instead of 3\n\nMake agent_build_destroy() with 1 db request instead of 2\n\nFix bug in aggregate_delete() added missing transaction\nmake it with 2 db requests instead of 3\n\nMake aggregate_metadata_delete() with 1 db request instead of 2\n\nMake aggregate_host_delete() with 1 db request instead of 2\n\nblueprint db-session-cleanup\n\nChange-Id: I23a85c48474126743c5d02f642baf6047358aae8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9593546a8f22d32a6b9e4c543f4e3c0ee55c464c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9593546a8f22d32a6b9e4c543f4e3c0ee55c464c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"96478441300a9c4795c9f6ae941b59946b2f32af","is_merged_in_target_branch":false,"change_id":"I6059982b83648133b6d8becf94ad8980b056c6ff","change_number":18439,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"1f84a041dfa7e12258558a181d10f7550668f95c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2012-12-21 13:30:09.000000000","uploader":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"ref":"refs/changes/40/18440/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/18440/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/18440/2"}}},"commit":{"parents":[{"commit":"af42527da208287ad25306c23c4bf368b7e1f18d","subject":"Add soft_delete() method in sqlalchemy.orm.query.Query class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/af42527da208287ad25306c23c4bf368b7e1f18d"}]}],"author":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-19 11:06:17.000000000","tz":240},"committer":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-21 13:26:12.000000000","tz":240},"subject":"Using query.soft_delete() method insead of soft deleting by hand","message":"Using query.soft_delete() method insead of soft deleting by hand\n\nChange all occurences of:\n\tquery.update({\n\t\tdeleted:True,\n\t\t\u0027deleted_at\u0027: timeutils.utcnow(),\n                \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})\nto:\n\tquery.soft_delete()\n\nMake instance_type_access_remove() with 2 db requests instead of 3\n\nMake agent_build_destroy() with 1 db request instead of 2\n\nFix bug in aggregate_delete() added missing transaction\nmake it with 2 db requests instead of 3\n\nMake aggregate_metadata_delete() with 1 db request instead of 2\n\nMake aggregate_host_delete() with 1 db request instead of 2\n\nblueprint db-session-cleanup\n\nChange-Id: I23a85c48474126743c5d02f642baf6047358aae8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1f84a041dfa7e12258558a181d10f7550668f95c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1f84a041dfa7e12258558a181d10f7550668f95c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"af42527da208287ad25306c23c4bf368b7e1f18d","is_merged_in_target_branch":false,"change_id":"I6059982b83648133b6d8becf94ad8980b056c6ff","change_number":18439,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"067259c8cbc5033817ceae2c5d97f94935421dfe":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2012-12-21 18:09:21.000000000","uploader":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"ref":"refs/changes/40/18440/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/18440/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/18440/3"}}},"commit":{"parents":[{"commit":"26bafae8779c050df7066b4c6bdbe494b78768f0","subject":"Add soft_delete() method in sqlalchemy.orm.query.Query class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/26bafae8779c050df7066b4c6bdbe494b78768f0"}]}],"author":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-19 11:06:17.000000000","tz":240},"committer":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-21 18:05:20.000000000","tz":240},"subject":"Using query.soft_delete() method insead of soft deleting by hand","message":"Using query.soft_delete() method insead of soft deleting by hand\n\nChange all occurences of:\n\tquery.update({\n\t\tdeleted:True,\n\t\t\u0027deleted_at\u0027: timeutils.utcnow(),\n                \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})\nto:\n\tquery.soft_delete()\n\nMake instance_type_access_remove() with 2 db requests instead of 3\n\nMake agent_build_destroy() with 1 db request instead of 2\n\nFix bug in aggregate_delete() added missing transaction\nmake it with 2 db requests instead of 3\n\nMake aggregate_metadata_delete() with 1 db request instead of 2\n\nMake aggregate_host_delete() with 1 db request instead of 2\n\nblueprint db-session-cleanup\n\nChange-Id: I23a85c48474126743c5d02f642baf6047358aae8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/067259c8cbc5033817ceae2c5d97f94935421dfe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/067259c8cbc5033817ceae2c5d97f94935421dfe"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"26bafae8779c050df7066b4c6bdbe494b78768f0","is_merged_in_target_branch":false,"change_id":"I6059982b83648133b6d8becf94ad8980b056c6ff","change_number":18439,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"6d38a6145e4ded084d72714549d7f9b613c6936c":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2012-12-21 22:27:17.000000000","uploader":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"ref":"refs/changes/40/18440/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/18440/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/18440/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/18440/4"}}},"commit":{"parents":[{"commit":"eda851676d14956c03616e5b2cb856acdc8edbef","subject":"Create and use subclass of sqlalchemy Query with soft_delete() method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eda851676d14956c03616e5b2cb856acdc8edbef"}]}],"author":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-19 11:06:17.000000000","tz":240},"committer":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2012-12-21 22:12:54.000000000","tz":240},"subject":"Using query.soft_delete() method insead of soft deleting by hand","message":"Using query.soft_delete() method insead of soft deleting by hand\n\nChange all occurences of:\n\tquery.update({\n\t\tdeleted:True,\n\t\t\u0027deleted_at\u0027: timeutils.utcnow(),\n                \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})\nto:\n\tquery.soft_delete()\n\nMake instance_type_access_remove() with 2 db requests instead of 3\n\nMake agent_build_destroy() with 1 db request instead of 2\n\nFix bug in aggregate_delete() added missing transaction\nmake it with 2 db requests instead of 3\n\nMake aggregate_metadata_delete() with 1 db request instead of 2\n\nMake aggregate_host_delete() with 1 db request instead of 2\n\nblueprint db-session-cleanup\n\nChange-Id: I23a85c48474126743c5d02f642baf6047358aae8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6d38a6145e4ded084d72714549d7f9b613c6936c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6d38a6145e4ded084d72714549d7f9b613c6936c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"eda851676d14956c03616e5b2cb856acdc8edbef","is_merged_in_target_branch":true,"change_id":"I6059982b83648133b6d8becf94ad8980b056c6ff","change_number":18439,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}