)]}'
{"nova/tests/api/openstack/compute/test_server_actions.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"5fbeeb334b4d776074e2e419e41cede95f7008a9","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                          self.controller._action_resize,"},{"line_number":574,"context_line":"                          req, FAKE_UUID, body)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def test_resize_not_found(self):"},{"line_number":577,"context_line":"        body \u003d dict(resize\u003ddict(flavorRef\u003d\"http://localhost/3\"))"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        def fake_get(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F7W4%3D","line":576,"updated":"2012-12-20 11:34:40.000000000","message":"suggestion only: test_resize_with_invalid_server or test_resize_with_server_not_found","commit_id":"82107ff7d8851e7f6d291212c820a75ff37ac828"},{"author":{"_account_id":5240,"name":"Ethan Chu","email":"xychu2008@gmail.com","username":"xychu2008"},"change_message_id":"dc6a3da60f679a0fdef0b918600281add077c73d","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                          self.controller._action_resize,"},{"line_number":574,"context_line":"                          req, FAKE_UUID, body)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def test_resize_not_found(self):"},{"line_number":577,"context_line":"        body \u003d dict(resize\u003ddict(flavorRef\u003d\"http://localhost/3\"))"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        def fake_get(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F6hU%3D","line":576,"in_reply_to":"AAAAM3%2F%2F7W4%3D","updated":"2012-12-21 02:23:37.000000000","message":"Done","commit_id":"82107ff7d8851e7f6d291212c820a75ff37ac828"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"5fbeeb334b4d776074e2e419e41cede95f7008a9","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        def fake_get(self, context, instance_id):"},{"line_number":580,"context_line":"            raise exception.NotFound"},{"line_number":581,"context_line":"        self.stubs.Set(compute_api.API, \u0027get\u0027, fake_get)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.url)"},{"line_number":584,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":585,"context_line":"                          self.controller._action_resize,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F7Wo%3D","line":582,"updated":"2012-12-20 11:34:40.000000000","message":"No need to create this fake_get, there is a function: return_server_not_found in L43 to this \u003d)... so just stub it here instead of fake_get","commit_id":"82107ff7d8851e7f6d291212c820a75ff37ac828"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3b0c0300014ecbf85b1ed68b9d7e92bb5e35da04","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        def fake_get(self, context, instance_id):"},{"line_number":580,"context_line":"            raise exception.NotFound"},{"line_number":581,"context_line":"        self.stubs.Set(compute_api.API, \u0027get\u0027, fake_get)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.url)"},{"line_number":584,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":585,"context_line":"                          self.controller._action_resize,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F2lc%3D","line":582,"in_reply_to":"AAAAM3%2F%2F6hI%3D","updated":"2013-01-02 11:58:14.000000000","message":"Sorry for take so long  to answer, I didn\u0027t see this before.\n\nSo you don\u0027t need to use it to stubout to db, your fake_get and the  return_server_not_found have the same parameters, \u0027context\u0027 and \u0027id\u0027 and the same action (return exception.NotFound) so just stub it as you did:\nself.stubs.Set(compute_api.API, \u0027get\u0027, return_server_not_found)","commit_id":"82107ff7d8851e7f6d291212c820a75ff37ac828"},{"author":{"_account_id":5240,"name":"Ethan Chu","email":"xychu2008@gmail.com","username":"xychu2008"},"change_message_id":"dc6a3da60f679a0fdef0b918600281add077c73d","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        def fake_get(self, context, instance_id):"},{"line_number":580,"context_line":"            raise exception.NotFound"},{"line_number":581,"context_line":"        self.stubs.Set(compute_api.API, \u0027get\u0027, fake_get)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.url)"},{"line_number":584,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":585,"context_line":"                          self.controller._action_resize,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F6hI%3D","line":582,"in_reply_to":"AAAAM3%2F%2F7Wo%3D","updated":"2012-12-21 02:23:37.000000000","message":"I did saw that func in L43, and the reason I did not use it is that I think stubout to db maybe a little deeper for a fake function.\nAm I right?","commit_id":"82107ff7d8851e7f6d291212c820a75ff37ac828"}]}
