)]}'
{"id":"openstack%2Fnova~18476","triplet_id":"openstack%2Fnova~master~Ia73050c5313b3524dd1d341528cc5f916e603c64","project":"openstack/nova","branch":"master","topic":"md-test-improve","hashtags":[],"change_id":"Ia73050c5313b3524dd1d341528cc5f916e603c64","subject":"minor improvements to nova/tests/test_metadata.py","status":"MERGED","created":"2012-12-20 13:51:24.000000000","updated":"2013-01-15 19:53:21.000000000","submitted":"2013-01-15 19:53:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"418d6d77e663ce7fe5dab8c1eddeac100d711450","_number":18476,"virtual_id_number":18476,"owner":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2013-01-15 19:53:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":2,"date":"2013-01-15 18:38:25.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"date":"2013-01-15 18:37:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-01-15 18:59:25.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"date":"2013-01-15 18:38:25.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-01-15 18:59:25.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-21 00:16:44.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2013-01-09 15:47:13.000000000","updated_by":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"reviewer":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"state":"REVIEWER"},{"updated":"2013-01-09 15:54:20.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-01-11 03:48:24.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-01-11 05:38:27.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-01-15 18:38:25.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2013-01-15 18:59:25.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-01-15 19:53:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"676bf5fb28d175172869250335e3459410c2d5d0","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-20 14:13:57.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/56562\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/56560\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/56561\n","accounts_in_message":[],"_revision_number":1},{"id":"d8f995f628f6dba344e0001b343f09e5a90ea484","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-20 15:12:57.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18476/1/check/gate-nova-docs/10184 : SUCCESS\n- http://logs.openstack.org/18476/1/check/gate-nova-pep8/15494 : SUCCESS\n- http://logs.openstack.org/18476/1/check/gate-nova-python26/11632 : SUCCESS\n- http://logs.openstack.org/18476/1/check/gate-nova-python27/11704 : SUCCESS\n- http://logs.openstack.org/18476/1/check/gate-tempest-devstack-vm/23188 : SUCCESS\n- http://logs.openstack.org/18476/1/check/gate-nova-pylint/4719 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"d1a7edb03fec0f8b2c54ee589164a34304e59597","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2012-12-21 00:16:44.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4d14291a9942018f838dc61d7d9fb2d8362fade7","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-12-21 04:21:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a46e5511c23de5262615d8bb8a17793280b1f8f8","author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"date":"2012-12-21 12:19:05.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"14618a3fabd8e007dfdce7abf8dabdbdd787cae2","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-12-21 22:29:07.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4b1f677db88dba3d5468e610c8bf0b395ebb35c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-21 22:29:08.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://zuul.openstack.org/","accounts_in_message":[],"_revision_number":1},{"id":"82daa58dbc12436ac53f13dbec46bd5aff410ecd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-21 22:29:13.000000000","message":"Patch Set 1: Fails\n\nBuild failed\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"f9bd2a4ad7ea1dbc7b9c8a3e7f62437867e7b4e0","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-01-09 06:03:03.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"7dda261933038b68a3afb02a5049803af848ea73","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-01-09 06:03:03.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"9005bb4db3e1a379fb9798dcf81f92209550cfbc","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2013-01-09 13:51:48.000000000","message":"Patch Set 1: Restored\n\nrestoring and rebasing","accounts_in_message":[],"_revision_number":1},{"id":"60605ca25f36d27ff07dba724c43ba50d7120b2f","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2013-01-09 13:52:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"da54c5156def8dcb2cff879cc2c027e5e04b7c16","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-09 14:21:45.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18476/2/check/gate-nova-docs/11570 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-pep8/16880 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python26/13039 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python27/13090 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-tempest-devstack-vm/25411 : FAILURE\n- http://logs.openstack.org/18476/2/check/gate-devstack-vm-quantum/2034 : SUCCESS (non-voting)\n- http://logs.openstack.org/18476/2/check/gate-nova-pylint/5768 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"3da9c6f3e07658cc3177a76dda66d325e8d095ae","author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"date":"2013-01-09 15:47:13.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"102b28b4091ad9cfc6b4a075329987365ed5ecd8","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-09 15:54:20.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/61429\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/61427\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/61428\n","accounts_in_message":[],"_revision_number":2},{"id":"862943366181c0785003792b01ad0591b47b73ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-09 16:17:02.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- http://logs.openstack.org/18476/2/check/gate-nova-docs/11602 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-pep8/16910 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python26/13071 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python27/13122 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-tempest-devstack-vm/25455 : FAILURE\n- http://logs.openstack.org/18476/2/check/gate-devstack-vm-quantum/2082 : SUCCESS (non-voting)\n- http://logs.openstack.org/18476/2/check/gate-nova-pylint/5782 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"73601cedc9c046c26ec31dcf1475e07273bf8c03","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2013-01-10 20:02:47.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"bcf803154ad352ecb11c2ae374fe26768b741695","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 20:34:30.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- http://logs.openstack.org/18476/2/check/gate-nova-docs/11887 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-pep8/17193 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python26/13355 : FAILURE\n- http://logs.openstack.org/18476/2/check/gate-nova-python27/13402 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-tempest-devstack-vm/25912 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-devstack-vm-quantum/2559 : SUCCESS (non-voting)\n- http://logs.openstack.org/18476/2/check/gate-nova-pylint/5923 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"915da7d35b31fd064572934a6be56f6c1673033f","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-01-11 03:48:24.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"0dd1a186f2dae860bded34d9a23d9c48e9e34a75","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-11 04:23:41.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18476/2/check/gate-nova-docs/11934 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-pep8/17240 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python26/13402 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-nova-python27/13449 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-tempest-devstack-vm/26022 : SUCCESS\n- http://logs.openstack.org/18476/2/check/gate-devstack-vm-quantum/2688 : SUCCESS (non-voting)\n- http://logs.openstack.org/18476/2/check/gate-nova-pylint/5959 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"35a260327e770d6cd347e5ec1cdbdd4742922146","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-01-11 05:38:27.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fe82c0c78b1f04f95dca564923b32d4d4074f514","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2013-01-15 18:06:11.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI\u0027m confused by b) in the commit message. Specifically \"For reference, current keys are:\n       files uuid availability_zone hostname meta public_keys name\".\n\nOur documentation would seem to suggest otherwise:\n\nhttp://docs.openstack.org/folsom/openstack-compute/admin/content/metadata-service.html\n\nNote this example:\n\n$ curl http://169.254.169.254/2009-04-04/meta-data/public-keys/\n0\u003dmykey\n\n---\n\nAlso, the docs from EC2 seem to show dashes are the preferred way the EC2 metadata keys are accessed:\n\nhttp://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AESDG-chapter-instancedata.html","accounts_in_message":[],"_revision_number":2},{"id":"65df5c66a5df8ccca8ffbd10d4f414698ec4bc1a","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2013-01-15 18:21:53.000000000","message":"Patch Set 2:\n\nDan,\n  The changes here are with regard to the openstack metadata, not the EC2 metadata.\n  Openstack metadata is rooted at http://169.254.169.254/openstack/.\n  Look for \"OpenStack metadata API\" in the link you posted.","accounts_in_message":[],"_revision_number":2},{"id":"901e290690fdd1c3e36b84450b0a98c36f2b81e4","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2013-01-15 18:30:03.000000000","message":"Patch Set 2: No score\n\nScott: Thanks for the clarification.\n\nI suppose it might be nice to make that a bit more clear in your commit message then too right? Especially since we have both EC2 and OpenStack tests in test_metadata.py right?","accounts_in_message":[],"_revision_number":2},{"id":"dc41fd83ec5718e2cad8adc50ae2702c7f0564a2","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2013-01-15 18:35:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"916aed30126cc1644dec17422a87328d7b1b3bb0","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-01-15 18:36:11.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"7e4c6a2076eab764166215904700f9565daea698","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2013-01-15 18:37:06.000000000","message":"Patch Set 3:\n\ngah!\n i thought there was something that noticed \"trivial changes\" and re-applied existing reviews.  Hopefully someone will +1 this again.","accounts_in_message":[],"_revision_number":3},{"id":"1782c37f20d925d034a9024427ef01908182a4df","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2013-01-15 18:38:25.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"01f692ba123a59a2c40d4a27e3351a9a84921623","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-15 18:59:25.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"3ca13eabf0dbcc84e8375c786517d04e29644ddb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-15 18:59:27.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"118236665d73b04eaf2d4f422a11111df802d72c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-15 19:20:26.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/18476/3/check/gate-nova-docs/12405 : SUCCESS\n- http://logs.openstack.org/18476/3/check/gate-nova-pep8/17711 : SUCCESS\n- http://logs.openstack.org/18476/3/check/gate-nova-python26/13870 : SUCCESS\n- http://logs.openstack.org/18476/3/check/gate-nova-python27/13919 : SUCCESS\n- http://logs.openstack.org/18476/3/check/gate-tempest-devstack-vm/26816 : SUCCESS\n- http://logs.openstack.org/18476/3/check/gate-devstack-vm-quantum/3682 : SUCCESS (non-voting)\n- http://logs.openstack.org/18476/3/check/gate-nova-pylint/6340 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"f0a88b6faf80031d4c10fb127579d3dd3205b8d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-15 19:53:17.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/18476/3/gate/gate-nova-docs/12406 : SUCCESS\n- http://logs.openstack.org/18476/3/gate/gate-nova-pep8/17712 : SUCCESS\n- http://logs.openstack.org/18476/3/gate/gate-nova-python26/13871 : SUCCESS\n- http://logs.openstack.org/18476/3/gate/gate-nova-python27/13920 : SUCCESS\n- http://logs.openstack.org/18476/3/gate/gate-tempest-devstack-vm/26825 : SUCCESS\n- http://logs.openstack.org/18476/3/gate/gate-devstack-vm-quantum/3692 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"1a042f425883e382028daddb3113e34b602ff5ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-15 19:53:21.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a0ae2e2fa0ba3c52f8eed4bbb97c5de20c2106cb","revisions":{"c731beb0743ed0c571572d5a85b2f6cb7b8eb5d8":{"kind":"REWORK","_number":1,"created":"2012-12-20 13:51:24.000000000","uploader":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"ref":"refs/changes/76/18476/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/18476/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/18476/1"}}},"commit":{"parents":[{"commit":"3c35fdab55a4cd9d5854c691a29275cdba0cfcd5","subject":"Merge \"address uuid overwriting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c35fdab55a4cd9d5854c691a29275cdba0cfcd5"}]}],"author":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2012-12-20 13:47:21.000000000","tz":-300},"committer":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2012-12-20 13:47:21.000000000","tz":-300},"subject":"minor improvements to nova/tests/test_metadata.py","message":"minor improvements to nova/tests/test_metadata.py\n\nThere are 2 changes here:\n a.) previously we checked for existance of \u0027user-data\u0027 in\n     a response, when it clearly would not have been there as\n     the key name is \u0027user_data\u0027.\n b.) Insist that top level keys in the metadata do not have \u0027-\u0027\n     This is just a consistency thing.  Its very easy for someone to\n     unintentionally add a key named \u0027my-field\u0027.  We want to enforce\n     keys to be named consistently using \u0027_\u0027 rather than -.\n     For reference, current keys are:\n       files uuid availability_zone hostname meta public_keys name\n\nChange-Id: Ia73050c5313b3524dd1d341528cc5f916e603c64\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c731beb0743ed0c571572d5a85b2f6cb7b8eb5d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c731beb0743ed0c571572d5a85b2f6cb7b8eb5d8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3c35fdab55a4cd9d5854c691a29275cdba0cfcd5","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"50e01dfb0ee1996756949897d51291bf043a1277":{"kind":"REWORK","_number":2,"created":"2013-01-09 13:52:04.000000000","uploader":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"ref":"refs/changes/76/18476/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/18476/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/18476/2"}}},"commit":{"parents":[{"commit":"1db4b13d86d748d9619ea9ce37bb4663285468b5","subject":"Move common virt driver options to virt.driver","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1db4b13d86d748d9619ea9ce37bb4663285468b5"}]}],"author":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2012-12-20 13:47:21.000000000","tz":-300},"committer":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2013-01-09 13:49:42.000000000","tz":-300},"subject":"minor improvements to nova/tests/test_metadata.py","message":"minor improvements to nova/tests/test_metadata.py\n\nThere are 2 changes here:\n a.) previously we checked for existance of \u0027user-data\u0027 in\n     a response, when it clearly would not have been there as\n     the key name is \u0027user_data\u0027.\n b.) Insist that top level keys in the metadata do not have \u0027-\u0027\n     This is just a consistency thing.  Its very easy for someone to\n     unintentionally add a key named \u0027my-field\u0027.  We want to enforce\n     keys to be named consistently using \u0027_\u0027 rather than -.\n     For reference, current keys are:\n       files uuid availability_zone hostname meta public_keys name\n\nChange-Id: Ia73050c5313b3524dd1d341528cc5f916e603c64\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/50e01dfb0ee1996756949897d51291bf043a1277"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/50e01dfb0ee1996756949897d51291bf043a1277"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"1db4b13d86d748d9619ea9ce37bb4663285468b5","is_merged_in_target_branch":true,"change_id":"I4ab2891e156589ae7bb44e6ce69cba3680a070c5","change_number":19176,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"a0ae2e2fa0ba3c52f8eed4bbb97c5de20c2106cb":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-01-15 18:35:58.000000000","uploader":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"ref":"refs/changes/76/18476/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/18476/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/18476/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/18476/3"}}},"commit":{"parents":[{"commit":"1db4b13d86d748d9619ea9ce37bb4663285468b5","subject":"Move common virt driver options to virt.driver","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1db4b13d86d748d9619ea9ce37bb4663285468b5"}]}],"author":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2012-12-20 13:47:21.000000000","tz":-300},"committer":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2013-01-15 18:34:56.000000000","tz":-300},"subject":"minor improvements to nova/tests/test_metadata.py","message":"minor improvements to nova/tests/test_metadata.py\n\nThere are 2 changes here:\n a.) previously we checked for existance of \u0027user-data\u0027 in\n     a response, when it clearly would not have been there as\n     the key name is \u0027user_data\u0027.\n b.) Insist that top level keys in the openstack metadata do not have \u0027-\u0027.\n     This is just a consistency thing.  Its very easy for someone to\n     unintentionally add a key named \u0027my-field\u0027.  We want to enforce\n     keys to be named consistently using \u0027_\u0027 rather than -.\n     For reference, current keys are:\n       files uuid availability_zone hostname meta public_keys name\n\nChange-Id: Ia73050c5313b3524dd1d341528cc5f916e603c64\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a0ae2e2fa0ba3c52f8eed4bbb97c5de20c2106cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a0ae2e2fa0ba3c52f8eed4bbb97c5de20c2106cb"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"1db4b13d86d748d9619ea9ce37bb4663285468b5","is_merged_in_target_branch":true,"change_id":"I4ab2891e156589ae7bb44e6ce69cba3680a070c5","change_number":19176,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}