)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e93b31fa4917ac9e0eae26907966a2df12111263","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        for instance_name in instance_names:"},{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                # couldn\u0027t find better way to find instance in db by it\u0027s name"},{"line_number":374,"context_line":"                # if i will run on the list of this host instances it will "},{"line_number":375,"context_line":"                # be hard to ignore instances that were created outside"},{"line_number":376,"context_line":"                # openstack."},{"line_number":377,"context_line":"                instance_id \u003d compute_utils.parse_decimal_id(CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F7Bo%3D","line":374,"updated":"2012-12-20 18:01:38.000000000","message":"whitesapce","commit_id":"36c386c0bba9fb42a18e5210bd1f2c4f1a2f48f3"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"06f5f094dfa98fe12d87588b7d59cf8877bfb801","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        for instance_name in instance_names:"},{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                # couldn\u0027t find better way to find instance in db by it\u0027s name"},{"line_number":374,"context_line":"                # if i will run on the list of this host instances it will "},{"line_number":375,"context_line":"                # be hard to ignore instances that were created outside"},{"line_number":376,"context_line":"                # openstack."},{"line_number":377,"context_line":"                instance_id \u003d compute_utils.parse_decimal_id(CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F5Wk%3D","line":374,"in_reply_to":"AAAAM3%2F%2F7Bo%3D","updated":"2012-12-24 16:57:23.000000000","message":"Done","commit_id":"36c386c0bba9fb42a18e5210bd1f2c4f1a2f48f3"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e93b31fa4917ac9e0eae26907966a2df12111263","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                # openstack."},{"line_number":377,"context_line":"                instance_id \u003d compute_utils.parse_decimal_id(CONF"},{"line_number":378,"context_line":"                                    .instance_name_template, instance_name)"},{"line_number":379,"context_line":"                instance \u003d self.db.instance_get(context, instance_id)"},{"line_number":380,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":381,"context_line":"                LOG.warn(_(\u0027Exception %(e) getting instance \u0027"},{"line_number":382,"context_line":"                           \u0027%(instance_name)s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F7Bg%3D","line":379,"updated":"2012-12-20 18:01:38.000000000","message":"well that is ugly but I suppose it works for now. This db call needs to move into the compute conductor.","commit_id":"36c386c0bba9fb42a18e5210bd1f2c4f1a2f48f3"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"06f5f094dfa98fe12d87588b7d59cf8877bfb801","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                # openstack."},{"line_number":377,"context_line":"                instance_id \u003d compute_utils.parse_decimal_id(CONF"},{"line_number":378,"context_line":"                                    .instance_name_template, instance_name)"},{"line_number":379,"context_line":"                instance \u003d self.db.instance_get(context, instance_id)"},{"line_number":380,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":381,"context_line":"                LOG.warn(_(\u0027Exception %(e) getting instance \u0027"},{"line_number":382,"context_line":"                           \u0027%(instance_name)s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F5Wo%3D","line":379,"in_reply_to":"AAAAM3%2F%2F7Bg%3D","updated":"2012-12-24 16:57:23.000000000","message":"Done","commit_id":"36c386c0bba9fb42a18e5210bd1f2c4f1a2f48f3"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e93b31fa4917ac9e0eae26907966a2df12111263","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            instance_host \u003d instance[\u0027host\u0027]"},{"line_number":387,"context_line":"            host \u003d self.host"},{"line_number":388,"context_line":"            if instance[\u0027host\u0027] !\u003d host:"},{"line_number":389,"context_line":"                LOG.info(_(\u0027instance host %(instance_host)s not equals to \u0027"},{"line_number":390,"context_line":"                           \u0027current host %(host)s.\u0027"},{"line_number":391,"context_line":"                           \u0027Deleting zombie instance %(instance_name)s\u0027),"},{"line_number":392,"context_line":"                         locals())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F7Bc%3D","line":389,"updated":"2012-12-20 18:01:38.000000000","message":"* is not equal to","commit_id":"36c386c0bba9fb42a18e5210bd1f2c4f1a2f48f3"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"06f5f094dfa98fe12d87588b7d59cf8877bfb801","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            instance_host \u003d instance[\u0027host\u0027]"},{"line_number":387,"context_line":"            host \u003d self.host"},{"line_number":388,"context_line":"            if instance[\u0027host\u0027] !\u003d host:"},{"line_number":389,"context_line":"                LOG.info(_(\u0027instance host %(instance_host)s not equals to \u0027"},{"line_number":390,"context_line":"                           \u0027current host %(host)s.\u0027"},{"line_number":391,"context_line":"                           \u0027Deleting zombie instance %(instance_name)s\u0027),"},{"line_number":392,"context_line":"                         locals())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F5Ws%3D","line":389,"in_reply_to":"AAAAM3%2F%2F7Bc%3D","updated":"2012-12-24 16:57:23.000000000","message":"Done","commit_id":"36c386c0bba9fb42a18e5210bd1f2c4f1a2f48f3"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a3a3b67b0643f3dcfe4201b7e047790691d3b2a5","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":381,"context_line":"                LOG.warn(_(\u0027Exception %(e) getting instance \u0027"},{"line_number":382,"context_line":"                           \u0027%(instance_name)s\u0027),"},{"line_number":383,"context_line":"                         locals())"},{"line_number":384,"context_line":"                continue"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"            instance_host \u003d instance[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F5Lw%3D","line":383,"updated":"2012-12-24 11:21:03.000000000","message":"This seems to be an expected condition, rather than some generic error. How about changing it to a more explicit LOG.err(\"Instance ... found in the hypervisor, but not in the database\", ...)","commit_id":"348811666a6ba302c3e4588794f39094db2b882c"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"85ed508c2d0af1070303b4ed7bd34be20f3efc31","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":381,"context_line":"                LOG.warn(_(\u0027Exception %(e) getting instance \u0027"},{"line_number":382,"context_line":"                           \u0027%(instance_name)s\u0027),"},{"line_number":383,"context_line":"                         locals())"},{"line_number":384,"context_line":"                continue"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"            instance_host \u003d instance[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F5GY%3D","line":383,"in_reply_to":"AAAAM3%2F%2F5Lw%3D","updated":"2012-12-24 16:57:46.000000000","message":"Done","commit_id":"348811666a6ba302c3e4588794f39094db2b882c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    def _destroy_evacuated_instances(self, context, instances):"},{"line_number":363,"context_line":"        \"\"\"While the compute was down the instances running on it could be"},{"line_number":364,"context_line":"        evacuated to another host. Checking that instance host identical to"},{"line_number":365,"context_line":"        current host. Otherwise destroying it\"\"\""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        # getting all vms on this host"},{"line_number":368,"context_line":"        instance_names \u003d self.driver.list_instances()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FzAI%3D","line":365,"updated":"2013-01-04 19:47:31.000000000","message":"Please read the HACKING.rst section on formatting docstrings…","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    def _destroy_evacuated_instances(self, context, instances):"},{"line_number":363,"context_line":"        \"\"\"While the compute was down the instances running on it could be"},{"line_number":364,"context_line":"        evacuated to another host. Checking that instance host identical to"},{"line_number":365,"context_line":"        current host. Otherwise destroying it\"\"\""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        # getting all vms on this host"},{"line_number":368,"context_line":"        instance_names \u003d self.driver.list_instances()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fxa0%3D","line":365,"in_reply_to":"AAAAM3%2F%2FzAI%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            if instance[\u0027host\u0027] !\u003d host:"},{"line_number":393,"context_line":"                LOG.info(_(\u0027instance host %(instance_host)s is not equal to \u0027"},{"line_number":394,"context_line":"                           \u0027current host %(host)s.\u0027"},{"line_number":395,"context_line":"                           \u0027Deleting zombie instance %(instance_name)s\u0027),"},{"line_number":396,"context_line":"                         locals())"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"                network_info \u003d self._get_instance_nw_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2FQ%3D","line":395,"updated":"2013-01-04 19:47:31.000000000","message":"This will format as, in part, \"…current host \u003chost\u003e.Deleting…\"  Please add a space or two after the \u0027.\u0027 for separation…","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            if instance[\u0027host\u0027] !\u003d host:"},{"line_number":393,"context_line":"                LOG.info(_(\u0027instance host %(instance_host)s is not equal to \u0027"},{"line_number":394,"context_line":"                           \u0027current host %(host)s.\u0027"},{"line_number":395,"context_line":"                           \u0027Deleting zombie instance %(instance_name)s\u0027),"},{"line_number":396,"context_line":"                         locals())"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"                network_info \u003d self._get_instance_nw_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fxaw%3D","line":395,"in_reply_to":"AAAAM3%2F%2Fy%2FQ%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            self.driver.filter_defer_apply_on()"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        try:"},{"line_number":473,"context_line":"            #checking that instance was not already evacuated to other host"},{"line_number":474,"context_line":"            self._destroy_evacuated_instances(context, instances)"},{"line_number":475,"context_line":"            for instance in instances:"},{"line_number":476,"context_line":"                self._init_instance(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2FM%3D","line":473,"updated":"2013-01-04 19:47:31.000000000","message":"nit: Please insert a space between the \u0027#\u0027 and \u0027checking\u0027","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            self.driver.filter_defer_apply_on()"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        try:"},{"line_number":473,"context_line":"            #checking that instance was not already evacuated to other host"},{"line_number":474,"context_line":"            self._destroy_evacuated_instances(context, instances)"},{"line_number":475,"context_line":"            for instance in instances:"},{"line_number":476,"context_line":"                self._init_instance(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fxas%3D","line":473,"in_reply_to":"AAAAM3%2F%2Fy%2FM%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"3d713328ee964c265b80234bd52cd0556e58c06e","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"                network_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":444,"context_line":"                bdi \u003d self._get_instance_volume_block_device_info(context,"},{"line_number":445,"context_line":"                                                          instance[\u0027uuid\u0027])"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"                self.driver.destroy(instance,"},{"line_number":448,"context_line":"                                    self._legacy_nw_info(network_info),"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAM3%2F%2FrF4%3D","line":445,"updated":"2013-01-09 23:40:51.000000000","message":"this is also broken.  the call wants an instance, not the uuid.","commit_id":"6fc00d34651858308c5b08fdabe8a0b9ce663e26"}],"nova/compute/utils.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a3a3b67b0643f3dcfe4201b7e047790691d3b2a5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    return usage_info"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def parse_decimal_id(template, instance_name):"},{"line_number":257,"context_line":"    prefix \u003d os.path.commonprefix([template, instance_name])"},{"line_number":258,"context_line":"    reg \u003d re.compile(\u0027%s%%\\d*([^\"])[^\"]*\u0027 % prefix)"},{"line_number":259,"context_line":"    format \u003d reg.search(template).group(1).lower()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F5Lk%3D","line":256,"updated":"2012-12-24 11:21:03.000000000","message":"This function could really use a comment about its parameters / output.\n\nAlso it assumes the template will have the number at the end, not in the middle and that the template prefix is regex-friendly. How about regex-matching \"(%/d+)([ioxds])\" in the template, substituting it with \"(\\d+)\" and then using that as a regex? I\u0027m sure it will have some edge cases, but if you add possible formatting suffixes, probably a bit less than the current solution.","commit_id":"348811666a6ba302c3e4588794f39094db2b882c"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"85ed508c2d0af1070303b4ed7bd34be20f3efc31","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    return usage_info"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def parse_decimal_id(template, instance_name):"},{"line_number":257,"context_line":"    prefix \u003d os.path.commonprefix([template, instance_name])"},{"line_number":258,"context_line":"    reg \u003d re.compile(\u0027%s%%\\d*([^\"])[^\"]*\u0027 % prefix)"},{"line_number":259,"context_line":"    format \u003d reg.search(template).group(1).lower()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F5GM%3D","line":256,"in_reply_to":"AAAAM3%2F%2F5Lk%3D","updated":"2012-12-24 16:57:46.000000000","message":"Done, used regex you recommended for template, was not sure how to use \\d+ because instance_id could be hexa.","commit_id":"348811666a6ba302c3e4588794f39094db2b882c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def parse_decimal_id(template, instance_name):"},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"        Finds instance decimal id from instance name"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        :param template: template e.g. instance-%03x-james"},{"line_number":261,"context_line":"        :param instance_name: instance name like instance-007-james"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2FE%3D","line":258,"updated":"2013-01-04 19:47:31.000000000","message":"Please de-indent this docstring; it should line up with the left edge of the opening triple-quotes, i.e., only 4 spaces of indent rather than 8.","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def parse_decimal_id(template, instance_name):"},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"        Finds instance decimal id from instance name"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        :param template: template e.g. instance-%03x-james"},{"line_number":261,"context_line":"        :param instance_name: instance name like instance-007-james"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fxak%3D","line":258,"in_reply_to":"AAAAM3%2F%2Fy%2FE%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            return -1"},{"line_number":292,"context_line":"        # if instance_id has preciding zeroes it must be of expected length"},{"line_number":293,"context_line":"        if instance_name[:1] \u003d\u003d \u00270\u0027 and len("},{"line_number":294,"context_line":"                                        instance_name) !\u003d int(expected_length):"},{"line_number":295,"context_line":"            return -1"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    # if the minimal expected length empty, there should be no preceding zeros"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2Bs%3D","line":294,"updated":"2013-01-04 19:47:31.000000000","message":"Enclose the whole expression in parentheses and break the line after \u0027and\u0027, i.e.:\n\n    if (instance_name[:1] \u003d\u003d \u00270\u0027 and\n            len(instance_name) !\u003d int(expected_length)):\n        return -1","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            return -1"},{"line_number":292,"context_line":"        # if instance_id has preciding zeroes it must be of expected length"},{"line_number":293,"context_line":"        if instance_name[:1] \u003d\u003d \u00270\u0027 and len("},{"line_number":294,"context_line":"                                        instance_name) !\u003d int(expected_length):"},{"line_number":295,"context_line":"            return -1"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    # if the minimal expected length empty, there should be no preceding zeros"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fxao%3D","line":294,"in_reply_to":"AAAAM3%2F%2Fy%2Bs%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a3a3b67b0643f3dcfe4201b7e047790691d3b2a5","unresolved":false,"context_lines":[{"line_number":3142,"context_line":"        self.compute.driver.destroy(evacuated_instance,"},{"line_number":3143,"context_line":"                                    mox.IgnoreArg(),"},{"line_number":3144,"context_line":"                                    mox.IgnoreArg(),"},{"line_number":3145,"context_line":"                                    False)"},{"line_number":3146,"context_line":"        self.stubs.Set(self.compute, \u0027_init_instance\u0027, fake_all)"},{"line_number":3147,"context_line":""},{"line_number":3148,"context_line":"        self.stubs.Set(self.compute.driver, \u0027filter_defer_apply_off\u0027, fake_all)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F5LU%3D","line":3145,"updated":"2012-12-24 11:21:03.000000000","message":"I think this call goes already to the local stub (fake_destroy), which only verifies the values already known in this line - was this supposed to be a part of the mox recorded call plan instead?","commit_id":"348811666a6ba302c3e4588794f39094db2b882c"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"85ed508c2d0af1070303b4ed7bd34be20f3efc31","unresolved":false,"context_lines":[{"line_number":3142,"context_line":"        self.compute.driver.destroy(evacuated_instance,"},{"line_number":3143,"context_line":"                                    mox.IgnoreArg(),"},{"line_number":3144,"context_line":"                                    mox.IgnoreArg(),"},{"line_number":3145,"context_line":"                                    False)"},{"line_number":3146,"context_line":"        self.stubs.Set(self.compute, \u0027_init_instance\u0027, fake_all)"},{"line_number":3147,"context_line":""},{"line_number":3148,"context_line":"        self.stubs.Set(self.compute.driver, \u0027filter_defer_apply_off\u0027, fake_all)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F5GI%3D","line":3145,"in_reply_to":"AAAAM3%2F%2F5LU%3D","updated":"2012-12-24 16:57:46.000000000","message":"Done","commit_id":"348811666a6ba302c3e4588794f39094db2b882c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":3083,"context_line":"        self.compute._instance_update(self.context, instance[\u0027uuid\u0027])"},{"line_number":3084,"context_line":""},{"line_number":3085,"context_line":"    def test_init_host_with_evacuated_instances(self):"},{"line_number":3086,"context_line":"        \"\"\"Confirm init_host works as expected\"\"\""},{"line_number":3087,"context_line":"        # creating testdata"},{"line_number":3088,"context_line":"        c \u003d context.get_admin_context()"},{"line_number":3089,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2Bg%3D","line":3086,"updated":"2013-01-04 19:47:31.000000000","message":"Please eliminate the docstring, or convert it to a comment.","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":3083,"context_line":"        self.compute._instance_update(self.context, instance[\u0027uuid\u0027])"},{"line_number":3084,"context_line":""},{"line_number":3085,"context_line":"    def test_init_host_with_evacuated_instances(self):"},{"line_number":3086,"context_line":"        \"\"\"Confirm init_host works as expected\"\"\""},{"line_number":3087,"context_line":"        # creating testdata"},{"line_number":3088,"context_line":"        c \u003d context.get_admin_context()"},{"line_number":3089,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fxac%3D","line":3086,"in_reply_to":"AAAAM3%2F%2Fy%2Bg%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":3089,"context_line":""},{"line_number":3090,"context_line":"        #instances in central db"},{"line_number":3091,"context_line":"        instances \u003d ["},{"line_number":3092,"context_line":"                     #those are still related to this host"},{"line_number":3093,"context_line":"                     jsonutils.to_primitive(self._create_fake_instance("},{"line_number":3094,"context_line":"                                          {\u0027host\u0027: self.compute.host})),"},{"line_number":3095,"context_line":"                     jsonutils.to_primitive(self._create_fake_instance("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2Bc%3D","line":3092,"updated":"2013-01-04 19:47:31.000000000","message":"The strict pep8 settings, which we don\u0027t currently use in nova, would want to see these lines indented only a further four spaces, i.e.:\n\n    instances \u003d [\n        #those are still related to this host\n        …\n    ]\n\nAlso, as I\u0027ve pointed out before, I\u0027d like to see a space after the \u0027#\u0027 of comments…","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":3089,"context_line":""},{"line_number":3090,"context_line":"        #instances in central db"},{"line_number":3091,"context_line":"        instances \u003d ["},{"line_number":3092,"context_line":"                     #those are still related to this host"},{"line_number":3093,"context_line":"                     jsonutils.to_primitive(self._create_fake_instance("},{"line_number":3094,"context_line":"                                          {\u0027host\u0027: self.compute.host})),"},{"line_number":3095,"context_line":"                     jsonutils.to_primitive(self._create_fake_instance("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FxaY%3D","line":3092,"in_reply_to":"AAAAM3%2F%2Fy%2Bc%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e5825f2e80084f4567a0617fb5b0eff955a3b87","unresolved":false,"context_lines":[{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"        def fake_list_instances():"},{"line_number":3116,"context_line":"            return ["},{"line_number":3117,"context_line":"                    #those are still related to this host"},{"line_number":3118,"context_line":"                     CONF.instance_name_template % instances[0][\u0027id\u0027],"},{"line_number":3119,"context_line":"                     CONF.instance_name_template % instances[1][\u0027id\u0027],"},{"line_number":3120,"context_line":"                     CONF.instance_name_template % instances[2][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fy%2BU%3D","line":3117,"updated":"2013-01-04 19:47:31.000000000","message":"This is indented one space less than the remaining lines; please be consistent with your indentation…","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"8a4ccf04126b21e5bca194e79991edad8729a0df","unresolved":false,"context_lines":[{"line_number":3114,"context_line":""},{"line_number":3115,"context_line":"        def fake_list_instances():"},{"line_number":3116,"context_line":"            return ["},{"line_number":3117,"context_line":"                    #those are still related to this host"},{"line_number":3118,"context_line":"                     CONF.instance_name_template % instances[0][\u0027id\u0027],"},{"line_number":3119,"context_line":"                     CONF.instance_name_template % instances[1][\u0027id\u0027],"},{"line_number":3120,"context_line":"                     CONF.instance_name_template % instances[2][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FxaU%3D","line":3117,"in_reply_to":"AAAAM3%2F%2Fy%2BU%3D","updated":"2013-01-06 11:26:04.000000000","message":"Done","commit_id":"66e50a7edced886226c12d97ec158d127c4a6493"}]}