)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a7c444100934e21ffbf6484bf6f6ccb8e2625d02","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"                                             expected_task_state\u003dtask_states."},{"line_number":1345,"context_line":"                                                 REBUILD_BLOCK_DEVICE_MAPPING)"},{"line_number":1346,"context_line":"            if recreate:"},{"line_number":1347,"context_line":"                admin_password \u003d None"},{"line_number":1348,"context_line":"            else:"},{"line_number":1349,"context_line":"                # pull in new password here since the original password"},{"line_number":1350,"context_line":"                # isn\u0027t in the db"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F7Ak%3D","line":1347,"updated":"2012-12-20 18:03:54.000000000","message":"This will likely cause a problem for people using an admin password on non-shared storage. I wonder if we need to generate a new one in the api and return in it in the evacuate request.","commit_id":"578c7e298fdbc235d4653587ff3fae543570c4c5"},{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"3f5e15836f54ac67b487af1a51af37facd37cf8f","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"                                             expected_task_state\u003dtask_states."},{"line_number":1345,"context_line":"                                                 REBUILD_BLOCK_DEVICE_MAPPING)"},{"line_number":1346,"context_line":"            if recreate:"},{"line_number":1347,"context_line":"                admin_password \u003d None"},{"line_number":1348,"context_line":"            else:"},{"line_number":1349,"context_line":"                # pull in new password here since the original password"},{"line_number":1350,"context_line":"                # isn\u0027t in the db"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F5F4%3D","line":1347,"in_reply_to":"AAAAM3%2F%2F7Ak%3D","updated":"2012-12-24 17:05:59.000000000","message":"You right, done. Now the rebuild receives admin_password from extension with another attribute \u0027on_shared_storage\u0027. The admin should know whether the instance located on shared storage and expected to be rebuilded from existing disk. \nIf admin not specifies the password and instance on shared storage the password will be generated in extension and returned to him, similar to \u0027rescue\u0027 extension.","commit_id":"578c7e298fdbc235d4653587ff3fae543570c4c5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d3107eed6d3d3584acfcfd437ffab21fdca4b55c","unresolved":false,"context_lines":[{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"                if not self.driver.capabilities[\"supports_recreate\"]:"},{"line_number":1286,"context_line":"                    # if driver doesn\u0027t support recreate return with failure"},{"line_number":1287,"context_line":"                    _msg \u003d _(\u0027instance recreate is not implemented \u0027"},{"line_number":1288,"context_line":"                             \u0027by this driver.\u0027)"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"                    LOG.warn(_msg, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FwJM%3D","line":1287,"updated":"2013-01-07 17:17:03.000000000","message":"Out of curiosity, why did you name this local variable \"_msg\"?  Why not just \"msg\"?","commit_id":"0305bc2f39e4dbed3006f6dc31679a9e6cee693c"}]}