)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ad082c27eb54564a8eb80336c080f73ebe70b9ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Garbutt \u003cjohn@johngarbutt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-18 18:34:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Uitlize object directly of instance and flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor and instance are objects in conductor now, so"},{"line_number":10,"context_line":"this patch use comma directly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_33829c95","line":7,"updated":"2015-08-18 18:59:47.000000000","message":"Uitlize \u003d\u003e Utilize","commit_id":"74bfc4b818c5152a534ccefeb35b34a4f16f4f28"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ef809eefd679a313af96126ac8335969260e2da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-19 15:07:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Utilize object directly of instance and flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor and instance are objects in conductor now, so"},{"line_number":10,"context_line":"this patch use comma directly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_aaf7df57","line":7,"updated":"2015-08-19 15:12:26.000000000","message":"This is pretty obscure.  I\u0027d reword this as:\n\n\"conductor: drop flavor compat shim for cold migrate\"","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"845d4bf4aab036b6826da1b83bc2864f39951f6f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-19 15:07:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Utilize object directly of instance and flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor and instance are objects in conductor now, so"},{"line_number":10,"context_line":"this patch use comma directly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_17f604f9","line":7,"in_reply_to":"fa1b9901_aaf7df57","updated":"2015-08-20 11:31:43.000000000","message":"Done","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ef809eefd679a313af96126ac8335969260e2da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Utilize object directly of instance and flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor and instance are objects in conductor now, so"},{"line_number":10,"context_line":"this patch use comma directly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related to blueprint liberty-objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_2ab98f79","line":9,"updated":"2015-08-19 15:12:26.000000000","message":"You\u0027re not doing anything with instance objects, only the flavor object, so just mention the changes for the flavor object here.","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"845d4bf4aab036b6826da1b83bc2864f39951f6f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Utilize object directly of instance and flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flavor and instance are objects in conductor now, so"},{"line_number":10,"context_line":"this patch use comma directly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related to blueprint liberty-objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_d7dc0c75","line":9,"in_reply_to":"fa1b9901_2ab98f79","updated":"2015-08-20 11:31:43.000000000","message":"yes, old commit mesg, should be updated.","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"}],"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7cc81b6280db52623987e387c7f25d32ce0d8724","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"},{"line_number":529,"context_line":"            # is receiving an object, so lookup the flavor to ensure this."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_8a745b36","line":526,"updated":"2015-08-19 15:06:58.000000000","message":"Actually, we\u0027re already at v2.1 so why do we need this check anymore at all?","commit_id":"74bfc4b818c5152a534ccefeb35b34a4f16f4f28"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"284d3f8be5562eb55398dae6fa3c72ea31a40d1e","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"},{"line_number":529,"context_line":"            # is receiving an object, so lookup the flavor to ensure this."},{"line_number":530,"context_line":"            flavor \u003d objects.Flavor.get_by_id(context, flavor[\u0027id\u0027])"},{"line_number":531,"context_line":"        if live and not rebuild and not flavor:"},{"line_number":532,"context_line":"            self._live_migrate(context, instance, scheduler_hint,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_18b508ed","line":529,"updated":"2015-08-19 15:06:01.000000000","message":"Yeah, the conversion to flavor object happens here if the flavor passed in was a primitive dict.","commit_id":"74bfc4b818c5152a534ccefeb35b34a4f16f4f28"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bda71fb233bea67c8ed830b2f1fb393a664df6c3","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                     \u0027security_groups\u0027]"},{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_6acea72f","line":525,"updated":"2015-08-19 15:11:16.000000000","message":"This compat shim was added in 8a27da34e7189499b48b8971755393d75447cc07.\n\nGiven the comment, I believe you can remove this type check now and also update the related unit test to pass in a flavor object rather than a dict.","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6b62f4891de674eddc528e555a2aadbe6bc0d0d","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                     \u0027security_groups\u0027]"},{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_c471e245","line":525,"in_reply_to":"fa1b9901_04e7da11","updated":"2015-08-19 16:43:16.000000000","message":"The flavor object compat was added in 1.10 so we can\u0027t really drop this until we drop support for 1.x of the RPC API, so yeah, it\u0027s probably the comment that needs changing (which would be OK in this patch IMO), but we can\u0027t remove the compat shim.","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"845d4bf4aab036b6826da1b83bc2864f39951f6f","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                     \u0027security_groups\u0027]"},{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_3739c8a4","line":525,"in_reply_to":"fa1b9901_0ace0082","updated":"2015-08-20 11:31:43.000000000","message":"ok, thanks for the detailed description, will do it","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e33ea94fd9ed262d038b602271778d0cdfb40fa","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                     \u0027security_groups\u0027]"},{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_04e7da11","line":525,"in_reply_to":"fa1b9901_3971eba8","updated":"2015-08-19 16:40:48.000000000","message":"The comment may be wrong.  It might need to say \"Remove this when we drop support for v1 of the RPC API\"","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"45c5a70caf48f3cb0f9790fec76c859a04ecabca","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                     \u0027security_groups\u0027]"},{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_3971eba8","line":525,"in_reply_to":"fa1b9901_6acea72f","updated":"2015-08-19 16:18:39.000000000","message":"When did/are we dropping v1?\n\nI still see lots of 1.x references in nova/conductor/rpcapi","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"23a6fdac7a790c1b84153d6c0bd78ea67224a273","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                     \u0027security_groups\u0027]"},{"line_number":523,"context_line":"            instance \u003d objects.Instance._from_db_object("},{"line_number":524,"context_line":"                context, objects.Instance(), instance,"},{"line_number":525,"context_line":"                expected_attrs\u003dattrs)"},{"line_number":526,"context_line":"        # NOTE(melwitt): Remove this in version 2.0 of the RPC API"},{"line_number":527,"context_line":"        if flavor and not isinstance(flavor, objects.Flavor):"},{"line_number":528,"context_line":"            # Code downstream may expect extra_specs to be populated since it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_0ace0082","line":525,"in_reply_to":"fa1b9901_c471e245","updated":"2015-08-19 18:09:04.000000000","message":"Thanks for clarifying.  Agreed.","commit_id":"8844c88c21f84046aeaba85dbbe39b7b92aa8dd8"}]}