)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c688920b71ae4963b4ef517689ec251a4bd9729","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The new logic will try to update more intance caches per periodic"},{"line_number":17,"context_line":"task cycle without to stress to much the database. Basically if"},{"line_number":18,"context_line":"configured by default it should be able to update all cache in"},{"line_number":19,"context_line":"two/three cycles."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7098f27dcde649d66eaf28accb136706bf12592d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_9b4d0ec7","line":19,"updated":"2015-05-26 12:34:09.000000000","message":"if you are using neutron then this may be a number of additional calls to the neutron service. n","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"55b00dd2a08fda5b887bf0d97b21a9f5b3653e19","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The new logic will try to update more intance caches per periodic"},{"line_number":17,"context_line":"task cycle without to stress to much the database. Basically if"},{"line_number":18,"context_line":"configured by default it should be able to update all cache in"},{"line_number":19,"context_line":"two/three cycles."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7098f27dcde649d66eaf28accb136706bf12592d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_3e8cc834","line":19,"in_reply_to":"7a016987_9b4d0ec7","updated":"2015-05-26 12:50:23.000000000","message":"Yes, I will add a note about it as for database.","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c688920b71ae4963b4ef517689ec251a4bd9729","unresolved":false,"context_lines":[{"line_number":5186,"context_line":"        start \u003d time.time()"},{"line_number":5187,"context_line":"        instance_uuids \u003d getattr(self, \u0027_instance_uuids_to_heal\u0027, [])"},{"line_number":5188,"context_line":""},{"line_number":5189,"context_line":"        def do_refresh(instance):"},{"line_number":5190,"context_line":"            try:"},{"line_number":5191,"context_line":"                # Call to network API to get instance info.. this will"},{"line_number":5192,"context_line":"                # force an update to the instance\u0027s info_cache"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5bb556ce","line":5189,"updated":"2015-05-26 12:34:09.000000000","message":"any reason why this needs to be a nested method?","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"55b00dd2a08fda5b887bf0d97b21a9f5b3653e19","unresolved":false,"context_lines":[{"line_number":5186,"context_line":"        start \u003d time.time()"},{"line_number":5187,"context_line":"        instance_uuids \u003d getattr(self, \u0027_instance_uuids_to_heal\u0027, [])"},{"line_number":5188,"context_line":""},{"line_number":5189,"context_line":"        def do_refresh(instance):"},{"line_number":5190,"context_line":"            try:"},{"line_number":5191,"context_line":"                # Call to network API to get instance info.. this will"},{"line_number":5192,"context_line":"                # force an update to the instance\u0027s info_cache"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_3ebe08d5","line":5189,"in_reply_to":"7a016987_5bb556ce","updated":"2015-05-26 12:50:23.000000000","message":"I wanted to keep the logic line 5251 easy to read","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c688920b71ae4963b4ef517689ec251a4bd9729","unresolved":false,"context_lines":[{"line_number":5188,"context_line":""},{"line_number":5189,"context_line":"        def do_refresh(instance):"},{"line_number":5190,"context_line":"            try:"},{"line_number":5191,"context_line":"                # Call to network API to get instance info.. this will"},{"line_number":5192,"context_line":"                # force an update to the instance\u0027s info_cache"},{"line_number":5193,"context_line":"                self.network_api.get_instance_nw_info(context, instance)"},{"line_number":5194,"context_line":"                LOG.debug(\u0027Updated the network info_cache for instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_fbb3e2e7","line":5191,"updated":"2015-05-26 12:34:09.000000000","message":"info.. - not exactly sure what that means","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"55b00dd2a08fda5b887bf0d97b21a9f5b3653e19","unresolved":false,"context_lines":[{"line_number":5188,"context_line":""},{"line_number":5189,"context_line":"        def do_refresh(instance):"},{"line_number":5190,"context_line":"            try:"},{"line_number":5191,"context_line":"                # Call to network API to get instance info.. this will"},{"line_number":5192,"context_line":"                # force an update to the instance\u0027s info_cache"},{"line_number":5193,"context_line":"                self.network_api.get_instance_nw_info(context, instance)"},{"line_number":5194,"context_line":"                LOG.debug(\u0027Updated the network info_cache for instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_de1ff407","line":5191,"in_reply_to":"7a016987_fbb3e2e7","updated":"2015-05-26 12:50:23.000000000","message":"Actually I did not update this comment. But I can try to explain, when we call the method \"self.network_api.get_instance_nw_info\" we force to update the cache - it\u0027s also related to this review https://review.openstack.org/#/c/146036/","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c688920b71ae4963b4ef517689ec251a4bd9729","unresolved":false,"context_lines":[{"line_number":5222,"context_line":"                              \u0027because it is being deleted.\u0027, instance\u003dinst)"},{"line_number":5223,"context_line":"                    continue"},{"line_number":5224,"context_line":""},{"line_number":5225,"context_line":"                instance_uuids.append(inst[\u0027uuid\u0027])"},{"line_number":5226,"context_line":""},{"line_number":5227,"context_line":"            self._instance_uuids_to_heal \u003d instance_uuids"},{"line_number":5228,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_dba2669a","line":5225,"updated":"2015-05-26 12:34:09.000000000","message":"inst is an object. can you please use inst.uuid","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"55b00dd2a08fda5b887bf0d97b21a9f5b3653e19","unresolved":false,"context_lines":[{"line_number":5222,"context_line":"                              \u0027because it is being deleted.\u0027, instance\u003dinst)"},{"line_number":5223,"context_line":"                    continue"},{"line_number":5224,"context_line":""},{"line_number":5225,"context_line":"                instance_uuids.append(inst[\u0027uuid\u0027])"},{"line_number":5226,"context_line":""},{"line_number":5227,"context_line":"            self._instance_uuids_to_heal \u003d instance_uuids"},{"line_number":5228,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_3ed72825","line":5225,"in_reply_to":"7a016987_dba2669a","updated":"2015-05-26 12:50:23.000000000","message":"Sure I will update the code.","commit_id":"0347fa4a35875d58838cb6647ec64d81e3c0ea3b"}]}