)]}'
{"nova/console/serial.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dc0bd31b362f6d3f450e143e542cfaa930a128c1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                help\u003d\u0027Enable serial console related features for the services \u0027"},{"line_number":37,"context_line":"                \u0027nova-compute and nova-serialproxy.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027port_range\u0027,"},{"line_number":39,"context_line":"                default\u003dDEFAULT_PORT_RANGE,"},{"line_number":40,"context_line":"                help\u003d\u0027Range of TCP ports to use for serial ports on compute \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_23b952ed","line":37,"updated":"2015-05-26 10:36:26.000000000","message":"indentation here is dodgy","commit_id":"4655d8d756dbe58660b801e86f7ad81a82fbb523"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f1e7bba7f352eb6a6b13fd222f67d3c0a7c726d7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                help\u003d\u0027Enable serial console related features for the services \u0027"},{"line_number":37,"context_line":"                \u0027nova-compute and nova-serialproxy.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027port_range\u0027,"},{"line_number":39,"context_line":"                default\u003dDEFAULT_PORT_RANGE,"},{"line_number":40,"context_line":"                help\u003d\u0027Range of TCP ports to use for serial ports on compute \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7bba520c","line":37,"in_reply_to":"7a016987_23b952ed","updated":"2015-05-26 12:22:28.000000000","message":"Done","commit_id":"4655d8d756dbe58660b801e86f7ad81a82fbb523"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2c6100b84e175f0f64d98a7bb1ced14e7ae527be","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                     \u0027range.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027base_url\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027The URL which is returned by the nova-compute service to \u0027"},{"line_number":47,"context_line":"                    \u0027allow connection to the nova-serialproxy service. \u0027"},{"line_number":48,"context_line":"                    \u0027The IP address must be identical to the address to which \u0027"},{"line_number":49,"context_line":"                    \u0027the nova-serialproxy is listening (see option \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_ee50f660","line":46,"updated":"2015-07-24 09:47:14.000000000","message":"We have to make clear this is the URL shared to the end users completed by a token - Perhaps say the \"The URL which is returned by the API with a token authentication to the end users...\"\n\nOr something like that to make clear to the operators that is URL shared to users.","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"0d03c42b7ca58ff324d633951475f0e3eaee41d0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                     \u0027range.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027base_url\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027ws://127.0.0.1:6083/\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027The URL which is returned by the nova-compute service to \u0027"},{"line_number":47,"context_line":"                    \u0027allow connection to the nova-serialproxy service. \u0027"},{"line_number":48,"context_line":"                    \u0027The IP address must be identical to the address to which \u0027"},{"line_number":49,"context_line":"                    \u0027the nova-serialproxy is listening (see option \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_3c2e4943","line":46,"in_reply_to":"3a50d1a3_ee50f660","updated":"2015-08-13 08:12:33.000000000","message":"I\u0027ll use that wording in the next version and after we have clarified if I hide a bug by \"deprecating\" the \"listen\" config option (see Tony\u0027s comment in line 62).","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2eb414de5dcfa91d4ede77f905dd86d3b859a52f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5bd2f635","line":62,"updated":"2015-05-26 12:27:40.000000000","message":"I couldn\u0027t find any place in the code where this is used.","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5c4c6a550739c047193db1fac4c54a24ac51c8e1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b6bfa7a9","line":62,"in_reply_to":"1a4dcd0f_108a511b","updated":"2015-08-14 02:15:10.000000000","message":"Okay I see why I was confused and serial_console.proxyclient_address is a terrible name but it is being used where I expected serial_console.listen to be used. \n\nI think it\u0027s too late for that in Liberty but we should definitely put a bp together for Mitaka.\n\nSorry for the confusion.","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"604de91f89030093d47427516cb98354a0f76a22","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_108a511b","line":62,"in_reply_to":"1a4dcd0f_88a084f5","updated":"2015-08-13 08:36:15.000000000","message":"The proxyclient_address is actually only used for binding the serial console service. So when having many compute nodes, it\u0027s set to the IP address of the compute node or to 0.0.0.0 to allow connections on all interfaces.\n\nSo I think the naming is odd, the current config option could be renamed to listen_address in my opinion.","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"0d03c42b7ca58ff324d633951475f0e3eaee41d0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_3c84095c","line":62,"in_reply_to":"1a4dcd0f_88a084f5","updated":"2015-08-13 08:12:33.000000000","message":"There is an issue that you cannot live-migrate with the current code [1] and [2] tries to solve this. Maybe we should clarify this before I update the help (\u003d\u003e -1 W). \n\n[1] https://bugs.launchpad.net/nova/+bug/1455252\n\n[2] https://review.openstack.org/#/c/191035/","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0b8a447608e27962e262759135caba2b611e8838","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_88a084f5","line":62,"in_reply_to":"3a50d1a3_8eda9216","updated":"2015-08-13 03:49:07.000000000","message":"Sorry.\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3846\n\nShouldn\u0027t the serial console be bound to the listen address rather than the proxyclient_address?  When everything is 127.0.0.1 it\u0027s fine but if you had multiple compute nodes and one proxyclient the code above seems wrong.","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2c6100b84e175f0f64d98a7bb1ced14e7ae527be","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_8eda9216","line":62,"in_reply_to":"3a50d1a3_da587f33","updated":"2015-07-24 09:47:14.000000000","message":"Can you refer a link instead of a line I cannot find what you are referring ?","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"116bcb0cdc2d6cd4eee78d7c47eae45e7de9f49f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d\u0027DEPRECATED: this option has no effect anymore. \u0027"},{"line_number":60,"context_line":"                    \u0027Please use \"proxyclient_address\" instead. \u0027"},{"line_number":61,"context_line":"                    \u0027This option is deprecated and will be removed in \u0027"},{"line_number":62,"context_line":"                    \u0027future releases.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027127.0.0.1\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The address to which proxy clients \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_da587f33","line":62,"in_reply_to":"7a016987_5bd2f635","updated":"2015-07-23 15:01:28.000000000","message":"Okay so that\u0027s a bug in fact.  I\u0027m pretty sure that this *should* be used in nova/virt/libvirt/driver.py:3749","commit_id":"15858a2f6f564d4dc3bb7fb870ec10a2ca07e0eb"}]}