)]}'
{"nova/api/openstack/compute/contrib/hosts.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"28b359369a3525c593b4c7e34354e9c5904211c3","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return {\"host\": {\"host_name\": host, \"power_action\": result}}"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @wsgi.serializers(xml\u003dHostActionTemplate)"},{"line_number":216,"context_line":"    def startup(self, req, id, body\u003d{}):"},{"line_number":217,"context_line":"        return self._host_power_action(req, host\u003did, action\u003d\"startup\")"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @wsgi.serializers(xml\u003dHostActionTemplate)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FzE0%3D","line":216,"updated":"2013-01-04 19:19:41.000000000","message":"Not sure why you give \u0027body\u0027 a default value here.  Is that just to avoid updating the tests?  I\u0027d almost rather you go ahead and update the tests.\n\nFor that matter, would it be worth considering making these formal actions?  That\u0027s directly supported by wsgi.Controller, but would entail a change in the way these are called…","commit_id":"f1600c585d15697bb6358e9ae5e94a34beab16fe"},{"author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"change_message_id":"9a7d024d559ebcea029a6bd85f332ff912b9e98f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return {\"host\": {\"host_name\": host, \"power_action\": result}}"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @wsgi.serializers(xml\u003dHostActionTemplate)"},{"line_number":216,"context_line":"    def startup(self, req, id, body\u003d{}):"},{"line_number":217,"context_line":"        return self._host_power_action(req, host\u003did, action\u003d\"startup\")"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @wsgi.serializers(xml\u003dHostActionTemplate)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FwIw%3D","line":216,"in_reply_to":"AAAAM3%2F%2FzE0%3D","updated":"2013-01-07 17:19:03.000000000","message":"Done","commit_id":"f1600c585d15697bb6358e9ae5e94a34beab16fe"}],"nova/api/openstack/compute/contrib/services.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"28b359369a3525c593b4c7e34354e9c5904211c3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def _service_dict(svc, now):"},{"line_number":66,"context_line":"        delta \u003d now - (svc[\u0027updated_at\u0027] or svc[\u0027created_at\u0027])"},{"line_number":67,"context_line":"        alive \u003d abs(utils.total_seconds(delta)) \u003c\u003d CONF.service_down_time"},{"line_number":68,"context_line":"        art \u003d (alive and \u0027up\u0027) or \u0027down\u0027"},{"line_number":69,"context_line":"        active \u003d \u0027disabled\u0027 if svc[\u0027disabled\u0027] else \u0027enabled\u0027"},{"line_number":70,"context_line":"        return {"},{"line_number":71,"context_line":"            \u0027binary\u0027: svc[\u0027binary\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FzEU%3D","line":68,"updated":"2013-01-04 19:19:41.000000000","message":"I recommend changing this to:\n\n    art \u003d \u0027up\u0027 if alive else \u0027down\u0027\n\nThat will be clearer, and matches how you compute active.\n\nAlso, what the heck does \"art\" mean?  You should pick variable names that explain their purpose, as much as possible.  I\u0027d suggest using a variable name of \u0027state\u0027, since that\u0027s the dictionary key this value will be assigned to, and it makes more sense than \"art\".","commit_id":"f1600c585d15697bb6358e9ae5e94a34beab16fe"},{"author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"change_message_id":"9a7d024d559ebcea029a6bd85f332ff912b9e98f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def _service_dict(svc, now):"},{"line_number":66,"context_line":"        delta \u003d now - (svc[\u0027updated_at\u0027] or svc[\u0027created_at\u0027])"},{"line_number":67,"context_line":"        alive \u003d abs(utils.total_seconds(delta)) \u003c\u003d CONF.service_down_time"},{"line_number":68,"context_line":"        art \u003d (alive and \u0027up\u0027) or \u0027down\u0027"},{"line_number":69,"context_line":"        active \u003d \u0027disabled\u0027 if svc[\u0027disabled\u0027] else \u0027enabled\u0027"},{"line_number":70,"context_line":"        return {"},{"line_number":71,"context_line":"            \u0027binary\u0027: svc[\u0027binary\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fwc0%3D","line":68,"in_reply_to":"AAAAM3%2F%2FzEU%3D","updated":"2013-01-07 17:19:03.000000000","message":"Sorry, I\u0027ve just kept the original code from the old `index` function!","commit_id":"f1600c585d15697bb6358e9ae5e94a34beab16fe"}]}