)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ece16b1a514bce44b9262c4d799c17a13f5eff3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"code to catch the right exception."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: the code is backward compatible and we will still support"},{"line_number":15,"context_line":"the vexc.VMwareDriverException excpetion if an older oslo.vmware"},{"line_number":16,"context_line":"version is used. This will be deprecated in the next cycle."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1459021"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_64639b1b","line":15,"updated":"2015-05-27 15:07:33.000000000","message":"s/excpetion/exception/","commit_id":"30e622381cecd509efe8351bfbd46df53227ac68"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"04af274804f3891ce7eb1483a79753192b3aedbb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"code to catch the right exception."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: the code is backward compatible and we will still support"},{"line_number":15,"context_line":"the vexc.VMwareDriverException excpetion if an older oslo.vmware"},{"line_number":16,"context_line":"version is used. This will be deprecated in the next cycle."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1459021"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_24124363","line":15,"in_reply_to":"7a016987_64639b1b","updated":"2015-05-27 15:09:35.000000000","message":"Done","commit_id":"30e622381cecd509efe8351bfbd46df53227ac68"}],"nova/tests/unit/virt/vmwareapi/fake.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"19e050c9db7df8e01aa370eb9dc32beab57670c4","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        config_spec \u003d kwargs.get(\"config\")"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1252,"context_line":"            ex \u003d vexc.VimFaultException([], \u0027A specified parameter was not \u0027"},{"line_number":1253,"context_line":"                                        \u0027correct.\u0027)"},{"line_number":1254,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_05b61edc","line":1252,"updated":"2015-05-27 16:36:12.000000000","message":"NIT: s/not correct/incorrect","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2d5dc693a773dfdf037d05b4bcc12d13739c0797","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        config_spec \u003d kwargs.get(\"config\")"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1252,"context_line":"            ex \u003d vexc.VimFaultException([], \u0027A specified parameter was not \u0027"},{"line_number":1253,"context_line":"                                        \u0027correct.\u0027)"},{"line_number":1254,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_65ccb261","line":1252,"in_reply_to":"7a016987_05b61edc","updated":"2015-05-27 16:40:16.000000000","message":"Eric, not appropriate for this change.","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a40bb9a6f90ac8b40c1b1e12daa1310f28ec92cd","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"        config_spec \u003d kwargs.get(\"config\")"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1252,"context_line":"            ex \u003d vexc.VimFaultException([], \u0027A specified parameter was not \u0027"},{"line_number":1253,"context_line":"                                        \u0027correct.\u0027)"},{"line_number":1254,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_f02aa2e6","line":1252,"in_reply_to":"7a016987_65ccb261","updated":"2015-05-27 17:05:45.000000000","message":"Agreed, just noting it.","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fddebeae5186e561e01c557d4aa2b5d37192f007","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"            mock.patch.object(self.conn._session, \u0027_call_method\u0027,"},{"line_number":1045,"context_line":"                              fake_call_method)"},{"line_number":1046,"context_line":"        ):"},{"line_number":1047,"context_line":"            self.assertRaises(vexc.VimFaultException,"},{"line_number":1048,"context_line":"                              self._create_vm)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    def test_spawn_with_move_file_exists_poll_exception(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_65c5d23b","line":1047,"updated":"2015-05-27 16:37:04.000000000","message":"This sucks, but any chance we can test with both exceptions? that probably means a but if nasty test refactoring though :(","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"3f0915f30f4beb287a86398ce934a6239e352e93","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"            mock.patch.object(self.conn._session, \u0027_call_method\u0027,"},{"line_number":1045,"context_line":"                              fake_call_method)"},{"line_number":1046,"context_line":"        ):"},{"line_number":1047,"context_line":"            self.assertRaises(vexc.VimFaultException,"},{"line_number":1048,"context_line":"                              self._create_vm)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    def test_spawn_with_move_file_exists_poll_exception(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_cb97f7e9","line":1047,"in_reply_to":"7a016987_507296e4","updated":"2015-05-27 17:33:03.000000000","message":"agreed. Otherwise we are forcing a lockstep upgrade of nova code and the oslo.vmware lib when we don\u0027t have to.","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"786aea5d1cf6402896eebdb98ab7622e176993f4","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"            mock.patch.object(self.conn._session, \u0027_call_method\u0027,"},{"line_number":1045,"context_line":"                              fake_call_method)"},{"line_number":1046,"context_line":"        ):"},{"line_number":1047,"context_line":"            self.assertRaises(vexc.VimFaultException,"},{"line_number":1048,"context_line":"                              self._create_vm)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    def test_spawn_with_move_file_exists_poll_exception(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_507296e4","line":1047,"in_reply_to":"7a016987_65c5d23b","updated":"2015-05-27 17:12:27.000000000","message":"As long as we\u0027re catching both (and depending on that for correctness) we need to test with both, IMHO.","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e32f24a56758732fa68d6f8ba2d0723fa8f21494","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"            mock.patch.object(self.conn._session, \u0027_call_method\u0027,"},{"line_number":1045,"context_line":"                              fake_call_method)"},{"line_number":1046,"context_line":"        ):"},{"line_number":1047,"context_line":"            self.assertRaises(vexc.VimFaultException,"},{"line_number":1048,"context_line":"                              self._create_vm)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    def test_spawn_with_move_file_exists_poll_exception(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_d6655e1d","line":1047,"in_reply_to":"7a016987_cb97f7e9","updated":"2015-05-27 18:48:53.000000000","message":"If we bump the min version of oslo.vmware to 0.13.0, do we still need to do this ?","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08714ac37756f422032bc6f318fb4a7e88c5699e","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    except vexc.VimFaultException:"},{"line_number":1282,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1283,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1284,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_1599bb6e","line":1281,"updated":"2015-05-27 13:31:37.000000000","message":"How is this not indicative of a backwards incompatible change in the oslo.vmware library?  Any other client (like nova) in the world that is using oslo.vmware and expecting to get a VMwareDriverException from a _wait_for_task operation is now possibly broken.","commit_id":"74b42c082054bbcec928f6cc2c9c750385117e89"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b85190cf73dff8653e7d358e4b8c241562de13cd","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    except vexc.VimFaultException:"},{"line_number":1282,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1283,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1284,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6347f177","line":1281,"in_reply_to":"7a016987_1599bb6e","updated":"2015-05-28 09:43:55.000000000","message":"\u003eAny other client (like nova) in the world that is using oslo.vmware and expecting to get a VMwareDriverException from a _wait_for_task operation is now possibly broken.\n\nPlease see:\nhttps://github.com/openstack/oslo.vmware/blob/master/oslo_vmware/api.py#L375\n\nWhy should a client expect VMwareDriverException?\n\nIf there is an undocumented behavior do we need to make the client code compliant with that or fix the library?","commit_id":"74b42c082054bbcec928f6cc2c9c750385117e89"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5e4f813d0d246850d10a39566bf9891c486db24b","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    except vexc.VimFaultException:"},{"line_number":1282,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1283,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1284,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_b8465e1f","line":1281,"in_reply_to":"7a016987_1599bb6e","updated":"2015-05-27 13:50:05.000000000","message":"the patch that added this was https://github.com/openstack/nova/commit/a98dcc636104283d3089f02e5b0fc2b045046ce7\nThis is emulating oslo.vmware and in this case it raises the wrong exception","commit_id":"74b42c082054bbcec928f6cc2c9c750385117e89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ad85ac21f7ad8630b2d6ea29b747f8f03c97a1f","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    except vexc.VimFaultException:"},{"line_number":1282,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1283,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1284,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6eb49c34","line":1281,"in_reply_to":"7a016987_6bc36e58","updated":"2015-05-27 14:21:25.000000000","message":"At the very least, change this patch to handle both the old and new exception types from the library, and leave the unit test code untouched so that demonstrates that it can handle the older behavior from the library (pre-0.13.0).","commit_id":"74b42c082054bbcec928f6cc2c9c750385117e89"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cd97129299a1e8e3d7159791e390ccc4d50e4976","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    except vexc.VimFaultException:"},{"line_number":1282,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1283,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1284,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_442e5ffb","line":1281,"in_reply_to":"7a016987_6eb49c34","updated":"2015-05-27 15:03:14.000000000","message":"Done","commit_id":"74b42c082054bbcec928f6cc2c9c750385117e89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"13d314d1a0e8a10aff1172c979d6bb89b6b125d4","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    except vexc.VimFaultException:"},{"line_number":1282,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1283,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1284,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6bc36e58","line":1281,"in_reply_to":"7a016987_b8465e1f","updated":"2015-05-27 14:08:35.000000000","message":"But it had to use VMwareDriverException b/c that\u0027s what oslo.vmware was raising, right?  Regardless of whether or not that was the right exception to be raising from the library or not, it\u0027s what it was raising and what the nova code (client) was handling.\n\nI would wholeheartedly agree with getting the nova vmware unit tests out of the business of stubbing out the internals of other libraries that it\u0027s using, like oslo.vmware and suds, FWIW.","commit_id":"74b42c082054bbcec928f6cc2c9c750385117e89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ece16b1a514bce44b9262c4d799c17a13f5eff3","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in the next cycle (M)"},{"line_number":1282,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1283,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1284,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_240c8393","line":1281,"updated":"2015-05-27 15:07:33.000000000","message":"Deprecate where?  Nova or oslo.vmware?","commit_id":"30e622381cecd509efe8351bfbd46df53227ac68"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"04af274804f3891ce7eb1483a79753192b3aedbb","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in the next cycle (M)"},{"line_number":1282,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1283,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1284,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_04150748","line":1281,"in_reply_to":"7a016987_240c8393","updated":"2015-05-27 15:09:35.000000000","message":"Done","commit_id":"30e622381cecd509efe8351bfbd46df53227ac68"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fddebeae5186e561e01c557d4aa2b5d37192f007","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in Nova the next"},{"line_number":1282,"context_line":"    # cycle (M)"},{"line_number":1283,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1284,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1285,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_e591c247","line":1282,"updated":"2015-05-27 16:37:04.000000000","message":"when we bump the min version of olso.vmware \u003e 1.3.1 I guess?","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"786aea5d1cf6402896eebdb98ab7622e176993f4","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in Nova the next"},{"line_number":1282,"context_line":"    # cycle (M)"},{"line_number":1283,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1284,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1285,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_d0be8663","line":1282,"in_reply_to":"7a016987_70411239","updated":"2015-05-27 17:12:27.000000000","message":"Agreed, this should:\n\n 1. Not mention a cycle for deprecation/removal\n\n 2. Only specify the drop of that exception when we bump the library\n requirement past that version","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b39fbd0791b2c7f5a2a06c4d92da30061d4bebf","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in Nova the next"},{"line_number":1282,"context_line":"    # cycle (M)"},{"line_number":1283,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1284,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1285,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_70411239","line":1282,"in_reply_to":"7a016987_8577aed3","updated":"2015-05-27 16:49:36.000000000","message":"http://git.openstack.org/cgit/openstack/oslo.vmware/tree/oslo_vmware/exceptions.py#n126\n\nThe VMwareDriverException is still in oslo.vmware, so until that\u0027s gone I don\u0027t see how we deprecate anything from the nova side.\n\nThe only thing I see nova doing is raising it\u0027s minimum required version of oslo.vmware to the point of VMwareDriverException not being something in this code path, but given how flaky the rules are for that library to change things I\u0027m not sure I\u0027d be comfortable with that either.","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e32f24a56758732fa68d6f8ba2d0723fa8f21494","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in Nova the next"},{"line_number":1282,"context_line":"    # cycle (M)"},{"line_number":1283,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1284,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1285,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_83aa03d1","line":1282,"in_reply_to":"7a016987_d0be8663","updated":"2015-05-27 18:48:53.000000000","message":"Let me clarify, the VMwareDriverException is not going to removed from oslo.vmware. There needs to be no deprecation in Nova.\n\nWhen oslo.vmware is not able to find a specific exception [1] for a suds fault, it used to throw a generic VMwareDriverException. This was changed to raise VimFaultException. I will remove the TODO.\n\n [1] - List of known faults - https://github.com/openstack/oslo.vmware/blob/master/oslo_vmware/exceptions.py#L239","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ffe691508af2d42e615eb4a77eaf36a77e159734","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    try:"},{"line_number":1280,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1281,"context_line":"    # TODO(garyk): deprecate vexc.VMwareDriverException in Nova the next"},{"line_number":1282,"context_line":"    # cycle (M)"},{"line_number":1283,"context_line":"    except (vexc.VMwareDriverException, vexc.VimFaultException):"},{"line_number":1284,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1285,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_8577aed3","line":1282,"in_reply_to":"7a016987_e591c247","updated":"2015-05-27 16:45:40.000000000","message":"I totally don\u0027t understand this deprecation TODO.  Does this mean oslo.vmware is going to remove it or has completely already removed this exception class?  IMO this isn\u0027t really Nova\u0027s call, it\u0027s up to whatever minimum version of oslo.vmware that nova moves to which doesn\u0027t have this exception type.","commit_id":"9a4681ee6665d861cefc67bc032c39e03c204544"}]}