)]}'
{"nova/tests/unit/network/test_manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b67d4455fbf0dbd96a2db3b0d3031eb7edfb3051","unresolved":false,"context_lines":[{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"class AllocateTestCase(test.TestCase):"},{"line_number":2702,"context_line":""},{"line_number":2703,"context_line":"    REQUIRES_LOCKING \u003d True"},{"line_number":2704,"context_line":""},{"line_number":2705,"context_line":"    def setUp(self):"},{"line_number":2706,"context_line":"        super(AllocateTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_442f7f3e","line":2703,"updated":"2015-05-27 14:58:00.000000000","message":"Is this still needed?","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e2976042bb93d6ecb754da95193ef23496319801","unresolved":false,"context_lines":[{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"class AllocateTestCase(test.TestCase):"},{"line_number":2702,"context_line":""},{"line_number":2703,"context_line":"    REQUIRES_LOCKING \u003d True"},{"line_number":2704,"context_line":""},{"line_number":2705,"context_line":"    def setUp(self):"},{"line_number":2706,"context_line":"        super(AllocateTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_98994971","line":2703,"in_reply_to":"7a016987_442f7f3e","updated":"2015-05-27 23:57:42.000000000","message":"Thank you for your comment, I will try to modify according to your comment","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"08d4fcd9b25664b2a09395a20adf230fa5b764ac","unresolved":false,"context_lines":[{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"class AllocateTestCase(test.TestCase):"},{"line_number":2702,"context_line":""},{"line_number":2703,"context_line":"    REQUIRES_LOCKING \u003d True"},{"line_number":2704,"context_line":""},{"line_number":2705,"context_line":"    def setUp(self):"},{"line_number":2706,"context_line":"        super(AllocateTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_7f18c875","line":2703,"in_reply_to":"7a016987_442f7f3e","updated":"2015-05-27 15:10:29.000000000","message":"seems after change , all code are not depend on external lock\nguess we can remove it ...","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e2976042bb93d6ecb754da95193ef23496319801","unresolved":false,"context_lines":[{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":"class AllocateTestCase(test.TestCase):"},{"line_number":2702,"context_line":""},{"line_number":2703,"context_line":"    REQUIRES_LOCKING \u003d True"},{"line_number":2704,"context_line":""},{"line_number":2705,"context_line":"    def setUp(self):"},{"line_number":2706,"context_line":"        super(AllocateTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_b892c549","line":2703,"in_reply_to":"7a016987_7f18c875","updated":"2015-05-27 23:57:42.000000000","message":"Thank you for your comment, I will try to modify according to your comment","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4fa5cefed61676b67f0ddde8057066358efcf723","unresolved":false,"context_lines":[{"line_number":2706,"context_line":"        super(AllocateTestCase, self).setUp()"},{"line_number":2707,"context_line":"        self.tempdir \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":2708,"context_line":"        self.flags(log_dir\u003dself.tempdir)"},{"line_number":2709,"context_line":"        self.flags(use_local\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":2710,"context_line":"        self.network \u003d network_manager.VlanManager(host\u003dHOST)"},{"line_number":2711,"context_line":"        dns \u003d \u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027"},{"line_number":2712,"context_line":"        self.network.instance_dns_domain \u003d dns"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c59ec606","line":2709,"updated":"2015-05-27 16:45:17.000000000","message":"Please mock out the conductor methods instead of starting a local conductor...\n\nInstead of mocking out the db.* calls in these tests, simply mock out either the nova.objects.get_* calls OR mock out the direct-to-conductor API calls.","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e2976042bb93d6ecb754da95193ef23496319801","unresolved":false,"context_lines":[{"line_number":2706,"context_line":"        super(AllocateTestCase, self).setUp()"},{"line_number":2707,"context_line":"        self.tempdir \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":2708,"context_line":"        self.flags(log_dir\u003dself.tempdir)"},{"line_number":2709,"context_line":"        self.flags(use_local\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":2710,"context_line":"        self.network \u003d network_manager.VlanManager(host\u003dHOST)"},{"line_number":2711,"context_line":"        dns \u003d \u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027"},{"line_number":2712,"context_line":"        self.network.instance_dns_domain \u003d dns"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_d88fc121","line":2709,"in_reply_to":"7a016987_c59ec606","updated":"2015-05-27 23:57:42.000000000","message":"Thank you for your comment, I will try to modify according to your comment","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4fa5cefed61676b67f0ddde8057066358efcf723","unresolved":false,"context_lines":[{"line_number":2709,"context_line":"        self.flags(use_local\u003dTrue, group\u003d\u0027conductor\u0027)"},{"line_number":2710,"context_line":"        self.network \u003d network_manager.VlanManager(host\u003dHOST)"},{"line_number":2711,"context_line":"        dns \u003d \u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027"},{"line_number":2712,"context_line":"        self.network.instance_dns_domain \u003d dns"},{"line_number":2713,"context_line":"        self.useFixture(test.SampleNetworks())"},{"line_number":2714,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dTrue)"},{"line_number":2715,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_7a18d675","line":2712,"updated":"2015-05-27 16:45:17.000000000","message":"Hmm? Not quite sure what you\u0027re going for here...","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"08d4fcd9b25664b2a09395a20adf230fa5b764ac","unresolved":false,"context_lines":[{"line_number":2711,"context_line":"        dns \u003d \u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027"},{"line_number":2712,"context_line":"        self.network.instance_dns_domain \u003d dns"},{"line_number":2713,"context_line":"        self.useFixture(test.SampleNetworks())"},{"line_number":2714,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dTrue)"},{"line_number":2715,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"},{"line_number":2716,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"},{"line_number":2717,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_9f34a4de","line":2714,"updated":"2015-05-27 15:10:29.000000000","message":"suggest to rename to admin_context to avoid confusion (a lot of test did so, I think)","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c571cb2779f3546ca4d5d42503ed7375e13a36ed","unresolved":false,"context_lines":[{"line_number":2711,"context_line":"        dns \u003d \u0027nova.network.noop_dns_driver.NoopDNSDriver\u0027"},{"line_number":2712,"context_line":"        self.network.instance_dns_domain \u003d dns"},{"line_number":2713,"context_line":"        self.useFixture(test.SampleNetworks())"},{"line_number":2714,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dTrue)"},{"line_number":2715,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"},{"line_number":2716,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"},{"line_number":2717,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_852c79ac","line":2714,"in_reply_to":"7a016987_9f34a4de","updated":"2015-06-05 18:15:07.000000000","message":"Rename and you could also use context.get_admin_context().","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"08d4fcd9b25664b2a09395a20adf230fa5b764ac","unresolved":false,"context_lines":[{"line_number":2713,"context_line":"        self.useFixture(test.SampleNetworks())"},{"line_number":2714,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dTrue)"},{"line_number":2715,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"},{"line_number":2716,"context_line":"        self.user_context \u003d context.RequestContext(\u0027testuser\u0027, \u0027testproject\u0027)"},{"line_number":2717,"context_line":""},{"line_number":2718,"context_line":"    @mock.patch(\u0027nova.db.network_get_all\u0027)"},{"line_number":2719,"context_line":"    def test_allocate_for_instance(self, get_all):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_04a2a74b","line":2716,"updated":"2015-05-27 15:10:29.000000000","message":"2 identical lines?","commit_id":"a866cd736b83c3901f5c744012712c00d428924e"}]}