)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88b5d26ebc8919a6733aa95351a87a047b813ebc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rsritesh \u003crsritesh@rediff.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-27 14:02:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug : when running nova image-create with --poll we continues"},{"line_number":8,"context_line":"to report even when instance is desroyed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Restrict the nova delete command to delete an instance, when a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_8facf29f","line":7,"updated":"2015-06-01 04:34:14.000000000","message":"Remove \"Bug :\" and modify title into a short one line descriptive message.\n\nPlease see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"d221f7e5b63331e8d9ebbbc0f2a290c4ee3620af"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"bdf4e49e1d1299cad0a15d11a0256d68cd0afb19","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rsritesh \u003crsritesh@rediff.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-27 14:02:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug : when running nova image-create with --poll we continues"},{"line_number":8,"context_line":"to report even when instance is desroyed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Restrict the nova delete command to delete an instance, when a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_c19d1667","line":7,"in_reply_to":"7a016987_8facf29f","updated":"2015-06-01 11:33:38.000000000","message":"Done","commit_id":"d221f7e5b63331e8d9ebbbc0f2a290c4ee3620af"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88b5d26ebc8919a6733aa95351a87a047b813ebc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-05-27 14:02:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug : when running nova image-create with --poll we continues"},{"line_number":8,"context_line":"to report even when instance is desroyed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":11,"context_line":"user is trys to take a snapshot of the instnace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_6f989678","line":8,"updated":"2015-06-01 04:34:14.000000000","message":"s/ desroyed/ destroyed","commit_id":"d221f7e5b63331e8d9ebbbc0f2a290c4ee3620af"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"bdf4e49e1d1299cad0a15d11a0256d68cd0afb19","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-05-27 14:02:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug : when running nova image-create with --poll we continues"},{"line_number":8,"context_line":"to report even when instance is desroyed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":11,"context_line":"user is trys to take a snapshot of the instnace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_a198da75","line":8,"in_reply_to":"7a016987_6f989678","updated":"2015-06-01 11:33:38.000000000","message":"Done","commit_id":"d221f7e5b63331e8d9ebbbc0f2a290c4ee3620af"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88b5d26ebc8919a6733aa95351a87a047b813ebc","unresolved":false,"context_lines":[{"line_number":8,"context_line":"to report even when instance is desroyed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":11,"context_line":"user is trys to take a snapshot of the instnace."},{"line_number":12,"context_line":"A check along with a new exception is added in the nova delete"},{"line_number":13,"context_line":"function."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_cf8d4a32","line":11,"updated":"2015-06-01 04:34:14.000000000","message":"when a user tries to take....","commit_id":"d221f7e5b63331e8d9ebbbc0f2a290c4ee3620af"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"bdf4e49e1d1299cad0a15d11a0256d68cd0afb19","unresolved":false,"context_lines":[{"line_number":8,"context_line":"to report even when instance is desroyed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":11,"context_line":"user is trys to take a snapshot of the instnace."},{"line_number":12,"context_line":"A check along with a new exception is added in the nova delete"},{"line_number":13,"context_line":"function."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_618d4230","line":11,"in_reply_to":"7a016987_cf8d4a32","updated":"2015-06-01 11:33:38.000000000","message":"Done","commit_id":"d221f7e5b63331e8d9ebbbc0f2a290c4ee3620af"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b498fb12483cc183827d0d405aa0072da3fbbb9a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Users will not be allowed to delete instance during snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":10,"context_line":"user tries to take a snapshot of the instnace."},{"line_number":11,"context_line":"A check along with a new exception is added in the nova delete"},{"line_number":12,"context_line":"function. This check will raise a exception when users tries to"},{"line_number":13,"context_line":"delete a instance, on which snapshot is happening."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_73f19900","line":10,"updated":"2015-06-01 12:06:25.000000000","message":"instnace \u003d\u003e instance","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"a8dbc35ee434b49c32c32babb4a5e1ccbafaa07e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Users will not be allowed to delete instance during snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":10,"context_line":"user tries to take a snapshot of the instnace."},{"line_number":11,"context_line":"A check along with a new exception is added in the nova delete"},{"line_number":12,"context_line":"function. This check will raise a exception when users tries to"},{"line_number":13,"context_line":"delete a instance, on which snapshot is happening."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_4c132ab9","line":10,"in_reply_to":"7a016987_73f19900","updated":"2015-06-03 05:30:46.000000000","message":"Done","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b498fb12483cc183827d0d405aa0072da3fbbb9a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"delete a instance, on which snapshot is happening."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1312784"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2a2ab5b23481bf8d1ac13fe160b7584029771da4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_53f45def","line":16,"updated":"2015-06-01 12:06:25.000000000","message":"This requires a DocImpact as it is changing the existing functionality.\n\nI do not see why should not allow this.","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"a8dbc35ee434b49c32c32babb4a5e1ccbafaa07e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"delete a instance, on which snapshot is happening."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1312784"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2a2ab5b23481bf8d1ac13fe160b7584029771da4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_ec0f7686","line":16,"in_reply_to":"7a016987_53f45def","updated":"2015-06-03 05:30:46.000000000","message":"Hi, I am not able to understand this comment. Could you please elaborate, I am very much new to this.","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f59da09c786918e090924280d7bcb4b05b233115","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Users will not be allowed to delete instance during snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":10,"context_line":"user tries to take a snapshot of the instnace."},{"line_number":11,"context_line":"A check along with a new exception is added in the nova delete"},{"line_number":12,"context_line":"function. This check will raise a exception when users tries to"},{"line_number":13,"context_line":"delete a instance, on which snapshot is happening."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5afe65bd_2a0d6e90","line":10,"updated":"2015-06-03 06:45:03.000000000","message":"s/instnace/instance","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"1c4db717ac5736d552403407e0b7d5796dd2ee42","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Users will not be allowed to delete instance during snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Restrict the nova delete command to delete an instance, when a"},{"line_number":10,"context_line":"user tries to take a snapshot of the instnace."},{"line_number":11,"context_line":"A check along with a new exception is added in the nova delete"},{"line_number":12,"context_line":"function. This check will raise a exception when users tries to"},{"line_number":13,"context_line":"delete a instance, on which snapshot is happening."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5afe65bd_dd821800","line":10,"in_reply_to":"5afe65bd_2a0d6e90","updated":"2015-06-03 12:53:04.000000000","message":"Done","commit_id":"30541d53954f70558895eea5273ace5661a2024d"}],"nova/api/openstack/extensions.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"9c5556ecd3acf0a4833b3291fde4ec849609394e","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                    # happens due to invalid API parameters, as an"},{"line_number":490,"context_line":"                    # expected error."},{"line_number":491,"context_line":"                    raise"},{"line_number":492,"context_line":"                elif isinstance(exc, exception.InstanceIsSnapshotting):"},{"line_number":493,"context_line":"                    # Note(rsritesh): Hanlde a error, which happens"},{"line_number":494,"context_line":"                    # due to deletion of an instance, when a snapshot"},{"line_number":495,"context_line":"                    # is being taken on that instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_256fe1c6","line":492,"updated":"2015-06-03 07:03:52.000000000","message":"I don\u0027t fully understand the need for this but I am guessing that a more generic exception base class here would make sense? Let\u0027s say the Invalid class?","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"1c4db717ac5736d552403407e0b7d5796dd2ee42","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                    # happens due to invalid API parameters, as an"},{"line_number":490,"context_line":"                    # expected error."},{"line_number":491,"context_line":"                    raise"},{"line_number":492,"context_line":"                elif isinstance(exc, exception.InstanceIsSnapshotting):"},{"line_number":493,"context_line":"                    # Note(rsritesh): Hanlde a error, which happens"},{"line_number":494,"context_line":"                    # due to deletion of an instance, when a snapshot"},{"line_number":495,"context_line":"                    # is being taken on that instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_bdae3c96","line":492,"in_reply_to":"5afe65bd_256fe1c6","updated":"2015-06-03 12:53:04.000000000","message":"Done","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d7de56d500d64e286ffe048e0e854e39bdddebc3","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                    # happens due to invalid API parameters, as an"},{"line_number":490,"context_line":"                    # expected error."},{"line_number":491,"context_line":"                    raise"},{"line_number":492,"context_line":"                elif isinstance(exc, exception.InstanceIsSnapshotting):"},{"line_number":493,"context_line":"                    # Note(rsritesh): Hanlde a error, which happens"},{"line_number":494,"context_line":"                    # due to deletion of an instance, when a snapshot"},{"line_number":495,"context_line":"                    # is being taken on that instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_fe183786","line":492,"in_reply_to":"5afe65bd_256fe1c6","updated":"2015-06-03 09:00:16.000000000","message":"The catches here are used to avoid catching general exceptions when they can happen from several command. In the case of this change the snapshot exception can happen only when we try to delete an instance. I guess all of that block can be removed.","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"1c4db717ac5736d552403407e0b7d5796dd2ee42","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                    # happens due to invalid API parameters, as an"},{"line_number":490,"context_line":"                    # expected error."},{"line_number":491,"context_line":"                    raise"},{"line_number":492,"context_line":"                elif isinstance(exc, exception.InstanceIsSnapshotting):"},{"line_number":493,"context_line":"                    # Note(rsritesh): Hanlde a error, which happens"},{"line_number":494,"context_line":"                    # due to deletion of an instance, when a snapshot"},{"line_number":495,"context_line":"                    # is being taken on that instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_3d9b6c74","line":492,"in_reply_to":"5afe65bd_fe183786","updated":"2015-06-03 12:53:04.000000000","message":"Done","commit_id":"30541d53954f70558895eea5273ace5661a2024d"}],"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b498fb12483cc183827d0d405aa0072da3fbbb9a","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"        elif instance[\u0027task_state\u0027] in (task_states.IMAGE_PENDING_UPLOAD,"},{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceIsSnapshotting("},{"line_number":1536,"context_line":"                instance_uuid\u003dinstance[\u0027uuid\u0027])"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"        original_task_state \u003d instance.task_state"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_33c7a197","line":1535,"updated":"2015-06-01 12:06:25.000000000","message":"what if the instance is stuck in this state?","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2b002752845ef314dc4cba21b7831c4a85b951c7","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"        elif instance[\u0027task_state\u0027] in (task_states.IMAGE_PENDING_UPLOAD,"},{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceIsSnapshotting("},{"line_number":1536,"context_line":"                instance_uuid\u003dinstance[\u0027uuid\u0027])"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"        original_task_state \u003d instance.task_state"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d616fb47","line":1535,"in_reply_to":"7a016987_33c7a197","updated":"2015-06-01 12:35:32.000000000","message":"I guess we can use the API to reset the state of an instance","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b498fb12483cc183827d0d405aa0072da3fbbb9a","unresolved":false,"context_lines":[{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceIsSnapshotting("},{"line_number":1536,"context_line":"                instance_uuid\u003dinstance[\u0027uuid\u0027])"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"        original_task_state \u003d instance.task_state"},{"line_number":1539,"context_line":"        quotas \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d3e04d28","line":1536,"updated":"2015-06-01 12:06:25.000000000","message":"this is an instance object so please use instance.uuid","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"a8dbc35ee434b49c32c32babb4a5e1ccbafaa07e","unresolved":false,"context_lines":[{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceIsSnapshotting("},{"line_number":1536,"context_line":"                instance_uuid\u003dinstance[\u0027uuid\u0027])"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"        original_task_state \u003d instance.task_state"},{"line_number":1539,"context_line":"        quotas \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_ac229eff","line":1536,"in_reply_to":"7a016987_d3e04d28","updated":"2015-06-03 05:30:46.000000000","message":"Done","commit_id":"e2c72628aa7b780612170a8665807d8e6667320f"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"9c5556ecd3acf0a4833b3291fde4ec849609394e","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                LOG.exception(_LE(\"Something wrong happened when trying to \""},{"line_number":1530,"context_line":"                                  \"delete snapshot from shelved instance.\"),"},{"line_number":1531,"context_line":"                              instance\u003dinstance)"},{"line_number":1532,"context_line":"        elif instance[\u0027task_state\u0027] in (task_states.IMAGE_PENDING_UPLOAD,"},{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceIsSnapshotting("}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_ea6e362e","line":1532,"updated":"2015-06-03 07:03:52.000000000","message":"use instance.task_state","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"1c4db717ac5736d552403407e0b7d5796dd2ee42","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                LOG.exception(_LE(\"Something wrong happened when trying to \""},{"line_number":1530,"context_line":"                                  \"delete snapshot from shelved instance.\"),"},{"line_number":1531,"context_line":"                              instance\u003dinstance)"},{"line_number":1532,"context_line":"        elif instance[\u0027task_state\u0027] in (task_states.IMAGE_PENDING_UPLOAD,"},{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceIsSnapshotting("}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_1da2f0ae","line":1532,"in_reply_to":"5afe65bd_ea6e362e","updated":"2015-06-03 12:53:04.000000000","message":"Done","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a224a82df49d5dcda9280f47eeb87bc1027fca41","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"        elif instance.task_state in (task_states.IMAGE_PENDING_UPLOAD,"},{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT):"},{"line_number":1535,"context_line":"            raise exception.InstanceInvalidState("},{"line_number":1536,"context_line":"                attr\u003d\u0027task_state\u0027,"},{"line_number":1537,"context_line":"                instance_uuid\u003dinstance.uuid,"},{"line_number":1538,"context_line":"                state\u003dinstance.task_state,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_536df996","line":1535,"updated":"2015-06-03 13:22:40.000000000","message":"Can you address a test for this case please","commit_id":"f405c62a622dc0382aeef360088c10bd6ee9df2c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6d04249d458dc65b34d848b1af79ce85ee1d3617","unresolved":false,"context_lines":[{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"    @wrap_check_policy"},{"line_number":1822,"context_line":"    @check_instance_lock"},{"line_number":1823,"context_line":"    @check_instance_cell"},{"line_number":1824,"context_line":"    @check_instance_state(vm_state\u003dNone, task_state\u003dNone,"},{"line_number":1825,"context_line":"                          must_have_launched\u003dFalse)"},{"line_number":1826,"context_line":"    def delete(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_b43bf29b","line":1823,"updated":"2015-06-03 14:29:15.000000000","message":"should we change here? \n\nagree we add test cases. thanks","commit_id":"f405c62a622dc0382aeef360088c10bd6ee9df2c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e1de9811e5f3920a56a93dbb4dae08d1be1b97a2","unresolved":false,"context_lines":[{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"    @wrap_check_policy"},{"line_number":1822,"context_line":"    @check_instance_lock"},{"line_number":1823,"context_line":"    @check_instance_cell"},{"line_number":1824,"context_line":"    @check_instance_state(vm_state\u003dNone, task_state\u003dNone,"},{"line_number":1825,"context_line":"                          must_have_launched\u003dFalse)"},{"line_number":1826,"context_line":"    def delete(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_b8e50539","line":1823,"in_reply_to":"5afe65bd_b43bf29b","updated":"2015-06-04 07:51:29.000000000","message":"What can we change here? This decorator is to ensure the instance entering here has a particular state.","commit_id":"f405c62a622dc0382aeef360088c10bd6ee9df2c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c9b64ff74ac63614555295f8ba117cfc75005462","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"                                  \"delete snapshot from shelved instance.\"),"},{"line_number":1531,"context_line":"                              instance\u003dinstance)"},{"line_number":1532,"context_line":"        elif instance.task_state in (task_states.IMAGE_PENDING_UPLOAD,"},{"line_number":1533,"context_line":"                                        task_states.IMAGE_UPLOADING,"},{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT,"},{"line_number":1535,"context_line":"                                        task_states.IMAGE_SNAPSHOT_PENDING,"},{"line_number":1536,"context_line":"                                        task_states.IMAGE_SNAPSHOTTING):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_8d972647","line":1533,"updated":"2015-06-25 10:21:38.000000000","message":"indentation is dodgy here","commit_id":"a03379b0af0d9115fcdba6a513359fe19f48dd20"},{"author":{"_account_id":10657,"name":"Shuichiro MAKIGAKI","email":"shuichiro.makigaki@gmail.com","username":"shuichiro-makigaki"},"change_message_id":"61c00cb68bb756766f7e8fbf294694e4579e388d","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"                                        task_states.IMAGE_SNAPSHOT,"},{"line_number":1535,"context_line":"                                        task_states.IMAGE_SNAPSHOT_PENDING,"},{"line_number":1536,"context_line":"                                        task_states.IMAGE_SNAPSHOTTING):"},{"line_number":1537,"context_line":"            raise exception.InstanceInvalidState("},{"line_number":1538,"context_line":"                attr\u003d\u0027task_state\u0027,"},{"line_number":1539,"context_line":"                instance_uuid\u003dinstance.uuid,"},{"line_number":1540,"context_line":"                state\u003dinstance.task_state,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_75470ebc","line":1537,"updated":"2015-06-25 09:45:49.000000000","message":"How about adding log messages for this exception? (Such as around line 1529) I guess it is helpful for administrator\u0027s troubleshooting because this is a new behavior of API.","commit_id":"a03379b0af0d9115fcdba6a513359fe19f48dd20"}],"nova/exception.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"9c5556ecd3acf0a4833b3291fde4ec849609394e","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s is locked\")"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"class InstanceIsSnapshotting(Invalid):"},{"line_number":1404,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s cannot be deleted \""},{"line_number":1405,"context_line":"                \"during snapshotting\")"},{"line_number":1406,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_aa4f1ebc","line":1403,"updated":"2015-06-03 07:03:52.000000000","message":"You could inherit from the InstanceInvalidState class instead of just the Invalid class.","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d7de56d500d64e286ffe048e0e854e39bdddebc3","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s is locked\")"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"class InstanceIsSnapshotting(Invalid):"},{"line_number":1404,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s cannot be deleted \""},{"line_number":1405,"context_line":"                \"during snapshotting\")"},{"line_number":1406,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_de1b3b7f","line":1403,"in_reply_to":"5afe65bd_aa4f1ebc","updated":"2015-06-03 09:00:16.000000000","message":"+1","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"1c4db717ac5736d552403407e0b7d5796dd2ee42","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s is locked\")"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"class InstanceIsSnapshotting(Invalid):"},{"line_number":1404,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s cannot be deleted \""},{"line_number":1405,"context_line":"                \"during snapshotting\")"},{"line_number":1406,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_7d1c4413","line":1403,"in_reply_to":"5afe65bd_aa4f1ebc","updated":"2015-06-03 12:53:04.000000000","message":"Done","commit_id":"30541d53954f70558895eea5273ace5661a2024d"},{"author":{"_account_id":11503,"name":"Ritesh Paiboina","email":"rsritesh@rediff.com","username":"rsritesh"},"change_message_id":"1c4db717ac5736d552403407e0b7d5796dd2ee42","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s is locked\")"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"class InstanceIsSnapshotting(Invalid):"},{"line_number":1404,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s cannot be deleted \""},{"line_number":1405,"context_line":"                \"during snapshotting\")"},{"line_number":1406,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_3d16ccf1","line":1403,"in_reply_to":"5afe65bd_de1b3b7f","updated":"2015-06-03 12:53:04.000000000","message":"Done","commit_id":"30541d53954f70558895eea5273ace5661a2024d"}]}