)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c9317d58373bcc2c3b14516f3d8aeeb8dabbde40","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CONF.allow_resize_on_same_host should check only once in controller"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing instance resize action, the configuration parameter"},{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"},{"line_number":11,"context_line":"node (compute/api.py) and compute node (compute/manager.py)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_41055fc0","line":9,"updated":"2015-06-02 09:36:20.000000000","message":"resizing instance is clear.","commit_id":"a95f2906bde1dbbb476fd0e260a51a61ab0066d8"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"457770cf4c661134e54109335425c9408840e1a3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CONF.allow_resize_on_same_host should check only once in controller"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing instance resize action, the configuration parameter"},{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"},{"line_number":11,"context_line":"node (compute/api.py) and compute node (compute/manager.py)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_722b8a83","line":9,"in_reply_to":"5afe65bd_41055fc0","updated":"2015-06-02 11:19:45.000000000","message":"Done","commit_id":"a95f2906bde1dbbb476fd0e260a51a61ab0066d8"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c9317d58373bcc2c3b14516f3d8aeeb8dabbde40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"},{"line_number":11,"context_line":"node (compute/api.py) and compute node (compute/manager.py)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The check in compute node is unecessary because after the check"},{"line_number":14,"context_line":"in controller node, the filter_properties[\u0027ignore_hosts\u0027] is"},{"line_number":15,"context_line":"properly setted for scheduling, and when the host was selected"},{"line_number":16,"context_line":"by the scheduler, it should only perform the action and do no more"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_e1ce8bb3","line":13,"updated":"2015-06-02 09:36:20.000000000","message":"s/unecessary/unnecessary/","commit_id":"a95f2906bde1dbbb476fd0e260a51a61ab0066d8"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"457770cf4c661134e54109335425c9408840e1a3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"},{"line_number":11,"context_line":"node (compute/api.py) and compute node (compute/manager.py)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The check in compute node is unecessary because after the check"},{"line_number":14,"context_line":"in controller node, the filter_properties[\u0027ignore_hosts\u0027] is"},{"line_number":15,"context_line":"properly setted for scheduling, and when the host was selected"},{"line_number":16,"context_line":"by the scheduler, it should only perform the action and do no more"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_52208e9b","line":13,"in_reply_to":"5afe65bd_e1ce8bb3","updated":"2015-06-02 11:19:45.000000000","message":"Done","commit_id":"a95f2906bde1dbbb476fd0e260a51a61ab0066d8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d880758d5c4eabd2a7db970e5e5c90db0006f0f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenyu Zheng \u003czhengzhenyu@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-02 11:22:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CONF.allow_resize_on_same_host should check only once in controller"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When resizing instances, the configuration parameter"},{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_718522cd","line":7,"updated":"2015-06-10 12:34:13.000000000","message":"allow_resize_to_same_host","commit_id":"c4255ded07e2fbdd8d174263d365450dd544ce5a"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"954e50cda6af637c3cb916a8b5a7b7a316796434","unresolved":false,"context_lines":[{"line_number":16,"context_line":"by the scheduler, it should only perform the action and do no more"},{"line_number":17,"context_line":"checks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"UpgradeImpact: Users don\u0027t have to set config option "},{"line_number":20,"context_line":"allow_resize_to_same_host in nova.conf at compute node anymore."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I21104eb182ebfa5ddfe3ea0a8663d77df5cf0eab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba3cc151_c81283b4","line":19,"updated":"2015-07-07 13:51:06.000000000","message":"extra whitespace here.\n\nAnd I think it\u0027s more important to mention that allow_resize_to_same host needs to be set on the api nodes now.","commit_id":"589477c64c68f04912b205cbe2a02be13a304c5a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f3f4e39eaebf2a1b84079f9c1f9af710c973d4e1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"by the scheduler, it should only perform the action and do no more"},{"line_number":17,"context_line":"checks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"UpgradeImpact: Users don\u0027t have to set config option "},{"line_number":20,"context_line":"allow_resize_to_same_host in nova.conf at compute node anymore."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I21104eb182ebfa5ddfe3ea0a8663d77df5cf0eab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a41bdd9_d5fd333b","line":19,"in_reply_to":"ba3cc151_c81283b4","updated":"2015-07-14 06:09:13.000000000","message":"Done","commit_id":"589477c64c68f04912b205cbe2a02be13a304c5a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"511d24f31684d7acbc266a5df4e1d9afb81f3c4f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The check in compute node is unnecessary because after the check"},{"line_number":14,"context_line":"in controller node, the filter_properties[\u0027ignore_hosts\u0027] is"},{"line_number":15,"context_line":"properly setted for scheduling, and when the host was selected"},{"line_number":16,"context_line":"by the scheduler, it should only perform the action and do no more"},{"line_number":17,"context_line":"checks."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a50d1a3_b713285c","line":15,"updated":"2015-07-20 05:47:05.000000000","message":"setted \u003d\u003e set","commit_id":"452767794b7b841a7ed62a36618b3c2a6241e4ce"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"60639c08c932ba8185e73288611aa3f82e0b7478","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenyu Zheng \u003czhengzhenyu@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-06 03:25:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CONF.allow_resize_on_same_host should check only once in controller"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing instance resize action, the configuration parameter"},{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"da20952f_4fa4434a","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":20},"updated":"2015-09-09 21:16:54.000000000","message":"s/on/to/","commit_id":"eaa9a21ad7210ce8229b5b6e35c7dd37311148bc"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b4d784bc8889b0071126687e059667f961a13892","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenyu Zheng \u003czhengzhenyu@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-06 03:25:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CONF.allow_resize_on_same_host should check only once in controller"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing instance resize action, the configuration parameter"},{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"da20952f_382d92fd","line":7,"in_reply_to":"da20952f_4fa4434a","updated":"2015-09-10 01:22:19.000000000","message":"My mistake","commit_id":"eaa9a21ad7210ce8229b5b6e35c7dd37311148bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"60639c08c932ba8185e73288611aa3f82e0b7478","unresolved":false,"context_lines":[{"line_number":7,"context_line":"CONF.allow_resize_on_same_host should check only once in controller"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing instance resize action, the configuration parameter"},{"line_number":10,"context_line":"CONF.allow_resize_on_same_host has been checked both in controller"},{"line_number":11,"context_line":"node (compute/api.py) and compute node (compute/manager.py)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The check in compute node is unecessary because after the check"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"da20952f_6f76e7d9","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":20},"updated":"2015-09-09 21:16:54.000000000","message":"s/on/to/","commit_id":"eaa9a21ad7210ce8229b5b6e35c7dd37311148bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"60639c08c932ba8185e73288611aa3f82e0b7478","unresolved":false,"context_lines":[{"line_number":17,"context_line":"checks."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"UpgradeImpact: CONF.allow_resize_on_same_host will no longer checked"},{"line_number":20,"context_line":"in compute/manager.py"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I21104eb182ebfa5ddfe3ea0a8663d77df5cf0eab"},{"line_number":23,"context_line":"Closes-Bug:1459468"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"da20952f_8faa5b19","line":20,"updated":"2015-09-09 21:16:54.000000000","message":"s/on/to/\n\nThe config setting is actually named CONF.allow_resize_to_same_host so I think we should correct it because it\u0027s a message to operators","commit_id":"eaa9a21ad7210ce8229b5b6e35c7dd37311148bc"}],"nova/compute/manager.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"3f7f6cf7c86d81ea8a09c879a1028d8781b8f34f","unresolved":false,"context_lines":[{"line_number":3503,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3504,"context_line":"                raise exception.UnableToMigrateToSelf("},{"line_number":3505,"context_line":"                    instance_id\u003dinstance.uuid, host\u003dself.host)"},{"line_number":3506,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"},{"line_number":3507,"context_line":"            self._set_instance_error_state(context, instance)"},{"line_number":3508,"context_line":"            msg \u003d _(\u0027destination same as source!\u0027)"},{"line_number":3509,"context_line":"            raise exception.MigrationError(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_efd85f81","side":"PARENT","line":3506,"updated":"2015-05-28 12:00:26.000000000","message":"if the CONF.allow_resize_to_same_host is not used anymore here, you should also remove the config import statement.\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n247","commit_id":"4cf6ef68199183697a0209751575f88fe5b2a733"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"77575b1df8b029cb55cdbabb5094f7afff485f4b","unresolved":false,"context_lines":[{"line_number":3503,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3504,"context_line":"                raise exception.UnableToMigrateToSelf("},{"line_number":3505,"context_line":"                    instance_id\u003dinstance.uuid, host\u003dself.host)"},{"line_number":3506,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"},{"line_number":3507,"context_line":"            self._set_instance_error_state(context, instance)"},{"line_number":3508,"context_line":"            msg \u003d _(\u0027destination same as source!\u0027)"},{"line_number":3509,"context_line":"            raise exception.MigrationError(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_cf1a4317","side":"PARENT","line":3506,"in_reply_to":"7a016987_efd85f81","updated":"2015-05-28 12:05:31.000000000","message":"Thank your for your comment","commit_id":"4cf6ef68199183697a0209751575f88fe5b2a733"}]}