)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f4d4cfef8b33579567571e0d72eb999a62ecbdb6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bdm image_meta when boot from volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create a server booted from volume with image,we should"},{"line_number":10,"context_line":"get and check the volume\u0027s size,not the image\u0027s size."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifa4aca2daf609201fa7445d7a6b95f165849c62f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_e3b40136","line":9,"updated":"2015-05-28 08:36:39.000000000","message":"I suggest change to \u0027When boot a server from bootable volume\u0027. Just an advise :)","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"}],"nova/compute/api.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c78fc789f6215b96660742797090bc2aeba430e0","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                    # NOTE(wangxiyuan):When booted from volume with image,we"},{"line_number":994,"context_line":"                    # should get and check volume\u0027s size,not the image\u0027s size."},{"line_number":995,"context_line":"                    if bdm.get(\u0027destination_type\u0027) \u003d\u003d \u0027volume\u0027 and \\"},{"line_number":996,"context_line":"                            bdm.get(\u0027volume_size\u0027):"},{"line_number":997,"context_line":"                        image_meta[\u0027size\u0027] \u003d bdm[\u0027volume_size\u0027] * units.Gi"},{"line_number":998,"context_line":"                    return image_meta"},{"line_number":999,"context_line":"                except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_a6c78944","line":996,"updated":"2015-06-02 09:20:36.000000000","message":"please use brackets to wrap the line that \u003e 79 chars instead of backslash.\n\nlike this:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L712-L714","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a37352f6f9c2dd7a7227d6513fc7b2db54e8fc05","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                try:"},{"line_number":1010,"context_line":"                    image_id \u003d bdm[\u0027image_id\u0027]"},{"line_number":1011,"context_line":"                    image_meta \u003d self.image_api.get(context, image_id)"},{"line_number":1012,"context_line":"                    # NOTE: When booted from volume with image,we should get"},{"line_number":1013,"context_line":"                    # and check volume\u0027s size,not the image\u0027s size."},{"line_number":1014,"context_line":"                    if (bdm.get(\u0027destination_type\u0027) \u003d\u003d \u0027volume\u0027 and"},{"line_number":1015,"context_line":"                            bdm.get(\u0027volume_size\u0027)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_456cb1cd","line":1012,"updated":"2015-06-18 08:54:51.000000000","message":"image,we  \u003d\u003e image, we","commit_id":"b86ce3c5ebc3faeff706ea8496228714a7f655e1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a37352f6f9c2dd7a7227d6513fc7b2db54e8fc05","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                    image_id \u003d bdm[\u0027image_id\u0027]"},{"line_number":1011,"context_line":"                    image_meta \u003d self.image_api.get(context, image_id)"},{"line_number":1012,"context_line":"                    # NOTE: When booted from volume with image,we should get"},{"line_number":1013,"context_line":"                    # and check volume\u0027s size,not the image\u0027s size."},{"line_number":1014,"context_line":"                    if (bdm.get(\u0027destination_type\u0027) \u003d\u003d \u0027volume\u0027 and"},{"line_number":1015,"context_line":"                            bdm.get(\u0027volume_size\u0027)):"},{"line_number":1016,"context_line":"                        image_meta[\u0027size\u0027] \u003d bdm[\u0027volume_size\u0027] * units.Gi"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_a5a7bd09","line":1013,"updated":"2015-06-18 08:54:51.000000000","message":"size,not \u003d\u003e size, not","commit_id":"b86ce3c5ebc3faeff706ea8496228714a7f655e1"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"069ce1506515d9b0abce4445a913e6dfd1dff86e","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                    image_id \u003d bdm[\u0027image_id\u0027]"},{"line_number":1011,"context_line":"                    image_meta \u003d self.image_api.get(context, image_id)"},{"line_number":1012,"context_line":"                    # NOTE: When booted from volume with image,we should get"},{"line_number":1013,"context_line":"                    # and check volume\u0027s size,not the image\u0027s size."},{"line_number":1014,"context_line":"                    if (bdm.get(\u0027destination_type\u0027) \u003d\u003d \u0027volume\u0027 and"},{"line_number":1015,"context_line":"                            bdm.get(\u0027volume_size\u0027)):"},{"line_number":1016,"context_line":"                        image_meta[\u0027size\u0027] \u003d bdm[\u0027volume_size\u0027] * units.Gi"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_65f7758b","line":1013,"in_reply_to":"fa32b979_a5a7bd09","updated":"2015-06-18 09:05:33.000000000","message":"Done","commit_id":"b86ce3c5ebc3faeff706ea8496228714a7f655e1"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c78fc789f6215b96660742797090bc2aeba430e0","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    def test_boot_volume_with_image_size(self):"},{"line_number":623,"context_line":"        def image_api_get(*args, **kwargs):"},{"line_number":624,"context_line":"            return {"},{"line_number":625,"context_line":"                \u0027size\u0027: 2 * (1024 ** 3),"},{"line_number":626,"context_line":"                \u0027properties\u0027: {\u0027img_test_key\u0027: \u0027img_test_value\u0027}"},{"line_number":627,"context_line":"            }"},{"line_number":628,"context_line":"        self.stubs.Set(self.compute_api.image_api, \u0027get\u0027, image_api_get)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_c65e0545","line":625,"updated":"2015-06-02 09:20:36.000000000","message":"why don\u0027t use units.Gi instead of (1024 ** 3)?","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f274ea451a88c60543ce30cff9c70d6cae5cf17f","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    def test_boot_volume_with_image_size(self):"},{"line_number":623,"context_line":"        def image_api_get(*args, **kwargs):"},{"line_number":624,"context_line":"            return {"},{"line_number":625,"context_line":"                \u0027size\u0027: 2 * (1024 ** 3),"},{"line_number":626,"context_line":"                \u0027properties\u0027: {\u0027img_test_key\u0027: \u0027img_test_value\u0027}"},{"line_number":627,"context_line":"            }"},{"line_number":628,"context_line":"        self.stubs.Set(self.compute_api.image_api, \u0027get\u0027, image_api_get)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_e1b8cbe7","line":625,"in_reply_to":"5afe65bd_c65e0545","updated":"2015-06-02 11:34:16.000000000","message":"Done","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c78fc789f6215b96660742797090bc2aeba430e0","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                \u0027size\u0027: 2 * (1024 ** 3),"},{"line_number":626,"context_line":"                \u0027properties\u0027: {\u0027img_test_key\u0027: \u0027img_test_value\u0027}"},{"line_number":627,"context_line":"            }"},{"line_number":628,"context_line":"        self.stubs.Set(self.compute_api.image_api, \u0027get\u0027, image_api_get)"},{"line_number":629,"context_line":"        block_device_mapping \u003d [{"},{"line_number":630,"context_line":"            \u0027boot_index\u0027: 0,"},{"line_number":631,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_26f39975","line":628,"updated":"2015-06-02 09:20:36.000000000","message":"please use mock in your new test case.","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c78fc789f6215b96660742797090bc2aeba430e0","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":632,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":633,"context_line":"            \u0027image_id\u0027: \u0027fake-image\u0027,"},{"line_number":634,"context_line":"            \u0027volume_size\u0027: 10,"},{"line_number":635,"context_line":"            \u0027delete_on_termination\u0027: True,"},{"line_number":636,"context_line":"        }]"},{"line_number":637,"context_line":"        image_meta \u003d self.compute_api._get_bdm_image_metadata("}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_21526314","line":634,"updated":"2015-06-02 09:20:36.000000000","message":"if you can use a variable at here and the expected value of assertEqual , it\u0027s easier to understand.","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f274ea451a88c60543ce30cff9c70d6cae5cf17f","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":632,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":633,"context_line":"            \u0027image_id\u0027: \u0027fake-image\u0027,"},{"line_number":634,"context_line":"            \u0027volume_size\u0027: 10,"},{"line_number":635,"context_line":"            \u0027delete_on_termination\u0027: True,"},{"line_number":636,"context_line":"        }]"},{"line_number":637,"context_line":"        image_meta \u003d self.compute_api._get_bdm_image_metadata("}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_61ee1bee","line":634,"in_reply_to":"5afe65bd_21526314","updated":"2015-06-02 11:34:16.000000000","message":"Nice Suggestion.Thanks","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"c78fc789f6215b96660742797090bc2aeba430e0","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        }]"},{"line_number":637,"context_line":"        image_meta \u003d self.compute_api._get_bdm_image_metadata("},{"line_number":638,"context_line":"            self.context, block_device_mapping, legacy_bdm\u003dFalse)"},{"line_number":639,"context_line":"        self.assertEqual(10 * (1024 ** 3),"},{"line_number":640,"context_line":"                         image_meta[\u0027size\u0027])"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    def test_poll_bandwidth_usage_not_implemented(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_6655111c","line":639,"updated":"2015-06-02 09:20:36.000000000","message":"here","commit_id":"d9f0e9bec0a91eb3899b52ecf055493b8f2281b4"}]}