)]}'
{"nova/cells/messaging.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a4ba0164d559d207f365291b5543d7dc418ca926","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        self._apply_expected_states(instance)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        _convert_string_to_time_stamp(instance, [\u0027launched_at\u0027, \u0027created_at\u0027,"},{"line_number":1048,"context_line":"                                                 \u0027scheduled_at\u0027, \u0027updated_at\u0027,"},{"line_number":1049,"context_line":"                                                 \u0027deleted_at\u0027,"},{"line_number":1050,"context_line":"                                                 \u0027terminated_at\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_bd529033","line":1047,"updated":"2015-05-28 19:22:22.000000000","message":"We have \"convert_objects_related_datetimes()\" in db/sqlalchemy/api.py and do this internal to that interface in other places. Can we just use that?","commit_id":"36d67caeb70d0594d39d234d79f1bc2b5e65f1ce"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dbaf0431c22be528cfcfbc84f2aa329fbd24cc5e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from nova.consoleauth import rpcapi as consoleauth_rpcapi"},{"line_number":52,"context_line":"from nova import context"},{"line_number":53,"context_line":"from nova.db import base"},{"line_number":54,"context_line":"from nova.db.sqlalchemy import api as sqlalchemy_api"},{"line_number":55,"context_line":"from nova import exception"},{"line_number":56,"context_line":"from nova.i18n import _, _LE, _LI, _LW"},{"line_number":57,"context_line":"from nova.network import model as network_model"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_80a767bc","line":54,"updated":"2015-05-28 19:39:55.000000000","message":"This is a layering violation, IMHO.","commit_id":"6bbdd2652e3296d1be336a34f841c75506ffa0ac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dbaf0431c22be528cfcfbc84f2aa329fbd24cc5e","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"                sqlalchemy_api.convert_objects_related_datetimes("},{"line_number":1046,"context_line":"                    instance, \u0027launched_at\u0027, \u0027created_at\u0027, \u0027scheduled_at\u0027,"},{"line_number":1047,"context_line":"                    \u0027updated_at\u0027, \u0027deleted_at\u0027, \u0027terminated_at\u0027)"},{"line_number":1048,"context_line":"                self.db.instance_update(message.ctxt, instance_uuid,"},{"line_number":1049,"context_line":"                        instance, update_cells\u003dFalse)"},{"line_number":1050,"context_line":"            except exception.NotFound:"},{"line_number":1051,"context_line":"                # FIXME(comstud): Strange.  Need to handle quotas here,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_00949740","line":1048,"updated":"2015-05-28 19:39:55.000000000","message":"Just make this (and the others) method in DB api convert those values, right?","commit_id":"6bbdd2652e3296d1be336a34f841c75506ffa0ac"}]}