)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9aee7df7275b16a106d5428f84f948c1716b722c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zte-hanrong \u003cspring068@sina.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 11:16:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch NovaException from post_live_migration_at_destination, set instance vm_state error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie0582cc0a2f27491cb737e4429c0a70a658e211d"},{"line_number":10,"context_line":"Closes-Bug: #1379581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_455216df","line":7,"updated":"2015-06-05 08:59:01.000000000","message":"And if you can wrap the line of the commit message here.","commit_id":"9ad15ccf51bdb3840b18dc4a69eaed488c6345a5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"194a9a3a4e6bce6a7b1c9f3c1ad7d6b81ad9110c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zte-hanrong \u003cspring068@sina.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-01 20:14:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch NovaException from post_live_migration_at_destination, set instance vm_state error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie0582cc0a2f27491cb737e4429c0a70a658e211d"},{"line_number":10,"context_line":"Closes-Bug: #1379581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_3739e7f2","line":7,"updated":"2015-07-01 13:27:43.000000000","message":"please see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"111ee7a7966ba3c09710c963bb9facc28dce616a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b4ae1302679ae7dc4b886d9c945d0db4a4e4251f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-02 10:04:57 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch NovaException from post_live_migration_at_destination, set instance vm_state error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie0582cc0a2f27491cb737e4429c0a70a658e211d"},{"line_number":10,"context_line":"Closes-Bug: #1379581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_ef8fea72","line":8,"updated":"2015-07-02 14:54:21.000000000","message":"Keep the title short and include a description section.  See\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b1878580a4d3cf3d182d37635b597a4ef016ab28"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a02756ab390d34d0d9c6546ebb90cb6acd860aa7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zte-hanrong \u003cspring068@sina.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 14:14:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch NovaException from post_live_migration_at_destination, set instance vm_state error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie0582cc0a2f27491cb737e4429c0a70a658e211d"},{"line_number":10,"context_line":"Closes-Bug: #1379581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_d143196b","line":7,"updated":"2015-07-07 10:13:27.000000000","message":"Please be more specific on your commit message. Perhaps something like:\n\n\n  In order to avoid unhandled instance error when\n  post_live_migration_at_destination fails. This commit\n  catch errors emitted, set the instance in an error\n  status before to reraise the exception.","commit_id":"c8ec11359f4d3cd8ae85f339f0145b9df4e2bf7f"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"a19229515f59a68bbfad60acdeaba432816a54fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zte-hanrong \u003cspring068@sina.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 14:14:40 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch NovaException from post_live_migration_at_destination, set instance vm_state error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie0582cc0a2f27491cb737e4429c0a70a658e211d"},{"line_number":10,"context_line":"Closes-Bug: #1379581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_291691f1","line":7,"in_reply_to":"ba3cc151_d143196b","updated":"2015-07-07 14:35:50.000000000","message":"You need to have a short summary less than 50 characters in length before the improved description mentioned by sahid","commit_id":"c8ec11359f4d3cd8ae85f339f0145b9df4e2bf7f"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fdc35e6df58466866c34f5ec091536a3ad619914","unresolved":false,"context_lines":[{"line_number":5068,"context_line":"        block_device_info \u003d self._get_instance_block_device_info(context,"},{"line_number":5069,"context_line":"                                                                 instance)"},{"line_number":5070,"context_line":"        try:"},{"line_number":5071,"context_line":"            self.driver.post_live_migration_at_destination(context, instance,"},{"line_number":5072,"context_line":"                                                           network_info,"},{"line_number":5073,"context_line":"                                                           block_migration,"},{"line_number":5074,"context_line":"                                                           block_device_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4f0dd7e6","line":5071,"updated":"2015-06-01 08:02:27.000000000","message":"Even if your change does not really fix the problem we have with the vif driver, we should to not keep the instance in a bad state so I guess you change is good.","commit_id":"9ad15ccf51bdb3840b18dc4a69eaed488c6345a5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"194a9a3a4e6bce6a7b1c9f3c1ad7d6b81ad9110c","unresolved":false,"context_lines":[{"line_number":5094,"context_line":"                                                           block_device_info)"},{"line_number":5095,"context_line":"        except exception.NovaException:"},{"line_number":5096,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5097,"context_line":"            LOG.error(_(\"Post operation of live migration at destination\""},{"line_number":5098,"context_line":"                        \" failed %s\"),"},{"line_number":5099,"context_line":"                      traceback.format_exception(sys.exc_info()[0],"},{"line_number":5100,"context_line":"                                                 sys.exc_info()[1],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f7b29f93","line":5097,"updated":"2015-07-01 13:27:43.000000000","message":"miss log hint _LE","commit_id":"111ee7a7966ba3c09710c963bb9facc28dce616a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a02756ab390d34d0d9c6546ebb90cb6acd860aa7","unresolved":false,"context_lines":[{"line_number":5092,"context_line":"                                                           network_info,"},{"line_number":5093,"context_line":"                                                           block_migration,"},{"line_number":5094,"context_line":"                                                           block_device_info)"},{"line_number":5095,"context_line":"        except exception.NovaException:"},{"line_number":5096,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5097,"context_line":"            LOG.error(_LE(\"Post operation of live migration at destination\""},{"line_number":5098,"context_line":"                        \" failed %s\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d45787c8","line":5095,"updated":"2015-07-07 10:13:27.000000000","message":"What did you not use the save_and_reraise context mechanism here?\n\n  try:\n    ...\n  except ...:\n    with excutils.save_and_reraise_exception():\n     instance.vm_state \u003d vm_states.ERROR \n     ...","commit_id":"c8ec11359f4d3cd8ae85f339f0145b9df4e2bf7f"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b4ae1302679ae7dc4b886d9c945d0db4a4e4251f","unresolved":false,"context_lines":[{"line_number":5810,"context_line":"            get_instance_nw_info, get_instance_volume_block_device_info,"},{"line_number":5811,"context_line":"            post_live_migration_at_destination"},{"line_number":5812,"context_line":"        ):"},{"line_number":5813,"context_line":"            post_live_migration_at_destination.side_effect \u003d \\"},{"line_number":5814,"context_line":"                exception.NovaException"},{"line_number":5815,"context_line":"            self.compute.post_live_migration_at_destination(admin_ctxt,"},{"line_number":5816,"context_line":"                                                            instance, False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_0f5d6e14","line":5813,"updated":"2015-07-02 14:54:21.000000000","message":"avoid use of \\.  these variable names are rather long","commit_id":"b1878580a4d3cf3d182d37635b597a4ef016ab28"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"faf096c4c2042b3366697431b054dfdcd7c07620","unresolved":false,"context_lines":[{"line_number":5811,"context_line":"            post_method_destination.side_effect \u003d exception.NovaException"},{"line_number":5812,"context_line":"            self.compute.post_live_migration_at_destination(admin_ctxt,"},{"line_number":5813,"context_line":"                                                            instance, False)"},{"line_number":5814,"context_line":"            self.assertEqual(vm_states.ERROR, instance.vm_state)"},{"line_number":5815,"context_line":""},{"line_number":5816,"context_line":"    def test_post_live_migration_at_destination_without_compute_info(self):"},{"line_number":5817,"context_line":"        \"\"\"The instance\u0027s node property should be set to None if we fail to"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_244b285b","line":5814,"updated":"2015-07-07 09:14:20.000000000","message":"It could be better if you also mock the log and assert the warning log you added.","commit_id":"c8ec11359f4d3cd8ae85f339f0145b9df4e2bf7f"}]}