)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"506238595cd6e20270f1d5a663e165686240c0d2","unresolved":false,"context_lines":[{"line_number":2601,"context_line":"                     context, instance.uuid)"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"            # Checks if the migration needs a disk resize down."},{"line_number":2604,"context_line":"            root_down \u003d new_instance_type[\u0027root_gb\u0027] \u003c instance.root_gb"},{"line_number":2605,"context_line":"            booted_from_volume \u003d self.is_volume_backed_instance("},{"line_number":2606,"context_line":"                     context, instance, bdms)"},{"line_number":2607,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_964cd877","line":2604,"updated":"2015-07-06 12:27:30.000000000","message":"new_instance_type is an object - can you please us new_instance_type.root_gb","commit_id":"76d5f2016b5bad1a8c8f5fd02626bfed6f7a5056"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"140814bc54be3d3981c249772164a4653141149e","unresolved":false,"context_lines":[{"line_number":2601,"context_line":"                     context, instance.uuid)"},{"line_number":2602,"context_line":""},{"line_number":2603,"context_line":"            # Checks if the migration needs a disk resize down."},{"line_number":2604,"context_line":"            root_down \u003d new_instance_type[\u0027root_gb\u0027] \u003c instance.root_gb"},{"line_number":2605,"context_line":"            booted_from_volume \u003d self.is_volume_backed_instance("},{"line_number":2606,"context_line":"                     context, instance, bdms)"},{"line_number":2607,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_d6e6e043","line":2604,"in_reply_to":"ba3cc151_964cd877","updated":"2015-07-06 12:29:42.000000000","message":"Done","commit_id":"76d5f2016b5bad1a8c8f5fd02626bfed6f7a5056"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"506238595cd6e20270f1d5a663e165686240c0d2","unresolved":false,"context_lines":[{"line_number":2605,"context_line":"            booted_from_volume \u003d self.is_volume_backed_instance("},{"line_number":2606,"context_line":"                     context, instance, bdms)"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"            if (root_down and not booted_from_volume):"},{"line_number":2609,"context_line":"                reason \u003d _(\"Unable to resize disk down.\")"},{"line_number":2610,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":2611,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_b6031c0d","line":2608,"updated":"2015-07-06 12:27:30.000000000","message":"you do not need the brackets here","commit_id":"76d5f2016b5bad1a8c8f5fd02626bfed6f7a5056"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"140814bc54be3d3981c249772164a4653141149e","unresolved":false,"context_lines":[{"line_number":2605,"context_line":"            booted_from_volume \u003d self.is_volume_backed_instance("},{"line_number":2606,"context_line":"                     context, instance, bdms)"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"            if (root_down and not booted_from_volume):"},{"line_number":2609,"context_line":"                reason \u003d _(\"Unable to resize disk down.\")"},{"line_number":2610,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":2611,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_f6e3e431","line":2608,"in_reply_to":"ba3cc151_b6031c0d","updated":"2015-07-06 12:29:42.000000000","message":"Done","commit_id":"76d5f2016b5bad1a8c8f5fd02626bfed6f7a5056"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5087832a44a2af00af0069bc31d5e7389c09dac4","unresolved":false,"context_lines":[{"line_number":2609,"context_line":"                reason \u003d _(\"Unable to resize disk down.\")"},{"line_number":2610,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":2611,"context_line":""},{"line_number":2612,"context_line":"            if root_down and booted_from_volume:"},{"line_number":2613,"context_line":"                for bdm in bdms:"},{"line_number":2614,"context_line":"                    if bdm.volume_id and bdm.device_name \u003d\u003d \u0027/dev/vda\u0027:"},{"line_number":2615,"context_line":"                        vol \u003d self.volume_api.get(context, bdm.volume_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba3cc151_afeb2212","line":2612,"updated":"2015-07-09 04:09:03.000000000","message":"afaik Nova doesn\u0027t resize root volume. why do you check its size?\n\nsee also https://bugs.launchpad.net/nova/+bug/1469179","commit_id":"9d3d5fe071f24c710cec616641d0495d1647a21d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ea61491f9a610b1607011cb27edad103a3364d42","unresolved":false,"context_lines":[{"line_number":2609,"context_line":"                reason \u003d _(\"Unable to resize disk down.\")"},{"line_number":2610,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":2611,"context_line":""},{"line_number":2612,"context_line":"            if root_down and booted_from_volume:"},{"line_number":2613,"context_line":"                for bdm in bdms:"},{"line_number":2614,"context_line":"                    if bdm.volume_id and bdm.device_name \u003d\u003d \u0027/dev/vda\u0027:"},{"line_number":2615,"context_line":"                        vol \u003d self.volume_api.get(context, bdm.volume_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba3cc151_8f597eff","line":2612,"in_reply_to":"ba3cc151_afeb2212","updated":"2015-07-09 04:13:51.000000000","message":"Thanks for your review, I\u0027m aware of your idea. This was submitted before your patch and in the current implementation, nova cannot boot an instance if the root_gb of the flavor is less than volume size, this is just to make resize and boot obey the same rule.","commit_id":"9d3d5fe071f24c710cec616641d0495d1647a21d"}]}