)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"56eb6f72da76558a905baf70958767c7a680471a","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    def describe_instances(self, context, **kwargs):"},{"line_number":986,"context_line":"        # Optional DescribeInstances argument"},{"line_number":987,"context_line":"        instance_id \u003d kwargs.get(\u0027instance_id\u0027, None)"},{"line_number":988,"context_line":"        self._enforce_valid_instance_ids(context, instance_id)"},{"line_number":989,"context_line":"        return self._format_describe_instances(context,"},{"line_number":990,"context_line":"                instance_id\u003dinstance_id)"},{"line_number":991,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F2K4%3D","line":988,"updated":"2013-01-02 17:20:34.000000000","message":"This hits the database to fetch the instances and throw them away, and then the format call below fetches them again. Any reason not to collect the list of instances from the enforce call and pass them to the format call to avoid the dual-lookup?","commit_id":"9a3d9b0ad68ca88d5038614aa55863abf138a84e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d93eaf746efb9d5d697de774fd17eef3f072ff8a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                instance_uuid \u003d ec2utils.ec2_inst_id_to_uuid(context, ec2_id)"},{"line_number":229,"context_line":"                instance \u003d self.compute_api.get(context, instance_uuid)"},{"line_number":230,"context_line":"                instances.append(instance)"},{"line_number":231,"context_line":"        return instances"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def _get_image_state(self, image):"},{"line_number":234,"context_line":"        # NOTE(vish): fallback status if image_state isn\u0027t set"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0%2Bw%3D","line":231,"updated":"2013-01-03 14:44:02.000000000","message":"This returns a list...","commit_id":"c29771a867ccfecabe84e5ef0796fdf8e102bf68"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d93eaf746efb9d5d697de774fd17eef3f072ff8a","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"        reservations \u003d {}"},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":"        if not instances_cache:"},{"line_number":1093,"context_line":"            instances_cache \u003d {}"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"        # NOTE(vish): instance_id is an optional list of ids to filter by"},{"line_number":1096,"context_line":"        if instance_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0%2Bo%3D","line":1093,"updated":"2013-01-03 14:44:02.000000000","message":"...This seems to imply a dict, if the cache isn\u0027t passed in...","commit_id":"c29771a867ccfecabe84e5ef0796fdf8e102bf68"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d93eaf746efb9d5d697de774fd17eef3f072ff8a","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"            instances \u003d []"},{"line_number":1098,"context_line":"            for ec2_id in instance_id:"},{"line_number":1099,"context_line":"                if ec2_id in instances_cache:"},{"line_number":1100,"context_line":"                    instances.append(instances_cache[ec2_id])"},{"line_number":1101,"context_line":"                else:"},{"line_number":1102,"context_line":"                    try:"},{"line_number":1103,"context_line":"                        instance_uuid \u003d ec2utils.ec2_inst_id_to_uuid(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0%2Bk%3D","line":1100,"updated":"2013-01-03 14:44:02.000000000","message":"...and this seems to expect that it is a dict. Am I missing something about ec2_id that makes this okay?","commit_id":"c29771a867ccfecabe84e5ef0796fdf8e102bf68"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f2a6b314655bb2a2274c415aa10f8d7d256f13f8","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"            instances \u003d []"},{"line_number":1098,"context_line":"            for ec2_id in instance_id:"},{"line_number":1099,"context_line":"                if ec2_id in instances_cache:"},{"line_number":1100,"context_line":"                    instances.append(instances_cache[ec2_id])"},{"line_number":1101,"context_line":"                else:"},{"line_number":1102,"context_line":"                    try:"},{"line_number":1103,"context_line":"                        instance_uuid \u003d ec2utils.ec2_inst_id_to_uuid(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F0a0%3D","line":1100,"in_reply_to":"AAAAM3%2F%2F0%2Bk%3D","updated":"2013-01-03 21:38:44.000000000","message":"No. I\u0027m just an idiot. I shall fix.","commit_id":"c29771a867ccfecabe84e5ef0796fdf8e102bf68"}]}