)]}'
{"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b64d32a1ba187b835fd3490c8c73067230c3c572","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"        xml \u003d self._get_instance_xml(d, self.vif_ib_hostdev)"},{"line_number":1018,"context_line":"        doc \u003d etree.fromstring(xml)"},{"line_number":1019,"context_line":"        node \u003d doc.findall(\u0027./devices/hostdev\u0027)[0]"},{"line_number":1020,"context_line":"        self.assertEqual(len(node), 1)"},{"line_number":1021,"context_line":"        self._assertPciEqual(node, self.vif_ib_hostdev)"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    def test_midonet_ethernet_vif_driver(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_e3458117","line":1020,"updated":"2015-07-19 11:33:11.000000000","message":"expected value should be first","commit_id":"b76740d73cc564a62898fea83fef8a85520a3fc5"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"eafe3f505e9205699202c2afa362c9fbac3837ea","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"        xml \u003d self._get_instance_xml(d, self.vif_ib_hostdev)"},{"line_number":1018,"context_line":"        doc \u003d etree.fromstring(xml)"},{"line_number":1019,"context_line":"        node \u003d doc.findall(\u0027./devices/hostdev\u0027)[0]"},{"line_number":1020,"context_line":"        self.assertEqual(len(node), 1)"},{"line_number":1021,"context_line":"        self._assertPciEqual(node, self.vif_ib_hostdev)"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    def test_midonet_ethernet_vif_driver(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_c3e645e8","line":1020,"in_reply_to":"3a50d1a3_e3458117","updated":"2015-07-19 12:00:21.000000000","message":"yes you are right, I will respin it","commit_id":"b76740d73cc564a62898fea83fef8a85520a3fc5"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9dd4e817d16b323c0f14a37795a8d9c6526a8bce","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            )"},{"line_number":502,"context_line":"        pci_slot \u003d vif[\u0027profile\u0027][\u0027pci_slot\u0027]"},{"line_number":503,"context_line":"        device_id \u003d instance[\u0027uuid\u0027]"},{"line_number":504,"context_line":"        if not pci_slot:"},{"line_number":505,"context_line":"            return"},{"line_number":506,"context_line":"        vnic_mac \u003d vif[\u0027address\u0027]"},{"line_number":507,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_feb2fe47","line":504,"updated":"2015-05-31 20:55:02.000000000","message":"does it make sense to receive IB vif type without pci_slot? It looks like error condition and should at least log some warning, but looks to me it should behave similar to missing fabric case.","commit_id":"d72771857389c976b9403c7f50e7f72aab574a92"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"2509265b06428638692dd78c768d03a1b0fd8053","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            )"},{"line_number":502,"context_line":"        pci_slot \u003d vif[\u0027profile\u0027][\u0027pci_slot\u0027]"},{"line_number":503,"context_line":"        device_id \u003d instance[\u0027uuid\u0027]"},{"line_number":504,"context_line":"        if not pci_slot:"},{"line_number":505,"context_line":"            return"},{"line_number":506,"context_line":"        vnic_mac \u003d vif[\u0027address\u0027]"},{"line_number":507,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8f606fa6","line":504,"in_reply_to":"7a016987_ec48112f","updated":"2015-06-01 07:59:54.000000000","message":"+1, I think it\u0027s up to the Mech Driver to set all required attributes","commit_id":"d72771857389c976b9403c7f50e7f72aab574a92"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"0516d90f9881305368d2abf450910b396629d5e4","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            )"},{"line_number":502,"context_line":"        pci_slot \u003d vif[\u0027profile\u0027][\u0027pci_slot\u0027]"},{"line_number":503,"context_line":"        device_id \u003d instance[\u0027uuid\u0027]"},{"line_number":504,"context_line":"        if not pci_slot:"},{"line_number":505,"context_line":"            return"},{"line_number":506,"context_line":"        vnic_mac \u003d vif[\u0027address\u0027]"},{"line_number":507,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_ec48112f","line":504,"in_reply_to":"7a016987_feb2fe47","updated":"2015-06-01 07:20:41.000000000","message":"I didn\u0027t see an kind of validation in hw_verb, maybe I need just to remove lines 504-505","commit_id":"d72771857389c976b9403c7f50e7f72aab574a92"}]}