)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0ceaa801143438bf64f3d9d17322b2c3b2120117","unresolved":false,"context_lines":[{"line_number":6000,"context_line":"        flavorid \u003d flavor.flavorid"},{"line_number":6001,"context_line":"        if flavorid not in flavor_cache:"},{"line_number":6002,"context_line":"            try:"},{"line_number":6003,"context_line":"                flavor_cache[flavorid] \u003d flavor_get_by_flavor_id("},{"line_number":6004,"context_line":"                    instance._context, flavorid, \u0027yes\u0027)"},{"line_number":6005,"context_line":"            except exception.FlavorNotFound:"},{"line_number":6006,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_e817ab52","line":6003,"updated":"2015-06-01 16:15:35.000000000","message":"almost tempting to share this code, but the difference in log messages since justified.","commit_id":"39a231f4806588461d94d4923e459868a0dd02ec"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"39ec36bf80ed1dc25b10ecb2f356a81288842263","unresolved":false,"context_lines":[{"line_number":6009,"context_line":"                flavor_cache[flavorid] \u003d objects.Flavor.get_by_flavor_id("},{"line_number":6010,"context_line":"                    deleted_ctx, flavorid)"},{"line_number":6011,"context_line":"            except exception.FlavorNotFound:"},{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_6827c964","line":6012,"updated":"2015-06-03 21:46:23.000000000","message":"I think you need %(flavorid)s instead of %(flavorid)","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c9afa415d74fbc6e38b4206b37901846a4dfca38","unresolved":false,"context_lines":[{"line_number":6009,"context_line":"                flavor_cache[flavorid] \u003d objects.Flavor.get_by_flavor_id("},{"line_number":6010,"context_line":"                    deleted_ctx, flavorid)"},{"line_number":6011,"context_line":"            except exception.FlavorNotFound:"},{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_b3ed36f1","line":6012,"in_reply_to":"5afe65bd_6827c964","updated":"2015-06-03 22:17:53.000000000","message":"Definitely do, I\u0027ve learned this from experience.","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6841b1865b1d493075d0f5120461631a86f948e2","unresolved":false,"context_lines":[{"line_number":6009,"context_line":"                flavor_cache[flavorid] \u003d objects.Flavor.get_by_flavor_id("},{"line_number":6010,"context_line":"                    deleted_ctx, flavorid)"},{"line_number":6011,"context_line":"            except exception.FlavorNotFound:"},{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_742a0480","line":6012,"in_reply_to":"5afe65bd_b3ed36f1","updated":"2015-06-03 23:59:57.000000000","message":"Oopsie, yep.","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"39ec36bf80ed1dc25b10ecb2f356a81288842263","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"},{"line_number":6016,"context_line":"                continue"},{"line_number":6017,"context_line":"        _augment_flavor_to_migrate(flavor, flavor_cache[flavorid])"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_08e4d50a","line":6015,"updated":"2015-06-03 21:46:23.000000000","message":"And I think this has to be {\u0027flavorid\u0027: flavorid} or dict(flavorid\u003dflavorid) in order to work","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c9afa415d74fbc6e38b4206b37901846a4dfca38","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"},{"line_number":6016,"context_line":"                continue"},{"line_number":6017,"context_line":"        _augment_flavor_to_migrate(flavor, flavor_cache[flavorid])"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_f3e3ae03","line":6015,"in_reply_to":"5afe65bd_08e4d50a","updated":"2015-06-03 22:17:53.000000000","message":"I thought our logging wrappers would handle this, but I may be thinking of something else.  Certainly wrapping in a dict is proper.","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6841b1865b1d493075d0f5120461631a86f948e2","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"},{"line_number":6016,"context_line":"                continue"},{"line_number":6017,"context_line":"        _augment_flavor_to_migrate(flavor, flavor_cache[flavorid])"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_f436f4e5","line":6015,"in_reply_to":"5afe65bd_53ff2267","updated":"2015-06-03 23:59:57.000000000","message":"Bah, I feel like I\u0027m sometimes told to do it this way and sometimes the other. Clearly there is a pattern I\u0027m not seeing.","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ff2d494876975dd1b4fa36c407354be800e47849","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"},{"line_number":6016,"context_line":"                continue"},{"line_number":6017,"context_line":"        _augment_flavor_to_migrate(flavor, flavor_cache[flavorid])"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_53ff2267","line":6015,"in_reply_to":"5afe65bd_f3e3ae03","updated":"2015-06-03 22:27:35.000000000","message":"Every time I see it in a review, it makes me wonder if the ability has been added. But a local test yielded:\n\n WARNING __main__ [-] [instance: hi] Flavor %(flavorid)s not found for instance during migration; extra_specs will not be available","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f18e0645d1ecb0e8fe6423e3340013b6a89f3bdf","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"                LOG.warn(_LW(\u0027Flavor %(flavorid) not found for instance \u0027"},{"line_number":6013,"context_line":"                             \u0027during migration; extra_specs will not be \u0027"},{"line_number":6014,"context_line":"                             \u0027available\u0027),"},{"line_number":6015,"context_line":"                         flavorid\u003dflavorid, instance\u003dinstance)"},{"line_number":6016,"context_line":"                continue"},{"line_number":6017,"context_line":"        _augment_flavor_to_migrate(flavor, flavor_cache[flavorid])"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_1e876ad8","line":6015,"in_reply_to":"5afe65bd_f436f4e5","updated":"2015-06-04 02:21:08.000000000","message":"My test program, for anyone curious: http://pastebin.com/FFXdqYA3","commit_id":"d9307a6594f93f6798b1ecfff23da80b45063618"}]}