)]}'
{"nova/loadables.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"9e5674c228aedb8bf64476699c38a8d2238688c4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class BaseLoader(object):"},{"line_number":50,"context_line":"    def __init__(self, loadable_cls_type):"},{"line_number":51,"context_line":"        mod \u003d sys.modules[self.__class__.__module__]"},{"line_number":52,"context_line":"        self.path \u003d os.path.abspath(mod.__path__[0])"},{"line_number":53,"context_line":"        self.package \u003d mod.__package__"},{"line_number":54,"context_line":"        self.loadable_cls_type \u003d loadable_cls_type"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3lA%3D","line":52,"updated":"2012-12-28 20:05:40.000000000","message":"This makes me think the other code that depends on it is broken - relative paths are permitted in sys.path, and in things found from sys.path [though in general this is fragile due to the chance for other code to chdir(). Do we have code that is chdiring? Or just assuming multple path segments?","commit_id":"e9e037920d5140ce60348a54b070bba48da9cef7"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3710d7843fe135e2aa3b59d468374ef9ed5de1d8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class BaseLoader(object):"},{"line_number":50,"context_line":"    def __init__(self, loadable_cls_type):"},{"line_number":51,"context_line":"        mod \u003d sys.modules[self.__class__.__module__]"},{"line_number":52,"context_line":"        self.path \u003d os.path.abspath(mod.__path__[0])"},{"line_number":53,"context_line":"        self.package \u003d mod.__package__"},{"line_number":54,"context_line":"        self.loadable_cls_type \u003d loadable_cls_type"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3i0%3D","line":52,"in_reply_to":"AAAAM3%2F%2F3jU%3D","updated":"2012-12-28 21:04:26.000000000","message":"yeah, thats a broken test. The right way to spell it would be assertEqual(import, os.path.split(thepath)[-1]), which will avoid false matches on foo-import etc, while still handling both absolute and relative paths.","commit_id":"e9e037920d5140ce60348a54b070bba48da9cef7"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"2d35ec6922eef4b2d69a911d7dccbaeea2d2802e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class BaseLoader(object):"},{"line_number":50,"context_line":"    def __init__(self, loadable_cls_type):"},{"line_number":51,"context_line":"        mod \u003d sys.modules[self.__class__.__module__]"},{"line_number":52,"context_line":"        self.path \u003d os.path.abspath(mod.__path__[0])"},{"line_number":53,"context_line":"        self.package \u003d mod.__package__"},{"line_number":54,"context_line":"        self.loadable_cls_type \u003d loadable_cls_type"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3jU%3D","line":52,"in_reply_to":"AAAAM3%2F%2F3lA%3D","updated":"2012-12-28 20:45:59.000000000","message":"It may be that it was just breaking the test\n\nit was asserting that the path endswith(\u0027/\u0027 + import) and the initial / isn\u0027t there.","commit_id":"e9e037920d5140ce60348a54b070bba48da9cef7"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"2d35ec6922eef4b2d69a911d7dccbaeea2d2802e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        classes \u003d []"},{"line_number":82,"context_line":"        for dirpath, dirnames, filenames in os.walk(self.path):"},{"line_number":83,"context_line":"            relpath \u003d os.path.relpath(dirpath, self.path)"},{"line_number":84,"context_line":"            if relpath \u003d\u003d \u0027.\u0027:"},{"line_number":85,"context_line":"                relpkg \u003d \u0027\u0027"},{"line_number":86,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3jQ%3D","line":83,"updated":"2012-12-28 20:45:59.000000000","message":"note that it uses relpath here.","commit_id":"e9e037920d5140ce60348a54b070bba48da9cef7"}]}