)]}'
{"nova/virt/baremetal/driver.py":[{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"0447752b12ec783d0bd6f1a622341b9a3926b730","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                mountpoint \u003d vol[\u0027mount_device\u0027]"},{"line_number":208,"context_line":"                self.attach_volume("},{"line_number":209,"context_line":"                        connection_info, instance[\u0027name\u0027], mountpoint)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                image_info \u003d self.driver.cache_images("},{"line_number":213,"context_line":"                                context, node, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3eU%3D","line":210,"updated":"2012-12-28 23:49:21.000000000","message":"Is pm.start_console() called elsewhere?","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"887c745fefbd8257851f4bc679549d036b0e44a4","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                mountpoint \u003d vol[\u0027mount_device\u0027]"},{"line_number":208,"context_line":"                self.attach_volume("},{"line_number":209,"context_line":"                        connection_info, instance[\u0027name\u0027], mountpoint)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                image_info \u003d self.driver.cache_images("},{"line_number":213,"context_line":"                                context, node, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F20Y%3D","line":210,"in_reply_to":"AAAAM3%2F%2F3cM%3D","updated":"2012-12-31 18:55:43.000000000","message":"Done","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"ddf5d0be85282075b0af43bd5da4105d8834f8ba","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                mountpoint \u003d vol[\u0027mount_device\u0027]"},{"line_number":208,"context_line":"                self.attach_volume("},{"line_number":209,"context_line":"                        connection_info, instance[\u0027name\u0027], mountpoint)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                image_info \u003d self.driver.cache_images("},{"line_number":213,"context_line":"                                context, node, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3cM%3D","line":210,"in_reply_to":"AAAAM3%2F%2F3dM%3D","updated":"2012-12-29 00:23:38.000000000","message":"Yes, ideally, pm.start_console() should be called on demand. But in the current implementation, requests from user is directly go to shellinaboxd, so nova-compute cannot do something about console out of spawn,destroy etc.","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1f2b2b4aaaec8ed6c69bf63c803119ce42468cfd","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                mountpoint \u003d vol[\u0027mount_device\u0027]"},{"line_number":208,"context_line":"                self.attach_volume("},{"line_number":209,"context_line":"                        connection_info, instance[\u0027name\u0027], mountpoint)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                image_info \u003d self.driver.cache_images("},{"line_number":213,"context_line":"                                context, node, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3dM%3D","line":210,"in_reply_to":"AAAAM3%2F%2F3eU%3D","updated":"2012-12-29 00:03:54.000000000","message":"At the moment, no. Shouldn\u0027t that get called only if the user requests a remote terminal, and not on every boot?","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"fa72a90a47f380b36535baf336533372a484f1e5","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                self.attach_volume("},{"line_number":209,"context_line":"                        connection_info, instance[\u0027name\u0027], mountpoint)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                image_info \u003d self.driver.cache_images("},{"line_number":213,"context_line":"                                context, node, instance,"},{"line_number":214,"context_line":"                                admin_password\u003dadmin_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3fc%3D","line":211,"updated":"2012-12-28 23:38:08.000000000","message":"How about activate_bootloader has its own try-block ?\n\n  try:\n    image_info \u003d self.driver.cache_images(...)\n    try:\n      self.driver.activate_bootloader(...)\n    except Exception, e:\n      self.driver.deactivate_bootloader(...)\n      raise e\n  except Exception, e:\n    self.driver.destroy_images(...)\n    raise e","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1f2b2b4aaaec8ed6c69bf63c803119ce42468cfd","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                self.attach_volume("},{"line_number":209,"context_line":"                        connection_info, instance[\u0027name\u0027], mountpoint)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                image_info \u003d self.driver.cache_images("},{"line_number":213,"context_line":"                                context, node, instance,"},{"line_number":214,"context_line":"                                admin_password\u003dadmin_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3dI%3D","line":211,"in_reply_to":"AAAAM3%2F%2F3fc%3D","updated":"2012-12-29 00:03:54.000000000","message":"Done","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"0447752b12ec783d0bd6f1a622341b9a3926b730","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            #             up even after a failed boot or delete"},{"line_number":256,"context_line":"            LOG.warning(_(\"Delete called on non-existing instance %s\")"},{"line_number":257,"context_line":"                    % instance[\u0027uuid\u0027])"},{"line_number":258,"context_line":"            return"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        var \u003d self.driver.define_vars(instance, network_info,"},{"line_number":261,"context_line":"                                               block_device_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3d8%3D","line":258,"updated":"2012-12-28 23:49:21.000000000","message":"\u0027var\u0027 is still used in this method. Is this corrected by following patch(es)?","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1f2b2b4aaaec8ed6c69bf63c803119ce42468cfd","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            #             up even after a failed boot or delete"},{"line_number":256,"context_line":"            LOG.warning(_(\"Delete called on non-existing instance %s\")"},{"line_number":257,"context_line":"                    % instance[\u0027uuid\u0027])"},{"line_number":258,"context_line":"            return"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        var \u003d self.driver.define_vars(instance, network_info,"},{"line_number":261,"context_line":"                                               block_device_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F3dE%3D","line":258,"in_reply_to":"AAAAM3%2F%2F3d8%3D","updated":"2012-12-29 00:03:54.000000000","message":"Ah! Thanks for catching that.","commit_id":"219c2580c2c51ca3a6f87f596905595d62811c1f"}]}