)]}'
{"nova/network/model.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"232d5aefdd517aa18fcb89cb40b59ae35f9456c2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# VIF Types supported by the VMware driver"},{"line_number":85,"context_line":"VIF_MODEL_VIRTUAL_E1000 \u003d \u0027VirtualE1000\u0027"},{"line_number":86,"context_line":"VIF_MODEL_VIRTUAL_E1000E \u003d \u0027VirtualE1000e\u0027"},{"line_number":87,"context_line":"VIF_MODEL_VIRTUAL_PCNET32 \u003d \u0027VirtualPCNet32\u0027"},{"line_number":88,"context_line":"VIF_MODEL_VIRTUAL_SRIOV \u003d \u0027VirtualSriovEthernetCard\u0027"},{"line_number":89,"context_line":"VIF_MODEL_VIRTUAL_VMXNET \u003d \u0027VirtualVmxnet\u0027"},{"line_number":90,"context_line":"VIF_MODEL_VIRTUAL_VMXNET3 \u003d \u0027VirtualVmxnet3\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_8969fec0","line":87,"updated":"2015-06-03 13:56:59.000000000","message":"These 3 already exist above as PCNET, E1000 and E1000E so no need to duplicate them here","commit_id":"ef7d58bceb88a78f250154309fc5d070807f5a7b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"232d5aefdd517aa18fcb89cb40b59ae35f9456c2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"VIF_MODEL_VIRTUAL_PCNET32 \u003d \u0027VirtualPCNet32\u0027"},{"line_number":88,"context_line":"VIF_MODEL_VIRTUAL_SRIOV \u003d \u0027VirtualSriovEthernetCard\u0027"},{"line_number":89,"context_line":"VIF_MODEL_VIRTUAL_VMXNET \u003d \u0027VirtualVmxnet\u0027"},{"line_number":90,"context_line":"VIF_MODEL_VIRTUAL_VMXNET3 \u003d \u0027VirtualVmxnet3\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"VIF_MODEL_ALL \u003d ("},{"line_number":93,"context_line":"    VIF_MODEL_VIRTIO,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_2951ead8","line":90,"updated":"2015-06-03 13:56:59.000000000","message":"I\u0027d suggest we drop the VIRTUAL_ prefix here since its rather pointless - everything is virtual when we\u0027re configuring guests. Likewie EthernetCard is a rather pointless suffix too. so I thin kwe just need to add\n\nVIF_MODEL_SRIOV \u003d \"sriov\"\nVIF_MODEL_VMXNET \u003d \"vmxnet\"\nVIF_MODEL_VMXNET3 \u003d \"vmxnet3\"\n\nSince the vmware driver already allows these 6 values though, we\u0027ll need to add a \u0027coerce\u0027 method in the VIFModel field in nova.objects.fields, that translates the legacy name to the new standard names.\n\nOf course vmware driver will also then need to translate to its internal names, juts as it does already when seeing VIF_MODEL_E1000 / VIF_MODEL_E1000E","commit_id":"ef7d58bceb88a78f250154309fc5d070807f5a7b"}]}