)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"40da777472992193fd24fe54c668a0e53394862a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Stelter-Gliese \u003cds@siriuswhite.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-03 22:58:20 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extract device path after connecting volume when booting LXC instances from volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The local device path is populated by connect_volume, accessing it"},{"line_number":10,"context_line":"earlier will result in a KeyError being thrown."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_ca045f19","line":7,"updated":"2015-06-04 11:08:57.000000000","message":"Can you please prefix this with libvirt","commit_id":"9931732c125bc409228fdbd9dcd4a712494d208a"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"5eabde974ac43e917811de4d0b727a4d78ab8efa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Stelter-Gliese \u003cds@siriuswhite.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-04 17:41:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Extract device path after connecting volume when booting LXC instances from volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The local device path is populated by connect_volume, accessing it"},{"line_number":10,"context_line":"earlier will result in a KeyError being thrown."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_2ac15254","line":7,"updated":"2015-08-20 15:04:02.000000000","message":"Can you please have the first line of the commit message \u003c 50 characters?","commit_id":"01329ca9f2ec47dca3c708b521c7e2b7f29cc8aa"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"be78793fa3f9fb603a2d9f5d5823ba4c57552e1d","unresolved":false,"context_lines":[{"line_number":4261,"context_line":"            disk_info \u003d blockinfo.get_info_from_bdm("},{"line_number":4262,"context_line":"                CONF.libvirt.virt_type, image_meta, root_disk)"},{"line_number":4263,"context_line":"            self._connect_volume(root_disk[\u0027connection_info\u0027], disk_info)"},{"line_number":4264,"context_line":"            disk_path \u003d root_disk[\u0027connection_info\u0027][\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":4265,"context_line":""},{"line_number":4266,"context_line":"            # Get the system metadata from the instance"},{"line_number":4267,"context_line":"            use_cow \u003d instance.system_metadata[\u0027image_disk_format\u0027] \u003d\u003d \u0027qcow2\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ce23b504","line":4264,"updated":"2015-08-18 17:02:39.000000000","message":"I think its worth adding a comment saying that _connect_volume might update the device_path","commit_id":"01329ca9f2ec47dca3c708b521c7e2b7f29cc8aa"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f9414f256978b977757e8caf726c79cf53e22eba","unresolved":false,"context_lines":[{"line_number":4259,"context_line":"        if self._is_booted_from_volume(instance, disk_mapping):"},{"line_number":4260,"context_line":"            root_disk \u003d block_device.get_root_bdm(block_device_mapping)"},{"line_number":4261,"context_line":"            disk_info \u003d blockinfo.get_info_from_bdm("},{"line_number":4262,"context_line":"                CONF.libvirt.virt_type, image_meta, root_disk)"},{"line_number":4263,"context_line":"            self._connect_volume(root_disk[\u0027connection_info\u0027], disk_info)"},{"line_number":4264,"context_line":"            disk_path \u003d root_disk[\u0027connection_info\u0027][\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":4265,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_00f8dcc1","line":4262,"updated":"2015-08-20 21:10:58.000000000","message":"\u003crant\u003eThis is why I don\u0027t like methods updating values and not returning them.  If the return was (disk_info, root_disk) this would be less likely to happen.\u003c/rant\u003e","commit_id":"c9d4dd3d1409f73d18537a9737c67dcadaf3428e"}]}
