)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"59861d5e3bcb2d02bb4dddfba276ddf41aac32b5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"console) will be created for the guest."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint libvirt-log-file-and-serial-console"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic6fbc2402daf28f4db4117be1c7ae7bc3d1a8e9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_f57ee568","line":16,"updated":"2015-07-15 12:48:43.000000000","message":"I think that you need the UpgradeImpact flag here. My only concern is that instances running in K will behave differently to those in L. I understand what you are doing here but maybe we just need to inform the admins...","commit_id":"3191c3e72f7f9a1674b0c605a43092f7e00dc53e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a93b5c6deb9b5c1100ecb60270e92d3aa4057424","unresolved":false,"context_lines":[{"line_number":13,"context_line":"console) will be created for the guest."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint libvirt-log-file-and-serial-console"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic6fbc2402daf28f4db4117be1c7ae7bc3d1a8e9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_db542bcb","line":16,"in_reply_to":"9a41bdd9_f57ee568","updated":"2015-07-15 14:44:06.000000000","message":"Good catch! I didn\u0027t think about this. The next patch set includes this in the commit message.","commit_id":"3191c3e72f7f9a1674b0c605a43092f7e00dc53e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"59861d5e3bcb2d02bb4dddfba276ddf41aac32b5","unresolved":false,"context_lines":[{"line_number":2452,"context_line":"                                                mock_get_arch,"},{"line_number":2453,"context_line":"                                                mock_get_port_number,"},{"line_number":2454,"context_line":"                                                mock_acquire_port):"},{"line_number":2455,"context_line":"        self.flags(enabled\u003dTrue, group\u003d\u0027serial_console\u0027)"},{"line_number":2456,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"        guest \u003d vconfig.LibvirtConfigGuest()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_b5c37d88","line":2455,"updated":"2015-07-15 12:48:43.000000000","message":"can we also have a test when the CONF.serial_console.enabled is false?","commit_id":"3191c3e72f7f9a1674b0c605a43092f7e00dc53e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a93b5c6deb9b5c1100ecb60270e92d3aa4057424","unresolved":false,"context_lines":[{"line_number":2452,"context_line":"                                                mock_get_arch,"},{"line_number":2453,"context_line":"                                                mock_get_port_number,"},{"line_number":2454,"context_line":"                                                mock_acquire_port):"},{"line_number":2455,"context_line":"        self.flags(enabled\u003dTrue, group\u003d\u0027serial_console\u0027)"},{"line_number":2456,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"        guest \u003d vconfig.LibvirtConfigGuest()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_dbbd0b03","line":2455,"in_reply_to":"9a41bdd9_b5c37d88","updated":"2015-07-15 14:44:06.000000000","message":"The next patch set will have that test. The test case will reveal that the method under test should get refactored, I\u0027ve put a note to it and will do it in later patch sets.","commit_id":"3191c3e72f7f9a1674b0c605a43092f7e00dc53e"}]}