)]}'
{"nova/objects/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8f7fbe1b8854027a95356942d1262e1111042510","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    #   since they were not added until version 1.2."},{"line_number":179,"context_line":"    obj_relationships \u003d {}"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    # Temporary until we inherit from o.vo.base.VersionedObject"},{"line_number":182,"context_line":"    indirection_api \u003d None"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8a9cbd6a","line":181,"updated":"2015-06-14 14:24:25.000000000","message":"Can we add a TODO here?","commit_id":"d95c05a8fd2f762765408b9cf84da7c8d34a7892"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c2c3ba31ca38b745c7d144409d99ec7233813bc1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        # once below."},{"line_number":218,"context_line":"        compatible_match \u003d None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        obj_classes \u003d NovaObjectRegistry.obj_classes()"},{"line_number":221,"context_line":"        for objclass in obj_classes[objname]:"},{"line_number":222,"context_line":"            if objclass.VERSION \u003d\u003d objver:"},{"line_number":223,"context_line":"                return objclass"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af86dd1_350f2fe3","line":220,"updated":"2015-06-12 21:30:14.000000000","message":"Perhaps in the premature optimization category, but could this be moved to before line 209?  Then, the membership test in 209 can be against obj_classes instead of having a redundant call to NovaObjectRegistry.obj_classes().","commit_id":"d95c05a8fd2f762765408b9cf84da7c8d34a7892"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7194cae5b1b9653f64ac0151fe5f6a86ef383131","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        # once below."},{"line_number":218,"context_line":"        compatible_match \u003d None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        obj_classes \u003d NovaObjectRegistry.obj_classes()"},{"line_number":221,"context_line":"        for objclass in obj_classes[objname]:"},{"line_number":222,"context_line":"            if objclass.VERSION \u003d\u003d objver:"},{"line_number":223,"context_line":"                return objclass"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af86dd1_f948715d","line":220,"in_reply_to":"1af86dd1_350f2fe3","updated":"2015-06-12 21:52:09.000000000","message":"Yeah, I could do that. All this code goes away when we switch the base class to the library, so .. meh :)\n\nI can do that if I have to rebase or something.","commit_id":"d95c05a8fd2f762765408b9cf84da7c8d34a7892"}]}